<mkorpershoek>
I've added `u-boot-dfu` for the changes targeting v2024.01-rc* and `u-boot-dfu-next` for the next branch
<Tartarus>
mkorpershoek: Note that I'm not as strict as the kernel is, wrt changes coming in between -rc1 and -rc2, and then I open -next after -rc2 and really do hope people keep changes to mater as fixes/very isolated and well reasoned changes
<Tartarus>
and -rc2/-next is next Monday
<mkorpershoek>
ok. keeping that in mind, I would pick `u-boot-dfu` and send you a PR by friday with fixes, including 20231029223740.284149-1-marex@denx.de
<mkorpershoek>
thank you for the help. This is all very new to me and I don't want to cause any troubles
<Tartarus>
You're doing good :)
ldevulder has joined #u-boot
tnovotny has joined #u-boot
tnovotny_ has quit [Ping timeout: 248 seconds]
ldevulder has quit [Quit: Leaving]
redbrain has joined #u-boot
goliath has quit [Quit: SIGSEGV]
persmule has quit [Remote host closed the connection]
persmule has joined #u-boot
matthias_bgg has quit [Quit: Leaving]
sstiller has quit [Quit: Leaving]
goliath has joined #u-boot
qqq has joined #u-boot
jaganteki has joined #u-boot
persmule has quit [Ping timeout: 256 seconds]
<calebccff>
hey Tom, not sure what your IRC nick is!
<narmstrong>
Tartarus: thx! that was fast!
<Tartarus>
hey calebccff thanks for joining here
<Tartarus>
I'm emailing you both a handful of things now
<calebccff>
awesome, thanks!
GNUtoo has quit [Remote host closed the connection]
<Tartarus>
I don't know how the ipq4xx stuff is handled elsewhere so my comments are just that "default n" shouldn't be added anywhere as it's redundant
Clamor has quit [Ping timeout: 264 seconds]
Clamor has joined #u-boot
<marex>
mkorpershoek: youre doing good indeed
<calebccff>
tartarus: thanks for that, I have Bhupesh's QUSB2 patches in my local tree, I'm waiting to get this cleanup done before introducing anything new
<mkorpershoek>
investigating but it seems dfu.h is included from quite some places even on boards without CONFIG_CMD_DFU :(
<calebccff>
regarding ipq40xx, merging with mach-snapdragon is definitely the way to go
flom84 has joined #u-boot
stefanro has quit [Quit: Leaving.]
tnovotny has quit [Quit: Leaving]
<marex>
mkorpershoek: probably depends on DFU ... not set on some platform which pulls in dfu.h
persmule has joined #u-boot
<mkorpershoek>
marex: yes there are plenty of platforms who #include <dfu.h> but don't have CONFIG_DFU. am65x_evm_r5_usbmsc_defconfig breaks for example :(
<Tartarus>
mkorpershoek: Oh that commit, yeah, ugh
<Tartarus>
calebccff: If you're going to post a new version of tthose USB patches, I'll mark those as superseded for now
<Tartarus>
That pastebin is probably better, honestly
<Tartarus>
Or we just do what the series I linked is, I don't really know for sure what's nicer, in the end
<Tartarus>
I don't like having #include in the middle of a file either
<Tartarus>
But splitting the file itself up also didn't make sense, iirc
<mkorpershoek>
I think the pastebin is simpler, but it generates repetition.
<mkorpershoek>
I will give it some thinking
<mkorpershoek>
so what's the procedure from here? I applied a patch in my -next tree that breaks CI. Can I (once I figured out a nice way to fix it) squash this (and thus force-push) if the original author is ok with my fixup ?
<mkorpershoek>
I usually don't like force-pushing it seems better than to post a fix on top in this case
<Clamor>
mkorpershoek: what is wrong with force pushing if it provides a clean sequence of commits to be rebased
<calebccff>
tartarus: ok that's fine
<Tartarus>
mkorpershoek: To the custodian trees you can force-push stuff until it's happy, yes.
<marex>
mkorpershoek: or just do git commit --fixup and then rebase --autosquash once at the end
<mkorpershoek>
Clamor: I usually don't like force-pushing publicly facing things (since it's unclear if they are development branches or not)
<mkorpershoek>
ok, great. Thanks a lot
<Tartarus>
mkorpershoek: It's documented in places that no one should rely on the custodian trees for stable githashes
<Tartarus>
Only the main tree
mckoan is now known as mckoan|away
<mkorpershoek>
ok. sorry I missed that from the docs. Will read again
<Tartarus>
I'm fairly certain it's in the docs, if not, it should be
<Tartarus>
narmstrong, calebccff: So, lets wait a day or two in case rfried is able to chime in and perhaps wants to be kept as a Reviewer, but then please send me a PR with the MAINTAINERS update if nothing else, thanks.
<Clamor>
Tartarus: may I volunteer as tegra custodian?
<Tartarus>
Clamor: Please send a patch volunteering to be a co-custodian and cc tagr, yeah. And also sign up with source.denx.de if you haven't already and let me know if you get the confirmation email
<Clamor>
Thanks
monstr has quit [Remote host closed the connection]
vagrantc has joined #u-boot
flom84 has quit [Quit: Leaving]
goliath has joined #u-boot
<Clamor>
Tartarus: should I send just to denx.de and cc to tagr?
<Tartarus>
Yes, the ML and CC tagr and myself
<Clamor>
Tartarus: done, now lets see what tagr will say.
ikarso has joined #u-boot
jaganteki has joined #u-boot
Clamor has quit [Read error: Connection reset by peer]
redbrain has quit [Ping timeout: 255 seconds]
redbrain has joined #u-boot
pgreco_ has joined #u-boot
pgreco has quit [Ping timeout: 258 seconds]
frieder has quit [Remote host closed the connection]
jaganteki has quit [Quit: Client closed]
apritzel_ has joined #u-boot
mmu_man has joined #u-boot
slobodan has quit [Ping timeout: 258 seconds]
goliath has quit [Quit: SIGSEGV]
mmu_man has quit [Ping timeout: 245 seconds]
persmule has quit [Remote host closed the connection]