LuK1337 changed the topic of #titandev to: Loliés! | *yiff* | https://libera.irclog.whitequark.org/titandev
dpawlik3 has joined #titandev
dpawlik3 is now known as dpawlik
<LuK1337> how is that even possible
<LuK1337> isClickable() strictly checks for Integer.MIN_VALUE
<LuK1337> but he's getting exactly index=(Integer.MIN_VALUE - 1) / 3
<luca020400> overflow?
<luca020400> somehow?
<luca020400> / 3 is weird
<luca020400> maybe we are using signed/unsigned somewhere?
<LuK1337> func expects int
<LuK1337> so...
<luca020400> ok I see why it's / 3
<LuK1337> also "3" is probably broken with >3x3 patterns
<LuK1337> but still, how is that even possible
<LuK1337> the only number that would return this index
<LuK1337> is MIN_VALUE
<LuK1337> and there's if check for it...
<luca020400> how is it even possible
<LuK1337> right?
<LuK1337> for (int i = Integer.MIN_VALUE; i < Integer.MAX_VALUE; i++) {
<LuK1337> if (((i - VIRTUAL_BASE_VIEW_ID) / 3) == 715827882)
<LuK1337> System.out.println(""+i);
<LuK1337> }
<LuK1337> only returns -2147483648
<LuK1337> so...
<LuK1337> i don't understand how it's possible
<luca020400> they are all ints
<luca020400> where is onPopulateNodeForVirtualView called?
<LuK1337> core/java/com/android/internal/widget/ExploreByTouchHelper.java:444
<luca020400> ok I didn't have tree at hand
<luca020400> some weird shit is going on with a11y
<luca020400> does he use some kind of screen reader?
<LuK1337> maybe?
<luca020400> it dies on virtual display handling
<luca020400> maybe the fod layer?
<LuK1337> eh
<LuK1337> i think that's looking for "what causes it to look for accessibility paths"
<LuK1337> rather than why would accessibility related code be broken in this way
<luca020400> that's why I asked if a11y was enabled
<luca020400> if it wasn't no idea why it went there
<LuK1337> yeah, it only happens with screen reader
<LuK1337> just repro'd
<LuK1337> tho
<LuK1337> i'm crashing in different place...?
<LuK1337> 09-27 17:27:57.981 6120 6120 E AndroidRuntime: at com.android.internal.widget.LockPatternView$PatternExploreByTouchHelper.getBoundsForVirtualView(LockPatternView.java:1636)
<LuK1337> i'm crashing there
<LuK1337> the fix is super stupid
<LuK1337> but that's what google did
<LuK1337> (latest S public beta for barbet)
<luca020400> wtf
<luca020400> LuK1337: line #1636?
<luca020400> I know it's unused
<luca020400> oh
<luca020400> nvm