azonenberg changed the topic of #scopehal to: ngscopeclient, libscopehal, and libscopeprotocols development and testing | https://github.com/ngscopeclient/scopehal-apps | Logs: https://libera.irclog.whitequark.org/scopehal
<_whitenotifier-e> [scopehal] d235j synchronize pull request #841: Refactor of Cmake scripts - https://github.com/ngscopeclient/scopehal/pull/841
<_whitenotifier-e> [scopehal-apps] d235j synchronize pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
<_whitenotifier-3> [starshipraider] lixing865 forked the repository - https://github.com/lixing865
Degi_ has joined #scopehal
Degi has quit [Ping timeout: 260 seconds]
Degi_ is now known as Degi
<_whitenotifier-3> [scopehal-apps] d235j synchronize pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
<_whitenotifier-e> [scopehal-apps] d235j synchronize pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
<_whitenotifier-3> [scopehal-apps] d235j synchronize pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
<_whitenotifier-e> [scopehal-apps] d235j synchronize pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
<d1b2> <david.rysk> Sorry for all the churn, I'm trying to make these scripts better
<d1b2> <david.rysk> (autodetect stuff etc)
<_whitenotifier-e> [scopehal] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/ngscopeclient/scopehal/compare/7d59335db7e7...5eeaf3e21288
<_whitenotifier-3> [scopehal] azonenberg 5eeaf3e - SpectrogramFilter: reuse existing waveform if possible
<_whitenotifier-e> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±5] https://github.com/ngscopeclient/scopehal-apps/compare/411cf9440dee...6e13a776fd12
<_whitenotifier-3> [scopehal-apps] azonenberg 6e13a77 - Fixed some possible race conditions in rendering of density function waveforms
Darius has quit [Quit: Bye]
Darius has joined #scopehal
bvernoux has joined #scopehal
<_whitenotifier-3> [scopehal-apps] d235j synchronize pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
<_whitenotifier-e> [scopehal] d235j synchronize pull request #841: Refactor of Cmake scripts - https://github.com/ngscopeclient/scopehal/pull/841
<_whitenotifier-3> [scopehal-apps] garthk starred scopehal-apps - https://github.com/garthk
bvernoux has quit [Quit: Leaving]
<_whitenotifier-3> [scopehal-apps] d235j synchronize pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
<_whitenotifier-3> [scopehal-apps] d235j synchronize pull request #672: Move test initialization and teardown into Catch2 event listeners - https://github.com/ngscopeclient/scopehal-apps/pull/672
<d1b2> <david.rysk> Could I request a review of 672? @azonenberg
<d1b2> <johnsel> I'll look at it as well
<d1b2> <david.rysk> alright. I was told that tests are broken on headless, which this should fix
<d1b2> <johnsel> well they're broken because it needs Vulkan
<d1b2> <david.rysk> no, they're broken because the init/teardown is in main() instead of in the callback functions that Catch2 calls at the start and end of the test
<d1b2> <david.rysk> when that's in the callback functions, they aren't called when Catch2 is merely listing the available tests
<d1b2> <david.rysk> meaning -- build being broken
<d1b2> <david.rysk> they won't work without Vulkan, obviously, though they all pass with Lavapipe for me, so that would be one way to run them on CI
<d1b2> <johnsel> I see well broken in 2 ways then
<d1b2> <david.rysk> broken both build and run 🙂
<azonenberg> @johnsel this should speed the build up a bunch and also eliminate those glfw init failed errors we get during catch_discover_tests
<d1b2> <johnsel> as for the run, we will have Vulkan on the new vm
<azonenberg> (once it's debugged)
<d1b2> <david.rysk> yeah, that PR makes it so that catch_discover_tests does not try to init Vulkan anymore
<d1b2> <david.rysk> anyway, my larger cmake rework is still being worked on, but feel free to test! I think it's reliable on most platforms now.
<d1b2> <david.rysk> I'm also going to have to modify the documentation
<d1b2> <david.rysk> also if someone could bump our nativefiledialog-extended to latest upstream that would be helpful
Bird|otherbox has quit [Remote host closed the connection]
Bird|otherbox has joined #scopehal
<_whitenotifier-e> [scopehal-apps] d235j edited pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
<_whitenotifier-3> [scopehal-apps] d235j edited pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
<_whitenotifier-e> [scopehal-apps] d235j edited pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673