00:44 <_whitenotifier-3> [scopehal] azonenberg 562d994 - Removed vestigial TDRStepDeEmbed and OFDMDemodulator filters as they were pretty much dead code that didn't work or do anything close to what it needed to

00:44 <_whitenotifier> [scopehal] azonenberg pushed 3 commits to master [+0/-4/±7] https://github.com/ngscopeclient/scopehal/compare/177ae0c45cc2...3a1bcc03a01a

00:45 <_whitenotifier-3> [scopehal] azonenberg 3a1bcc0 - FFTFilter: removed CPU fallback implementation

00:45 <_whitenotifier> [scopehal] azonenberg 831aab1 - FFTFilter: Removed AVX versions of FFT output processing in preparation for going full Vulkan

00:46 <_whitenotifier-3> [scopehal-apps] azonenberg 49f8f2c - Removed references to AVX2 FFT acceleration. Removed unit test for AVX2 accelerated Blackman-Harris window that no longer exists.

00:46 <_whitenotifier> [scopehal-apps] azonenberg pushed 2 commits to master [+0/-1/±6] https://github.com/ngscopeclient/scopehal-apps/compare/fec700327000...269780b57184

00:46 <_whitenotifier> [scopehal-apps] azonenberg 269780b - Filter_FFT test: added CPU implementation moved out from FFTFilter class

00:46 <azonenberg> And with that, all of our filters are now FFTS-free

00:46 <d1b2> <david.rysk> yay finally

00:46 <azonenberg> The codebase as a whole is not

00:46 <d1b2> <david.rysk> do they all have Vulkan implementations where that's helpful?

00:47 <azonenberg> TestWaveformSource still uses FFTS (in the demo oscilloscope, i dont think anything else uses that) so we have to make that use vkFFT

00:47 <azonenberg> and then all of the FFT-ish unit tests use FFTS, but those are planned to transition to FFTW since it's OK if the test binaries which we don't redistribute become GPL

00:47 <azonenberg> so FFTW will be required for devs building unit tests but not end users, and FFTS will be completely removed

00:48 <azonenberg> vkFFT will be the only shipped FFT lib in the application itself

00:48 <azonenberg> so all of our ffts will use it

00:48 <azonenberg> And we do not have vulkan implementations of every potentially acceleratable filter, but we do of everything that uses FFT

00:48 <azonenberg> At least, of the FFT code and immediate postprocessing

00:49 <azonenberg> Right now we do FFT peak detection on the CPU, which means after FFT-ing we have to immediately pull the waveform off the GPU and onto the CPU to do the peak search (and our peak search algorithm sucks)

00:49 <azonenberg> Making a better, GPU accelerated peak detection algorithm is on the wishlist but i have too many things going on to actively work on it

00:49 <azonenberg> but we're at the point that peak detection takes longer than the FFT proper for smaller datasets