<novakane>
I find that switching a view to tilling/floating mode is super smooth on the scene branch, never switched so much to floating in my life :P
<novakane>
anyway seems like most bugs reported have been fixed, don't think I have anything with CSD to test the related problems but other than the map/unmap bug river run nicely
taupiqueur has joined #river
<novakane>
oh wait, if I put firefox in fullscreen, when exiting it the tabs bar and address bar are not rendered anymore
<novakane>
it seems that xwayland clients are only rendered if I switch to an other tag and switch back to the one with the view
Ordoviz has joined #river
<novakane>
hmm actually it seems to be unfocus and refocus the view that render it
Ordoviz has quit [Ping timeout: 246 seconds]
<ifreund>
novakane: should have that fullscreen bug you saw with firefox fixed now
<ifreund>
I think that bug you're seeing with the xwayland clients is related to the map/unmap issue. I've actually hit that with wayland clients as well while running under valgrind xD
<novakane>
yep that's fixed
<novakane>
oh, have you any idea what's the cause of this issue?
<ifreund>
something to do with saved buffers and the transaction system at a guess, I haven't taken a proper look yet though
<ifreund>
xwayland views are treated specially in that we don't wait for them to respond to configures before committing transactions
<novakane>
I feel like I need to relearn the whole river codebase now xD
<ifreund>
yeah, a lot has changed but I think it's all for the better :)
<ifreund>
I'm liking the kernel-style circular linked lists a lot more than the zig std ones
<ifreund>
and I'm very happy to have gotten rid of ViewStack lol
<novakane>
yeah the view code seems really cleaner, I need to read more about the scene API though
<novakane>
is there more doc than the comments in the scene header btw?
<ifreund>
not really no
<novakane>
alright that's fine, I just need to really looks at this more than a glance, beens months I say this lol
<novakane>
ifreund: also do you need some help with some part of the PR that you can delegate or your prefer to do it yourself?
<ifreund>
novakane: I think the best way to help out is through testing/reporting bugs, I don't want to worry about limiting scope to avoid merge conflicts until this is merged
<ifreund>
thanks though
<novakane>
yeah that's fair, I intend to daily use it to test, if it runs fine enough, which seems to be the case
<waleee>
tangentially on-topic, but how's dwl's scene graph support?
<waleee>
the amount of code in the pr that added it was quite miniscule
<waleee>
(so I imagine it has loads of possibly unhandled edge cases)
<ifreund>
no idea
<ifreund>
if you're trying to compare that to the size of the river PR note that the river PR takes the opportunity to do a significant amout of other refactoring
<waleee>
yeah, I noticed that you had some transaction related stuff in there
<ifreund>
for example rewriting the transaction system to fix some long standing issues and clean things up
<ifreund>
> (so I imagine it has loads of possibly unhandled edge cases)
<ifreund>
I don't think that that protocol is really necessary here, I think input methods should probably be universally allowed
<leon-p>
which would require a working protocol for them first, which I don't see happening anytime soon unfortunately
<leon-p>
so no T9 input in river for now
jao has joined #river
dbuckley has joined #river
taupiqueur has joined #river
taupiqueur1 has joined #river
taupiqueur has quit [Ping timeout: 246 seconds]
<ifreund>
leon-p, novakane: just pushed a commit that seems to fix the imperfect frames on map/unmap to me. Can either of you still reproduce?
<novakane>
let me try that
<novakane>
map seems good but unmap is still wrong
<ifreund>
ok, I was somewhat skeptical that that had really fixed it for unmap but I was never able to reproduce it for unmap reliably in the first place...
<ifreund>
thanks for testing :)
<novakane>
just need to remove the ability to close views and problem solved :P
jao has quit [Ping timeout: 256 seconds]
waleee has joined #river
Szadek has joined #river
angry_vincent has quit [Remote host closed the connection]
<leon-p>
ifreund: can confirm, map works, unmap still flickers
<leon-p>
other than that, this feels super smooth
<leon-p>
can't remember any other wayland desktop feeling this great
<ifreund>
leon-p: I figured out what's wrong with unmap, about to push a fix
<leon-p>
nice!
<ifreund>
(it's an annoying wl_signal ordering issue thing with the wlroots scene graph)
<ifreund>
see #wlroots
<ifreund>
I'm not really sure why it would be much smoother than sway tbh
<ifreund>
river doesn't do any dynamic memory allocation as part of the transaction system, perhaps that helps with latency
<ifreund>
sway allocates quite a bit iirc
<leon-p>
I haven't used sway in a long time, it probably also feels nice now, but back then resizing always had some flicker
<ifreund>
pushed the fix :)
<leon-p>
Will try it out as soon as I am done with this lecture
<leon-p>
I think I found another bug: when resizing via pointer and the client takes more than usual to update, trying to move the view with the pointer afterwards causes weird pointer movements