<peepsalot>
then open the next PR for performance-* checks
<peepsalot>
its kinda fun going through and resolving as many as possible. i still have a bunch more to go
<peepsalot>
should I continue to split them up by category like that? or would anyone rather have them all in a single huge PR?
<peepsalot>
i have the `performance-*` ones already done locally. I was thinking of doing many of the `misc-*` checks next, then some of the `cppcoreguidelines-*` ones
<peepsalot>
there was a surprising number of use-after-move issues that I fixed. i don't know how those haven't caused issues yet.
<teepee>
wow, that's a lot of stuff
<teepee>
I think keeping the categories a bit separate is probably better. it's a relatively big change so if things are similar that helps
<peepsalot>
yeah, it ends up touching a lot of the sources. I guess it raises some concerns of conflicting with existing PRs etc. much like the big uncrustify commit
<peepsalot>
teepee: did you see the one I already pushed, or you just looking that the PR i linked now?
<teepee>
yep, I saw the other one, but just browsed through the current one
epony has quit [Read error: Connection reset by peer]
kintel has joined #openscad
<peepsalot>
teepee: i was just looking at my openscad-nightly binary (curious if it changed in size before/after an update), and noticed that it has a modification date of "Sep 21 2014"
<peepsalot>
is that actually controlled by the deb repo and not my filesystem? not a big deal, I just thought it was strange
othx has quit [Ping timeout: 248 seconds]
othx has joined #openscad
epony has joined #openscad
kintel has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
ActionDave has quit [Remote host closed the connection]
ActionDave has joined #openscad
<peepsalot>
the cppcoreguidelines clang-tidy checks are some of the trickier ones. i might need some guidance on whether some of these are worth adding / addressing