a3f has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
shoragan has quit [Quit: quit]
a3f has joined #openocd
shoragan has joined #openocd
olerem has quit [Read error: Connection reset by peer]
a3f has quit [Read error: Connection reset by peer]
shoragan has quit [Read error: Connection reset by peer]
a3f has joined #openocd
shoragan has joined #openocd
olerem has joined #openocd
cozycactus has joined #openocd
Hawk777 has joined #openocd
d_olex_ has joined #openocd
d_olex has quit [Read error: Connection reset by peer]
nerozero has joined #openocd
dliviu has quit [Ping timeout: 244 seconds]
nashpa has joined #openocd
Hawk777 has quit [Quit: Leaving.]
<gamiee>
zapb_ : Oh! I thought you mean TCL code style, not C code style, sorry for that. I did read the code style before, applied many stuff, but when re-checking now, it seems I missed some stuff, I will do review again.
<gamiee>
One question: example you provided, yes, return_value is used only in the while scope, although, is there any functional problem with this? I always used this principle, when the variable is re-used in the another while/for iteration, to not push/pop from the stack multiple times (but I guess compiler optimizes this anyway). Still, I always seen this as more readable. Of course it can lead to errors if wrongly used, but in those scenarios I would of course
<gamiee>
put it into the while scope.
<gamiee>
And about the openocd.texi, you are absolutely right, I will add it to the documentation, thanks!
<zapb_>
gamiee, there is no functional problem with that. it's about coding 'style', readability, failure prevention, etc.
<gamiee>
zapb_ makes sense. I will change it.
cozycactus has quit [Quit: Connection closed for inactivity]