13:56 <gamiee> hi borneoa__ , I would like to ask, will https://review.openocd.org/c/openocd/+/8527 will be +1 from Thomas be counted for merging, even when it was lost during pushing rebase patchset? Thanks.

16:36 <zapb_> gamiee, just a short review here: would be nice to have the comments about unsupported devices also in the openocd.texi. Also there are some variable assignments that have an unnecessary large scope (see coding style)

19:29 <gamiee> zapb_ : Thanks for feedback! About openocd.texi , so mention chips which might be supported in future (due similar IP core), but are not implemented yet?

19:29 <gamiee> About variable assignments, I will take look on it.

19:36 <gamiee> zapb_ I checked TCL crash coure and stuff, but I am not sure what exact variable assignments you are thinking of? :/

21:26 <zapb_> gamiee, yes, list also unsupported features / devices. Normal users check the docs rather than the source code files

21:26 <zapb_> gamiee, for example, https://review.openocd.org/c/openocd/+/8527/12/src/flash/nor/bl602.c#570 - here 'return_value' should be declared inside the while-loop since it is only used inside