mmind00 changed the topic of #linux-rockchip to: Rockchip development discussion | public log at https://libera.irclog.whitequark.org/linux-rockchip
<tlwoerner> a couple months back, someone here was going to take a look at adding cpu therm support for the rk3308. did that get off the ground?
anarsoul has quit [Ping timeout: 252 seconds]
kevery has quit [Ping timeout: 276 seconds]
kevery1 has joined #linux-rockchip
kevery1 is now known as kevery
kevery1 has joined #linux-rockchip
kevery has quit [Read error: Connection reset by peer]
kevery1 is now known as kevery
ungeskriptet has quit [Ping timeout: 248 seconds]
ungeskriptet has joined #linux-rockchip
alpernebbi has quit [Ping timeout: 260 seconds]
anarsoul has joined #linux-rockchip
gnuiyl has joined #linux-rockchip
anarsoul has quit [Read error: Connection reset by peer]
anarsoul has joined #linux-rockchip
gnuiyl has quit [Remote host closed the connection]
gnuiyl has joined #linux-rockchip
naoki has quit [Ping timeout: 276 seconds]
anarsoul has quit [Ping timeout: 252 seconds]
alpernebbi has joined #linux-rockchip
stikonas has quit [Quit: Konversation terminated!]
anarsoul has joined #linux-rockchip
naoki has joined #linux-rockchip
naoki has quit [Client Quit]
naoki has joined #linux-rockchip
psydroid2 has quit [Ping timeout: 248 seconds]
psydroid2 has joined #linux-rockchip
hexdump0815 has quit [Ping timeout: 265 seconds]
hexdump0815 has joined #linux-rockchip
MyNetAz has quit [Remote host closed the connection]
MyNetAz has joined #linux-rockchip
naoki has quit [Ping timeout: 260 seconds]
System_Error has quit [Remote host closed the connection]
System_Error has joined #linux-rockchip
naoki has joined #linux-rockchip
kevery1 has joined #linux-rockchip
kevery has quit [Ping timeout: 252 seconds]
kevery1 is now known as kevery
naoki has quit [Ping timeout: 268 seconds]
naoki has joined #linux-rockchip
naoki has quit [Ping timeout: 252 seconds]
franoosh has joined #linux-rockchip
naoki has joined #linux-rockchip
anarsoul|2 has joined #linux-rockchip
anarsoul has quit [Ping timeout: 268 seconds]
anarsoul has joined #linux-rockchip
anarsoul|2 has quit [Ping timeout: 265 seconds]
ldevulder has joined #linux-rockchip
kevery1 has joined #linux-rockchip
kevery has quit [Ping timeout: 252 seconds]
kevery1 is now known as kevery
franoosh has quit [Remote host closed the connection]
franoosh has joined #linux-rockchip
paulk has quit [Ping timeout: 248 seconds]
kevery has quit [Ping timeout: 252 seconds]
kevery has joined #linux-rockchip
anarsoul|2 has joined #linux-rockchip
anarsoul has quit [Ping timeout: 272 seconds]
raster has joined #linux-rockchip
<Kwiboo> tlwoerner: I only have a local branch or worktree with some code copied from vendor kernel I used for testing thermal on rk3308, I can push to a branch later, someone else can hopefully upstream proper code :-)
raster has quit [Quit: Gettin' stinky!]
lvrp16 has quit [Ping timeout: 252 seconds]
lvrp16 has joined #linux-rockchip
paulk has joined #linux-rockchip
paulk has joined #linux-rockchip
kevery1 has joined #linux-rockchip
kevery has quit [Ping timeout: 246 seconds]
kevery1 is now known as kevery
hexdump0815 has quit [Ping timeout: 268 seconds]
raster has joined #linux-rockchip
<Kwiboo> tlwoerner: something like https://github.com/Kwiboo/linux-rockchip/commits/rk3308-tsadc/ is what I used last time to help read out soc/cpu temp
hexdump0815 has joined #linux-rockchip
hexdump0815 has quit [Ping timeout: 252 seconds]
ungeskriptet has quit [Ping timeout: 265 seconds]
ungeskriptet_ has joined #linux-rockchip
ungeskriptet_ is now known as ungeskriptet
hexdump0815 has joined #linux-rockchip
MyNetAz has quit [Remote host closed the connection]
MyNetAz has joined #linux-rockchip
chewitt has joined #linux-rockchip
valpackett has quit [Ping timeout: 244 seconds]
paulk has quit [Ping timeout: 248 seconds]
raster has quit [Quit: Gettin' stinky!]
paulk has joined #linux-rockchip
raster has joined #linux-rockchip
<tlwoerner> Kwiboo: thanks!
<tlwoerner> i just wanted to check that the modification to drivers/thermal/rockchip_thermal.c doesn't have a copy+paste bug?
<tlwoerner> .id = rk3328_code_table ?
<tlwoerner> looking through that file, i see a similar issue with the rk3366_tsadc_data stanza around line 1186
<qschulz> tlwoerner: check against the real one in the TRM
<qschulz> 26.5.3 Temperature-to-code mapping
<qschulz> if they are identical, it is good practice to reuse one that already exists so we don't have duplication
ungeskriptet_ has joined #linux-rockchip
ungeskriptet has quit [Ping timeout: 268 seconds]
ungeskriptet_ is now known as ungeskriptet
MyNetAz has quit [Remote host closed the connection]
ungeskriptet has quit [Remote host closed the connection]
ungeskriptet has joined #linux-rockchip
MyNetAz has joined #linux-rockchip
<tlwoerner> qschulz: ah nice!
<tlwoerner> there is one entry that is off, but otherwise the same
<tlwoerner> actually not off, but missing. there is no entry in the rk3328_code_table for -25
<qschulz> tlwoerner: which seems to exist on RK3328 as well
<qschulz> 9.5.2 Temperature-to-code mapping
<tlwoerner> strange. all the other tables have an entry for -25 (and don't seem to be missing any multiple-of-5 entries)
<tlwoerner> i wonder what the first entry in each table does. seems to be something that isn't in the table
<tlwoerner> the first and last entries are different than the rest
<tlwoerner> qschulz: okay thanks for clarifying, good to know
robmur01 has quit [Remote host closed the connection]
<qschulz> tlwoerner: don't know if it's on purpose that -25 is omitted
<qschulz> tlwoerner: it seems like there's a linear extrapolation to figure out the approximate value
<qschulz> so you have 0 as lower value even if it's not in the table, and max value above highest value in table
<tlwoerner> yes, the TRMs say to interpolate linearly between values, so i assume that's what the kernel is doing
<qschulz> but with the same value, so that it simplifies the checks we do
<qschulz> and we don't have to check whether we are below the min or above the max value in the table
<qschulz> you just extrapolate
* qschulz shrugs
<qschulz> I think it's worth sending a patch for the -25 :)
* tlwoerner grumbles.... friggin' upstream-status tag
<dsimic> qschulz: (re: the base DTB doesn't get rebuilt twice, it gets the -@ flag) yes, that's what actually happens
<dsimic> I'll respond in both the v4 and v5 a bit later
<dsimic> Kwiboo: I tryly wonder how do you manage to both have a completely opposite day job and contribute so much to U-Boot and DT stuff
<dsimic> ah, I see qschulz was already baffled with it... me too
<tlwoerner> qschulz: ok, i can send a patch (woo!)
<qschulz> dsimic: :( what is there to answer to v5
<dsimic> regarding days at the dayjob being exciting or not... there's huge difference between something being exciting and having something you _need_ to do as your job description, daily tasks, etc.
<dsimic> tlwoerner: (re: adding cpu therm support for the rk3308) it was me, and I'm still committed to it, but I'm primarily waiting for sample board(s)
<dsimic> I can't afford buying them myself, so I asked Radxa, but that didn't go extremely well... we'll see, though
<tlwoerner> dsimic: okay. just wanted to make sure i didn't miss it
<dsimic> qschulz: I haven't gone thrugh the v5 yet, actually
<dsimic> and I need to test a few things
<dsimic> tlwoerner: did I get it right that you'll handle the RK3308 thermal stuff?
<dsimic> s/thrugh/through/
<tlwoerner> dsimic: i'm testing the patch Kwiboo pointed to
<dsimic> ah, I see... so, I'll keep asking Radxa about the sample boards
<dsimic> just pinger Radxa, so we'll see
<dsimic> s/pinger/pinged/
eballetbo has quit [Quit: Connection closed for inactivity]
robmur01 has joined #linux-rockchip
<tlwoerner> Kwiboo: your rk3308 therm patch works for me on the rock-pi-s
naoki has quit [Quit: naoki]
<tlwoerner> i've got 7/13 devices around the farm that are rock-pi-s, it'd be nice to collect/record SoC therm data for these too :-)
franoosh has quit [Ping timeout: 252 seconds]
<tlwoerner> Kwiboo: is there any reason you can't send it upstream? what does it need to be "proper code"?
vagrantc has joined #linux-rockchip
raster has quit [Quit: Gettin' stinky!]
urja has quit [Read error: Connection reset by peer]
linkmauve has joined #linux-rockchip
raster has joined #linux-rockchip
linkmauve has left #linux-rockchip [#linux-rockchip]
linkmauve has joined #linux-rockchip
paulk has quit [Read error: Connection reset by peer]
paulk has joined #linux-rockchip
mripard has quit [Quit: WeeChat 4.5.1]
urja has joined #linux-rockchip
<dsimic> tlwoerner: regarding your patch, I'm also not sure that non-ASCII characters should be part of patches
<dsimic> also, having "[1]" with no actual numbered references doesn't make much sense :)
<tlwoerner> haha, oops. thanks
<dsimic> regarding non-ASCII, it should be "oC", "degrees C" or something like that instead of "°C", and "chapter" instead of the "§" character -- unless those are actually ASCII characters that I'm unaware of :)
<dsimic> there's been a lengthy deiscussion about "oC" already
<jakllsch> neither ° or § is ACSII
<dsimic> thanks, then I'm afraid we shouldn't use them
<jakllsch> ° is ISO-8859-1
<jakllsch> as is §
<maz> "7 bits should be enough for everybody."
<dsimic> just as 384 KB or whatever :)
<jakllsch> 640Ki
<dsimic> actually, "Ki" is the same as "K", because "K" is non-standard already :)
<jakllsch> eh, K is kinda ambiguious
<jakllsch> i'd sooner be precise
<dsimic> tlwoerner: regarding what's preventing Kwiboo's borrowed-from-downstream code from being acceptable upstream, that's hard to tell without going into minute details, which usually takes a lot of time
<dsimic> jakllsch: I agree, using just "K" is a bit unclear, but it's technically equal to "Ki"
<jakllsch> unless it means Kelvin :-P
<dsimic> surely not when used as a unit prefix :)
<dsimic> that's why I always use "KB", for example
dsimic has quit [Ping timeout: 245 seconds]
dsimic has joined #linux-rockchip
System_Error has quit [Remote host closed the connection]
chewitt has quit [Quit: Zzz..]
stikonas has joined #linux-rockchip
raster has quit [Quit: Gettin' stinky!]
MyNetAz has quit [Remote host closed the connection]
MyNetAz has joined #linux-rockchip
MyNetAz has quit [Remote host closed the connection]
helene has quit [Ping timeout: 252 seconds]
naoki has joined #linux-rockchip
MyNetAz has joined #linux-rockchip
helene has joined #linux-rockchip
a3f has quit [Remote host closed the connection]
a3f has joined #linux-rockchip
System_Error has joined #linux-rockchip
<Kwiboo> dsimic: hehe, some assignments for my dayjob involve very little or no coding, so hobby linux/u-boot coding help fill such void ;-)
<Kwiboo> tlwoerner: yep, the code for rk3308 thermal should be in decent shape and seemed to work okay, for upstream it will need i.e. dt-bindings, code and dt should be validated against trm and part of the code was possible c/p so could need proper attribution -> lots of work I have no desire to take on :-)
<dsimic> Kwiboo: I see, but you must be having a lot of "unassigned time" at your dayjob :)
stikonas has quit [Quit: Konversation terminated!]
stikonas has joined #linux-rockchip
stikonas has quit [Read error: Connection reset by peer]
<Kwiboo> dsimic: it depends, but yes there can be periods that require very little effort and other periods that will require much more of my attention, a good balance for me :)
stikonas_ has joined #linux-rockchip
<dsimic> Kwiboo: I'm happy to hear it's working out for you :)
<dsimic> tlwoerner: Kwiboo: just to reiterate, I remember firmly committed to doing the RK3308 thermal stuff, which includes a lot of "paperwork" that Kwiboo summed up well, and I hope Radxa wil eventually send me the boards I need, both for that and for my SoC binning endeavor
<dsimic> s/wil/will/
stikonas has joined #linux-rockchip
stikonas_ has quit [Quit: Konversation terminated!]
<Kwiboo> dsimic: great!, I hope they will send you some boards soon :)
<dsimic> hopefully :)
<dsimic> I've got more than enough boards with some SoCs, but I have e.g. zero RK3568-based boards
<dsimic> while I obviously need to have at least a few boards with the same SoC for the binning project
<dsimic> to be able to e.g. test on a couple of boards and have the third one running some long-term-ish stability tests
<dsimic> oops... s/I remember/I stay/
<dsimic> what a typo :)
<dsimic> actually, s/I remember/I remain/
stikonas has quit [Quit: Konversation terminated!]
stikonas has joined #linux-rockchip
naoki has quit [Quit: naoki]
naoki1 has joined #linux-rockchip
naoki1 is now known as naoki
System_Error has quit [Remote host closed the connection]
System_Error has joined #linux-rockchip
MyNetAz has quit [Remote host closed the connection]
MyNetAz has joined #linux-rockchip
System_Error has quit [Remote host closed the connection]