08:37 <naoki> hmm...about u-boot, USB3 on ROCK 5B is not working on my v2023.07-based branch. I'm missing something...

08:40 <naoki> SPI-NOR is working on 5A https://github.com/RadxaNaoki/u-boot/commit/6e4637cd7a2b2620f4deff852c4c654adbe28dbb

08:42 <naoki> Kwiboo: I saw your mail. thank you for your hard work! :)

09:10 <Kwiboo> naoki: Thanks!, I got my ROCK 5A delivered today so will play with it later :-)

09:13 <Kwiboo> for USB on 2023.07 you may have to pick the regulator basic reference counter patches from master: https://github.com/Kwiboo/u-boot-rockchip/compare/v2023.07.02...9598f9001013e25bbc6b253cbbbb68c86f4ab7af

10:02 <naoki> thanks for the pointer!

10:52 <naoki> oh I forgot to check how emmc works with sfc enabled binary

10:53 <naoki> they share pins

11:30 <naoki> oh...? -spi.bin boots from SPI, but SPL doesn't load u-boot from SPI...

11:35 <Kwiboo> correct, U-Boot proper is loaded from "same-as-spl", i.e. same media that TPL+SPL was started from as first option, I did not add any fallback node for spi, if you cannot boot from TPL in spi, you probably have some issue and should not try to load U-Boot proper from spi

11:38 <Kwiboo> or do you have a case there you boot TPL+SPL from SPI but U-Boot proper is not loaded from SPI even with "same-as-spl" as first boot order option?

11:41 <naoki> TPL+SPL is booted from spi, I can see ddr thing and SPL output

11:41 <naoki> U-Boot SPL 2023.07.02-00058-g6e4637cd7a (Aug 01 2023 - 19:56:22 +0900)

11:41 <naoki> then

11:41 <naoki> Trying to boot from SPI

11:41 <naoki> then

11:42 <naoki> Trying to boot from MMC2

11:42 <naoki> there is no output between SPI and MMC2

11:46 <naoki> I think CONFIG_SPL_* are enough... my source tree may have a problem, I'll check what happen on 5B

12:06 <naoki> boot from SPI is working on 5B. both TPL+SPL and u-boot(FIT) are loaded from SPI

12:10 <Kwiboo> maybe https://source.denx.de/u-boot/u-boot/-/blob/master/arch/arm/mach-rockchip/rk3588/rk3588.c#L40-45 needs to be updated for 5A/rk3588s

12:12 <Kwiboo> also with CONFIG_SF_DEFAULT_BUS=5 you have to have patched that sets spi5 = &sfc alias, is included in master branch as of yesterday

12:15 <naoki> rk3588s-u-boot.dtsi:spi5 = &sfc;

12:15 <naoki> CONFIG_SF_DEFAULT_BUS=5

12:17 <naoki> hmm...

12:19 <Kwiboo> maybe bootrom is writing another boot BROM_BOOTSOURCE for spi on rk3588s

12:19 <Kwiboo> or sfc flash node is not named /spi@fe2b0000/flash@0

12:22 <naoki> SPL says "Trying to boot from SPI", so I guess BROM_BOOTSOURCE is correct

12:22 <Kwiboo> ahh, so it finds it, maybe you have sdhci node still endabled?, I think pinctrl from sdhci will be applied and overwrite fspi pinconf

12:24 <Kwiboo> there is no logic that will re-configure the pins, u-boot is lazy loading, so as soon as the sdhci node is probed its pinctrl will be appied

12:25 <Kwiboo> at least try with the sdhci node disabled and see if that makes it work

12:25 <naoki> I see

12:33 <naoki> Kwiboo: you are right. adding status = "disabled"; make load from SPI works

12:34 <naoki> but...

12:34 <naoki> I want sdhci enabled for u-boot-rockchip.bin, disabled for u-boot-rockchip-spi.bin...

12:36 <naoki> where is pinctrl applied...

12:55 <Kwiboo> it is done by driver core, one possible way could be to have some code that disables emmc if device was booted from spi flash, not sure how that could be done

12:57 <Kwiboo> or without code, create special spi device config that only enable spi node instead of emmc node

13:10 <naoki> btw

13:10 <naoki> boot from emmc works fine with spi enabled u-boot-rockchip.bin

13:20 <naoki> okay, I understand it's difficult for me ;)

13:49 <naoki> hmm... I got

13:49 <naoki> Bus usb@fc400000: probe failed, error -22

13:49 <naoki> during "usb start"