04:14 <naoki> Kwiboo: how do you think this...

04:14 <naoki> https://github.com/RadxaNaoki/u-boot/commit/1d4649442145cecfb7b41eed3f811979a9b17fb5

04:14 <naoki> https://drive.google.com/file/d/1ovZzxKsm8JcJPDVROWfs89z1lSRJ4wdp/view

04:14 <naoki> I guess no one want it...

05:36 <naoki> Kwiboo: I'm trying to add E key to SATA board on ROCK 5A. I got "can't get the phy from DT" after "scsi scan"

05:37 <naoki> ah, for u-boot

05:38 <naoki> in rk3568.dtsi, phy-names = "sata-phy"; is in sata0: sata@fc000000 {}

05:39 <naoki> in rk3588s.dtsi, it's in sata0: sata@fe210000 { sata-port@0 {}; };

06:09 <naoki> adding phys/phy-names properties into sata0 {}...

06:09 <naoki> now E key to SATA is working with dirty hack...

06:10 <naoki> on ROCK 5A

06:56 <naoki> E key to SATA is working on ROCK 5B now...

06:57 <naoki> here is my brain-dead patches... https://github.com/RadxaNaoki/u-boot/commits/rock-stable

07:15 <Kwiboo> naoki: great, guess similar issue with SATA as with SPI, you can only have one of SATA or PCIe enabled on the M.2 slot

07:16 <naoki> yes, SATA or PCIE...

07:17 <naoki> for linux kernel, fdt overlay can be used. but, for u-boot...

07:18 <Kwiboo> btw, I was able to test pcie on 5A and nvme on 5B using device tree from top of sre rk3588 branch, see https://github.com/Kwiboo/u-boot-rockchip/commits/rk35xx-pcie-bifurcation-v1

07:19 <Kwiboo> having trouble sending out patches to u-boot mailing list for the pcie bifurcation support part, will have to re-send it again later

07:20 <Kwiboo> yeah, some kind of dt overlay for u-boot proper would be nice

17:14 <sre> I guess ideally U-Boot could try to probe SATA and then either keep SATA or switch to PCIe based on device detection.

18:37 <Kwiboo> sre: yeah, that would be ideal, some auto detect feature

18:39 <Kwiboo> sre: In your "RK3588 PCIe3 support" series you mentioned that pcie phy driver is missing bifurcation feature, yet there is some bifurcation configuration going on based on the data-lanes property

18:41 <Kwiboo> I have a U-Boot series that adds rk3588 pcie3 phy support based on the linux driver, do you think that the data-lanes handling is something that will need to change?

18:43 <Kwiboo> can only test the aggregated x4 mode on my rock 5b, guess code can always be updated/fixed once there is devices that use bifurcation :-)

22:32 <sre> Kwiboo: I guess I should have looked a bit more detailed. I only quickly skipped over it and noticed pcie30_phymode is unused. Looks like it is indeed supported and pcie30_phymode is just a leftover.

22:45 <Kwiboo> great, then I was not missing something, u-boot patches was sent earlier to bring pcie3 phy driver in sync with linux :-)