Daanct12 has quit [Remote host closed the connection]
sre has joined #linux-rockchip
Danct12 has joined #linux-rockchip
sre6 has joined #linux-rockchip
warpme has joined #linux-rockchip
<warpme>
guys: i don't know full mechanics between dw-hdmi-phy and vop in rk - so i need some help. Im hacking with 3528 & i backported 3528 dw-hdmi support to mainline (6.4). Issue i have is wrong video modes i'm getting in mainline: forcing 1920x1080@60 gives on my tv some errors like 240p 768Hz. I compared relevant clocks in clocks_summary between: box android and my mainline code. They are the same. I done test with: bsp
<warpme>
phy-rockchip-inno-hdmi-phy.c transplanted to mainline and results are the same. All looks to me that issue is not in my backported dw-hdmi code - but rather in my backport vop2 code which wrongly drives dw-hdmi. Is it possible that wrong vop2 code drives dw-hdmi driver to video mode with errant timings?
<robmur01>
if the clock tree isn't quite right in the clock driver, and changing a VOP clock affects some parent clock shared with HDMI behind its back, then yes.
<robmur01>
not to mention that IIRC inno-hdmi-phy's own internal clock code isn't super-robust to begin with, so there's probably plenty of room for that to go wrong by itself
crabbedhaloablut has quit []
<robmur01>
(although my experience on 3328 is more of it refusing to play at all, giving no output and vblank timeout errors from the VOP)
sre6 has quit [Ping timeout: 260 seconds]
<warpme>
robmur01 : i done following test: connect tv, boot android and mainline 6.4. In both cases videomode was the same. Then I compared relevant clocks and both: android and mainline has the same relevant clocks (i mean clocks defined in hdmi, phyhdmi and vop)
<warpme>
are vop clocks dependent on videomodes?
<robmur01>
possibly, not sure (especially not when it comes to VOP2)
<robmur01>
and when you say "compare clocks", do you mean by dumping the raw CRU registers, or just the debugfs view of what the clock driver *thinks* they *should* be? ;)
<warpme>
robmur01 : unfortunately 2nd case (debugfs). clk driver i'm using is also backport from bsp. It gives me working cpu dvfs, sd, eth, usb - so i'm optimistically assuming hdmi/vop2 also should get correct clocks (visual comparison of android an mainjline clk_summary gives almost 100% on par)
<robmur01>
remember when we had a similar thing with CEC? I just don't trust clock drivers by default now :D
<Kwiboo>
warpme: bsp kernel have a vop3 variant that is used for rk3528, did you port that also?
<warpme>
Kwiboo : i added very initial & minimal vop3 support - basically just to get dw-hdmi driver loading as without vop dw-hdmi not loads/operates at all. My idea was to: get dw-hdmi semi-working then work on vop3 then polish dw-hdmi then "polish" (if my limited skills will allow) vop3.
<warpme>
i wouldn't say my vop3 support is even minimally now - but i was thinking (& this looks like false assumption now): no correctly working vop3 should not impact low level dw-hdmi mode setting. I was thinking: if dw-hdmi code is ok - then video mode setting at crtc level should work - despite vop3 is not working yet....
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
sukrutb has joined #linux-rockchip
a1batross has joined #linux-rockchip
psydroid has quit [Remote host closed the connection]