15:31 <CounterPillow> macromorgan: got news from rockchip about RK356x TF-A, they're planning on doing something about it this month

15:33 <macromorgan> sweet

15:34 <macromorgan> anyone else working on the DSI controller that you know of? I'm still seeing weirdness on my first device (with a conventional panel) and am working on the 2nd device now (with a DBI panel). Be nice to get some confirmation that what I've done is right/wrong/moot.

15:38 <CounterPillow> not that I know of currently. pgwipeout is currently not at home for a while so he's out of the picture, I'm busy-ish and don't have any DSI hardware and no knowledge of it

18:48 <LinuxHackerman> Hi folks. I'd quite like to have redshift/gammastep working on my rk3399 chromebook. As far as I understand, that's something that the hardware supports but isn't implemented by the rockchipdrm driver.

18:49 <LinuxHackerman> ("that's" = "gamma control")

18:50 <LinuxHackerman> Is that understanding correct, and would it be a good "my-first-driver-code" thing to do? I'd say I have a solid understanding of C, and a rough understanding of how hardware works, and found a bit in the rk3399 TRM that looks like the thing I want.

18:55 <CounterPillow> I faintly remember this being a thing, yeah. Not sure how feasible this is for a first driver contribution but it's great you're interested in it

18:57 <CounterPillow> I don't know anything specific about the gamma stuff, but it's likely you may find something in a different DRM driver that roughly shows how it's implemented.

18:58 <LinuxHackerman> huh, I might be misremembering or I'm getting the wrong versions/parts of TRM... I can't find any mentions of gamma

19:02 <CounterPillow> lemme check my TRMs

19:03 <LinuxHackerman> huh, actually looking at rockchip_drm_vop.c it should be implemented after all?

19:03 <CounterPillow> it's in Part 3 of the TRM

19:04 <CounterPillow> ah yeah, was implemented in october

19:04 <LinuxHackerman> well then, so much for that!

19:05 <LinuxHackerman> thanks Ezequiel Garcia!

19:06 <CounterPillow> Hmmm actually

19:06 <CounterPillow> the thing I'm looking at is from sigmaris

19:06 <CounterPillow> it doesn't seem to have been merged

19:06 <LinuxHackerman> Hm, leaving the question of why gammastep complains that the output doesn't support gamma adjustment

19:07 <CounterPillow> it's possible it doesn't

19:07 <CounterPillow> lemme grab the patchset I'm looking at from patchwork

19:07 <LinuxHackerman> and where can I find part 3?

19:08 <CounterPillow> https://patchwork.kernel.org/project/linux-rockchip/list/?series=566619&archive=true

19:11 <CounterPillow> try applying this patch series (click on series on one of the patches, then git am -3 the file)

19:11 <LinuxHackerman> yeah that looks pretty distinct from the gamma stuff that Ezequiel Garcia introduced in 2019. I forgot that rockchipdrm isn't just for rk3399 :)

19:11 <LinuxHackerman> thanks!

19:24 <LinuxHackerman> (and now to wait for the build... now taking bets on what will go faster, syncing the source tree over to the chromebook's SD card so I can get a localmodconfig, or building a fat kernel on my honeycomb...)

20:08 <mps> LinuxHackerman: please report here if you got it working, I would like to test it

20:08 <LinuxHackerman> will do :)

20:09 <mps> though I don't use much this machine nowadays will be nice if it works

21:04 <LinuxHackerman> mps: it does work!

21:04 <LinuxHackerman> CounterPillow: thanks very much for helping me find the patch series!

21:05 <LinuxHackerman> would it be helpful at all for me to inform the list that the patch works for me?

21:06 <LinuxHackerman> (and thanks very much sigmaris for implementing it!)

21:07 <mps> LinuxHackerman: thank for info

21:08 <mps> LinuxHackerman: so it is these patches https://patchwork.kernel.org/project/linux-rockchip/list/?series=566619&archive=true

21:09 <mps> LinuxHackerman: and how do you set gamma, with xgamma?

21:09 <LinuxHackerman> I used gammastep (on sway)

21:09 <LinuxHackerman> and yes those patches

21:10 <mps> aha, I use only xorg, will try with xgamma or x/sct

21:10 <LinuxHackerman> yeah, I'd guess that those will work too

21:11 <mps> nice. will try tomorrow. it is late here and I'm preparing for bed

21:12 <LinuxHackerman> same

21:12 <LinuxHackerman> it's great to finally not get blinded by the display at night anymore!

21:13 <mps> yes, it is irritating at least

21:35 <CounterPillow> LinuxHackerman: would be great if you informed the list, yeah