<ahorek[m]> lopex: thanks! I looked at https://github.com/jruby/jcodings/pull/55 again and the original CRuby code seems to be wrong. This table access invalid, but it won't fail on C, see https://godbolt.org/z/KasqY7e4b
<headius> Nice find!
<lopex[m]> yeah, lots of such cases in joni too
<lopex[m]> I mean, oniguruma
subbu has joined #jruby
<headius> goo dmorning!
subbu has quit [Quit: Leaving]
subbu has joined #jruby
subbu has quit [Ping timeout: 240 seconds]
subbu has joined #jruby
<headius> these logger errors are weird
<headius> it seems to still copy an old 1.3.0 logger.rb even though it is supposed to be pulling the 1.5.1 gem
subbu has quit [Quit: Leaving]
<headius> hmm well I pushed a .gitignore for the additional logger files but not sure why it is sometimes pulling down 1.3.0 instead of 1.5.1
<headius> when I did several cleans and rebuilds here I got it to be 1.5.1 and then the tests pass
<headius> ok the two specs that fail only fail because it is checking Ruby version and not logger version
<headius> so it is expecting output from an earlier logger than we ship
<headius> (after incorporating that fix for Windows)
<headius> not sure about the mri stdlib failures yet
<byteit101[m]> looking at the comments from last night, what's the difference between realClass.getClassRuntime() and realClass.getRuntime() ?
<headius> getRuntime goes metaClass.getClassRuntime
<byteit101[m]> Popped that change to the ivar (fixed) PR
<byteit101[m]> let me know if there is anything else that needs be be changed after further review