<mattip> antocuni: about HPy_GLobal_Store/Load: if I understand correctly we need to keep alive the global index of the handle and any app-level objects it might wrap
<mattip> do we need to set aside a range of indices that will be used specifically for global handles in the handle manager?
<mattip> is it correct that the logic must manage the lifetime of the wrapped objects separately from the logic in handlemanager?
<antocuni> mattip: yes, that's correct. Also, I think that the idea is that they are automatically per-thread, but better to ask fangerer and steve_s to double check
<antocuni> but I think that for now it's perfectly fine to store them as a field in the State (and think about threading later) is we are not sure
<fangerer> We can leave it at that for now. We were just discussing that the design of HPyGlobal also allows to be used with subinterpreters.
<fangerer> antocuni: since you are obviously online 🙂 : if you find the time, please do a first review round for https://github.com/hpyproject/hpy/pull/364
<antocuni> ahah you caught me 😂
<antocuni> yes, it was on my TODO list for today
<antocuni> in Germany it's a holiday but I'm happy to dedicate some time to HPy today
<fangerer> 🤣
<fangerer> sorry; I didn't know that there is a public holiday in Germany today
<antocuni> no problem, really
<fangerer> antocuni: thanks for reviewing; will address your comments ASAP.
<fangerer> Since you are already in HPy: here is another tiny but I think useful PR. Should be very quick to review: https://github.com/hpyproject/hpy/pull/365
<antocuni> done :)
<fangerer> thank you
steve_s has joined #hpy
<steve_s> > I think that the idea is that they are automatically per-thread
<steve_s> If that is meant per Python thread, then no that wasn't my intention. My intention was per (sub)interpreter.
<mattip> ahh, there is quite a bit of design philosophy in the documentation of the global store, I should have read that before :)
<mattip> I added a global store to the thread-local ExecutionContext in PyPy in 73d93f41263b, it seems to work as advertised
<mattip> is the fact that it is thread-local going to cause incompatibilities?
<mattip> I also added some GIL handleing in later commits
<mattip> The tests pass, but something is off after translation when the JIT kicks in
<mattip> and the tests hit HPy_LeavePythonExecution
<mattip> s/The tests/Untranslated tests/
steve_s has quit [Ping timeout: 252 seconds]