dalley has quit [Ping timeout: 255 seconds]
dalley has joined #hpy
<fangerer> Good morning! We will have our dev call in about 45 minutes. https://oracle.zoom.us/j/339127822?pwd=YkNZbFgvdXZ4Z3NlcWg1N3BlZ3JTUT09
<Hodgestar> Joining shortly.
<mattip> it would be nice to merge the changes on the graal-team/numpy-hpy-port back to hpy so we can be sure to make this part of an upcoming release
<mattip> should I make an issue and add it to the milestone?
<mattip> I guess we can repurpose issue #137, which is a tracking issue for numpy port
<Hodgestar> Maybe "being able to build the numpy branch of the current HPy" is a reasonable goal for a release?
<fangerer> mattip: Hodgestar: Agreed. I'm basically working on that. "Upstreaming" the changes we made in branch https://github.com/hpyproject/hpy/tree/graal-team/numpy-hpy-port to master.
<fangerer> The reason why it takes some time is that the changes in the branch are not, let's say, _production ready_.
arigato has quit [*.net *.split]
m_qunaibit has quit [*.net *.split]
Alex_Gaynor has left #hpy [#hpy]
arigato has joined #hpy
m_qunaibit has joined #hpy
LarstiQ has quit [Ping timeout: 260 seconds]
LarstiQ has joined #hpy
<fangerer> antocuni: Hodgestar: I could use your help for https://github.com/hpyproject/hpy/pull/339 . The proof-of-concept test is failing (see log https://github.com/hpyproject/hpy/actions/runs/3387508525/jobs/5628340029 ). But I don't understand why.
<fangerer> Pytest cannot import `pofpackage.foo` but if I manually activate the created venv and do the import, it works.
<fangerer> Do you have an idea?
<antocuni> does it fail also locally?
<mattip> maybe it is a sys.path issue. Can you print the sys.path just before the import, and compare to your local build
<fangerer> it also fails locally
<fangerer> the difference I observed (compared to `master`) is that the `hpy_pof` egg is now zipped; previously it was unpacked (not sure why)
<fangerer> we already missed to specify `packages=["pofpackage"]` in `setup.py` (I think that's necessary, right?) but that didn't fix it
<fangerer> I'll have a look at `sys.path`
<fangerer> `sys.path` is exactly the same
<mattip> weird
<mattip> and the package is in a directory on sys.path?
<fangerer> the path looks like this:
<fangerer> ```
<fangerer> ...
<fangerer> ['$TMPDIR/hpy/proof-of-concept',
<fangerer> '$TMPDIR/hpy/venv/setup_py_install_universal/lib/python3.10/site-packages',
<fangerer> '$TMPDIR/hpy/venv/setup_py_install_universal/lib/python3.10/site-packages/hpy_pof-0.0.0-py3.10-macosx-12-x86_64.egg']
<fangerer> ```
<fangerer> the difference is:
<fangerer> ```
<fangerer> > file venv/setup_py_install_universal/lib/python3.10/site-packages/hpy_pof-0.0.0-py3.10-macosx-12-x86_64.egg/
<fangerer> venv/setup_py_install_universal/lib/python3.10/site-packages/hpy_pof-0.0.0-py3.10-macosx-12-x86_64.egg/: directory
<fangerer> working case:
<fangerer> ```
<fangerer> broken case:
<fangerer> ```
<fangerer> venv/setup_py_install_universal/lib/python3.10/site-packages/hpy_pof-0.0.0-py3.10-macosx-12-x86_64.egg: Zip archive data, at least v2.0 to extract, compression method=deflate
<fangerer> > file venv/setup_py_install_universal/lib/python3.10/site-packages/hpy_pof-0.0.0-py3.10-macosx-12-x86_64.egg
<fangerer> ```
<fangerer> also, in the working case, verbose output prints: `import 'pofpackage' # <_frozen_importlib_external._NamespaceLoader object at 0x111624fa0>`
<fangerer> and in the broken case: `import 'pofpackage' # <_frozen_importlib_external.SourceFileLoader object at 0x110816050>`
<fangerer> Okay, I think I have a reasonable solution: specifying `zip_safe=False` in `proof-of-concept/setup.py`.
<fangerer> Seemingly, Python 3.11 was deployed and now tests autogen, cppcheck, and infer are failing. I fixed the autogen problem but I'm not sure how to do it for cppcheck and infer. So, I'm going back to 3.10 for those.
<antocuni> also, FWIW, the tests in test_pof are not very good/well designed. They started as "let's check that pof works" but they evolved in "let's check that setuptools works"
<antocuni> nowadays we have test_distutils which is much better and allows more fine grained tests
<antocuni> ideally, I would like to move all various test cases from test_pof to test_distutils
dalley has quit [Ping timeout: 255 seconds]
dalley has joined #hpy