michaelni changed the topic of #ffmpeg-devel to: Welcome to the FFmpeg development channel | Questions about using FFmpeg or developing with libav* libs should be asked in #ffmpeg | This channel is publicly logged | FFmpeg 7.1 has been released! | Please read ffmpeg.org/developer.html#Code-of-conduct
uau_ has joined #ffmpeg-devel
uau has quit [Ping timeout: 244 seconds]
uau_ is now known as uau
ccawley2011 has quit [Read error: Connection reset by peer]
abdu53 has quit [Quit: Client closed]
<fflogger>
[newticket] bradisbell: Ticket #11434 ([undetermined] Unable to set channel count for Alsa input since release 5.1.1) created https://trac.ffmpeg.org/ticket/11434
<BtbN>
jamrial: this seems to be fallout of the new channel layout API
<jamrial>
oh, i know what happened with the diffs above. it ate the lone blank space in empty lines
AntiLeader has joined #ffmpeg-devel
<AntiLeader>
Taylorator SDR - when I thought there is nothing left to invent
System_Error has quit [Remote host closed the connection]
System_Error has joined #ffmpeg-devel
abdu21 has joined #ffmpeg-devel
abdu69 has quit [Ping timeout: 240 seconds]
xvaclav has quit [Quit: Ping timeout (120 seconds)]
xvaclav has joined #ffmpeg-devel
ngaullier has quit [Remote host closed the connection]
<AntiLeader>
jamrial: downmix code have strange checks for NULL
<AntiLeader>
as reported by coverity
<jamrial>
in af_aresample?
<AntiLeader>
libavutil/downmix_info
<jamrial>
what coverity issue #?
<BtbN>
it's just a missing NULL check after allocating memory via av_frame_new_side_data
<AntiLeader>
1641638
<jamrial>
BtbN: yeah
<BtbN>
the null check is there, but somehow AFTER accessing
<jamrial>
BtbN: a recent change of mine added the memset
<wbs>
interestingly enough, linking checkasm fails on macOS if using the old linker (-Wl,-ld_classic), since a couple months
cone-687 has joined #ffmpeg-devel
<cone-687>
ffmpeg Martin Storsjö master:3cd4e8470a1e: configure: Improve the check for the rsync --contimeout option
<cone-687>
ffmpeg Martin Storsjö master:8f4819ce0158: rtmpproto: Avoid rare crashes in the fail: codepath in rtmp_open
System_Error has quit [Remote host closed the connection]
System_Error has joined #ffmpeg-devel
ccawley2011 has quit [Ping timeout: 248 seconds]
ccawley2011 has joined #ffmpeg-devel
ccawley2011_ has joined #ffmpeg-devel
abdu39 has joined #ffmpeg-devel
abdu21 has quit [Ping timeout: 240 seconds]
ccawley2011 has quit [Ping timeout: 265 seconds]
<cone-687>
ffmpeg James Almer master:7a16bfa7c92c: tests/checkasm/sw_rgb: increase plane array buffers
<cone-687>
ffmpeg James Almer master:a649b2a83135: avutil/downmix_info: check for side data allocation success before zeroing it
ccawley2011_ has quit [Ping timeout: 252 seconds]
ccawley2011_ has joined #ffmpeg-devel
realies has quit [Quit: ~]
realies has joined #ffmpeg-devel
realies has quit [Client Quit]
Hobbyboy has quit [Ping timeout: 260 seconds]
realies has joined #ffmpeg-devel
fennewald has quit [Ping timeout: 260 seconds]
fennewald has joined #ffmpeg-devel
Hobbyboy has joined #ffmpeg-devel
srikanth has joined #ffmpeg-devel
<srikanth>
Hello! First time patch submitter here. Is there a way to mark my earlier submission as abandoned? I submitted a partial patch and resubmitted it with correct diff.
<BtbN>
if you send a v2 that's obvious
<AntiLeader>
not via mailing-list, may be possible via patchwork
<srikanth>
got it. Will try to create a patchwork account
<AntiLeader>
patchwork is optional
<AntiLeader>
not mandatory to create account there...
<BtbN>
patchwork is pretty much just a way for rudimentary CI and and convenient patch download
<AntiLeader>
iirc on it you can mark old patches are superseeded...
<BtbN>
Yeah, but it does nothing except show a little mark on the patch on patchwork itself
<AntiLeader>
switch to forgejo
<BtbN>
With a community that can't agree on anything?
<AntiLeader>
pick a leader
<srikanth>
I see. I will mark the updated patch as v2. I got some warnings about commit message length. This should make it more visible.
<JEEB>
michaelni: alternatively I feel like since we've had meta demuxers have these issues having demuxers utilized that just read text from input, maybe we should just have some general meta demuxer logic which allows or disallows specific formats. allowlist is simpler since even if someone adds a new one it will not automatically be allowed (thus not enabling possible new "holes"), but on the other hand if
<JEEB>
we can notice such formats as new ones happen to get added then a blocklist based on a "not allowed in meta demuxers" or "may easily cause information exfiltration" per-format flag might also be quite possible
srikanth has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<nevcairiel>
dont we already have tons of whitelists for things, having a demuxer whitelist sounds a lot better then doing it on extension, which is meaningless in msot cases - as seen here, ts is just used for anything
<fflogger>
[newticket] FranceBB: Ticket #11436 ([swscale] Changing stream properties (matrix/primaries/transfer) make FFMpeg crash) created https://trac.ffmpeg.org/ticket/11436
<Traneptora>
BtbN: tbf what they're trying to do is do a no-op scale filter from "unknown" primaries to "bt709" primaries
<Traneptora>
since the file starts with bt709, the output is configured to bt709, and then since the input changes midway through from bt709 to unknown, it inserts a scale filter, which fails
<wbs>
checkasm can't be linked on macOS, with devtools older than 1,5 years; their linker seems to have a _really_ surprising behaviour - it can't pull in objects from a static library, if the referenced symbol is "common" (allocated in .bss), i.e. a fully zero-initialized data block; see https://martin.st/temp/ld64-common-bug.txt
abdu56 has joined #ffmpeg-devel
System_Error has quit [Remote host closed the connection]
abdu17 has quit [Ping timeout: 240 seconds]
System_Error has joined #ffmpeg-devel
mkver has quit [Ping timeout: 260 seconds]
srikanth has joined #ffmpeg-devel
<Traneptora>
wbs: what happens if you use -L. -lcommon instead of libcommon.a directly
srikanth has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
srikanth has joined #ffmpeg-devel
<wbs>
Traneptora: that doesn't make any difference; I believe the reason is that these so called "common" symbols (for zero-initialized data, which isn't carried as actual data in the object file) are a kinda weird sort of symbol
<Traneptora>
why is it zero-initialized? you declared it as int common[100];
<wbs>
yes - that's zero-initialized
<wbs>
stack variables are uninitialized, but global variables without an initializer are zero initialized
<Traneptora>
TIL
<wbs>
(and the point is that the object file doesn't carry actual data with 100 zeroes, and the resulting executable doesn't either; these things get allocated in a section where enough storage is made at runtime only)
srikanth has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
srikanth has joined #ffmpeg-devel
odrling has quit [Remote host closed the connection]
odrling has joined #ffmpeg-devel
Traneptora has quit [Quit: Quit]
Thulinma has quit [Ping timeout: 252 seconds]
<ePirat>
wbs, huh weird that no one else ran into this before?
<ePirat>
seems like not that uncommon to do?
srikanth has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
mkver has joined #ffmpeg-devel
ccawley2011_ has quit [Read error: Connection reset by peer]