michaelni changed the topic of #ffmpeg-devel to: Welcome to the FFmpeg development channel | Questions about using FFmpeg or developing with libav* libs should be asked in #ffmpeg | This channel is publicly logged | FFmpeg 7.1 has been released! | Please read ffmpeg.org/developer.html#Code-of-conduct
rvalue has quit [Ping timeout: 252 seconds]
MyNetAz has quit [Remote host closed the connection]
Traneptora has joined #ffmpeg-devel
<BBB>
wbs: yes, I suppose that would be good. michaelni: are you in charge of backports?
ngaullier has quit [Remote host closed the connection]
<Traneptora>
it's 1 a.m. in Europe rn so he may be asleep
<BtbN>
nobody is directly in charge of backport
<BtbN>
he just picks a ton of fixes every release on an old branch
<BtbN>
If a patch is fix for a bug that does not introduce new features or breaks anything, just push it
<Traneptora>
I was under the impression the usual method is that if you fix bugs without changing (non-bug) behavior then you just backport it as far as it merges
<Traneptora>
i.e. as far as it applies cleanly
<BtbN>
yeah, just cherry-pick away for pure bugfixes
<BBB>
don't have a lot of experience with backports, afaik I've never backported anything
<cone-141>
ffmpeg Leo Izen master:f3c408264554: avcodec/libjxl: add animated JPEG XL encoder
<cone-141>
ffmpeg Leo Izen master:07e54f9b5c1c: avformat/jpegxl_anim_dec: use new animated JPEG XL codec ID
thilo has quit [Ping timeout: 246 seconds]
<michaelni>
BBB, i try to backport my bugfixes but i have never tried to backport everyones bugfixes. So unless we find someone that does that, everyone has to backport their bugfixes which they want backported
thilo has joined #ffmpeg-devel
<michaelni>
Traneptora, sleep? what is that ?
System_Error has quit [Remote host closed the connection]
rvalue has quit [Read error: Connection reset by peer]
rvalue has joined #ffmpeg-devel
<BBB>
michaelni: what are the currently maintained release branches?
<BBB>
and what is the process? is cherry-pick 060464105b -3 enough? or does it need more information?
<beastd>
IMHO try the cherry pick (see if it runs through without problems, git will stop and explain if things don't fit). Check if all expected commits are on top of the branch now. then build and run fate. if you think all is ok try to push the branch. continue with the next release branch.
<BBB>
I can't run fate, the changes are on arm
<BBB>
I don't have arm
<beastd>
it's been a while since i backported stuff for ffmpeg, but IIRC that's how i did it
<michaelni>
BBB, maintained release branches are the ones on https://ffmpeg.org/download.html, though when backporting has been done to release n and m then anything between is probably "free" and no work
<michaelni>
also please add -x to the cherry pick so the commit hash of the source commit is in the commit message (this makes tracking things easer)
<BBB>
git cherry-pick -x $hash -3
<michaelni>
yes
<BBB>
ok
<beastd>
yeah, -x is good for this picks. it's not default because it often makes no sense. but especially when backporting it's good because you are picking from a stable branch
<BBB>
2.8, 3.4, 4.2, 4.3, 4.4, 5.1, 6.1, 7.0, 7.1
<beastd>
BBB: ok i can give it a run on aarch64 after it's pushed. think i could also run on arm but that will be a little more involved.
<BBB>
oh wow it applies to 3.4 cleanly
<BBB>
(2.8 did not)
<michaelni>
if you do a lot of testing then seting up qemu+cross build is not hard, ubuntu at least has all packages one needs for several architectures like arm and mips
<kurosu>
Sounds like that should be automated, but I imagine fate+samples are only valid for master and not versioned, so no easy to fully validate a branch ?
<kurosu>
*not easy
<kurosu>
(branch or tag)
<beastd>
kurosu: iirc samples shold not be changed in fate collection. so it should work also for older fate.
<michaelni>
fate works with old checkouts
<kurosu>
ah right, it's the output that needs updating, and that's under the regular git
<beastd>
only add new samples, never change or remove old ones (at some point we could consider deleting old samples, but as long as it's not needed i would not)
<BBB>
man, sometimes shell scripting feels like cheating
cone-369 has joined #ffmpeg-devel
<cone-369>
ffmpeg Janne Grunau release/3.4:180f8216cdb6: aarch64: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/3.4:80ef3328b559: arm: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/3.4:970ca1e0f259: vp9: recon: Use emulated edge to prevent buffer overflows
<cone-369>
ffmpeg Janne Grunau release/4.2:bfed437be84e: aarch64: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/4.2:a342536d6b1b: arm: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/4.2:655b6f887788: vp9: recon: Use emulated edge to prevent buffer overflows
<kurosu>
So it would be nice that whatever populates fate.ffmpeg.org can also be run on tags. But maybe it can already, or it's worthy of some sponsorship to make the needed changes
<cone-369>
ffmpeg Janne Grunau release/4.3:69107495c5e4: aarch64: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/4.3:131bd9436c2a: arm: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/4.3:6cd0bdf3b064: vp9: recon: Use emulated edge to prevent buffer overflows
<cone-369>
ffmpeg Janne Grunau release/4.4:d3b9fd51b82d: aarch64: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/4.4:fe955a7d779f: arm: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<BBB>
beastd: ok pushed, please test if you can on one-or-some of these branches
<cone-369>
ffmpeg Janne Grunau release/4.4:7b0213a111db: vp9: recon: Use emulated edge to prevent buffer overflows
<cone-369>
ffmpeg Janne Grunau release/5.1:0dac8251f741: aarch64: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/5.1:3562311c3027: arm: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/5.1:14afc43c27d9: vp9: recon: Use emulated edge to prevent buffer overflows
<cone-369>
ffmpeg Janne Grunau release/6.1:7f0d4aa61c55: aarch64: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/6.1:6a2b9d4c29be: arm: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/6.1:2a29fe87c42a: vp9: recon: Use emulated edge to prevent buffer overflows
<cone-369>
ffmpeg Janne Grunau release/7.0:7f1e2090285e: aarch64: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/7.0:0407cd499058: arm: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/7.0:bb1a9c5932d3: vp9: recon: Use emulated edge to prevent buffer overflows
<cone-369>
ffmpeg Janne Grunau release/7.1:1a254c5354fb: aarch64: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/7.1:535a8262ccf6: arm: vp9mc: Load only 12 pixels in the 4 pixel wide horizontal filter
<cone-369>
ffmpeg Janne Grunau release/7.1:7d1532f75297: vp9: recon: Use emulated edge to prevent buffer overflows
<BBB>
beastd: (and thanks)
<BBB>
wbs: backport done
<beastd>
kurosu: agree we need more automation for this. would definitely give it a try when we setup a git forge for ffmpeg. think it would be good to run fate for topic branches (similar on how it works with patchwork) on a wide subset of platforms/architectures. would of course need suitably isolated fate clients. not sure how much it is a problems with current fate clients setups.
<beastd>
BBB: ok, will give it a try and report back
<kurosu>
Several years ago, I tried asking Intel to provide nodes to perform any hw test. I'm a bit baffled by how much they invest in adding things to ffmpeg, only for this to not be testable by other devs
<kurosu>
(maybe I have to mention 2 other brands, such AMD and Nvidia, to not be taxed of advertisement)
<beastd>
kurosu: yeah, think it would be really cool if all $big_corp would not only donate code but also hw to run it long term
<beastd>
this will also need probably some thought in regards to extending fate. don't think we test much more than our internal stuff and os integration, but i could be wrong. would be good to also do some more integration testing with 3rd party stuff
HarshK23 has joined #ffmpeg-devel
<beastd>
does someone remember GCC14 fixes for ffmpeg? would maybe be good to backport them to older branches.
<beastd>
Kind of OT, but maybe someone knows by chance (wbs ?). Do most compilers guarantee to only produce output files (objects, libs, executables etc.) only either complete or not at all? (I would expect so, but never checked.)
<cone-369>
ffmpeg Leandro Santiago master:9d9ac8e2ca6b: avfilter/vf_dnn_detect: fix loading anchors when labels file is set
IndecisiveTurtle has joined #ffmpeg-devel
<beastd>
BBB: 3.4, 4.2, 4.3, 4.4, 5.1, 6.1, 7.0, 7.1 <-- all tested on aarch64 without problems. so if the original changes are correct the backports should probably be fine as well
<beastd>
had to make some tradeoffs regarding a bunch of fate tests because of zlib-ng vs fate. but i checked and it seems it's only the usual culprits with embedded png. could not see how it could be affected by vp9 aarch64 changes.
<beastd>
also tested that on current master works fine with the help of my fate .alt file patch set.
<BBB>
cool, tnx
ngaullier has joined #ffmpeg-devel
<fflogger>
[editedticket] quinkblack: Ticket #11363 ([avcodec] [Android] MediaCodec decoders/encoders do not work on Pixel 8 Pro (No output buffer available)) updated https://trac.ffmpeg.org/ticket/11363#comment:5
jalsdflkadfadsf has quit [Ping timeout: 240 seconds]
<beastd>
wbs: today i have backported fate-list-failing locally. as expected no conflicts. you are fine with backporting to all releases listed on our download page?
___nick___ has quit [Ping timeout: 260 seconds]
<wbs>
beastd: I'm a little undecided on that; it's not a pure bugfix, but it also quite safe and harmless... I would raise the question on the mailing list and ask if there are any objections to backporting it
<beastd>
wbs: good point. i just find it useful on releases as well. e.g. for doing backports. will send a mail to the list...
witchymary has quit [Remote host closed the connection]
witchymary has joined #ffmpeg-devel
witchymary has quit [Remote host closed the connection]
witchymary has joined #ffmpeg-devel
jalsdflkadfadsf has joined #ffmpeg-devel
jamrial has joined #ffmpeg-devel
Everything has quit [Quit: leaving]
ccawley2011__ has quit [Read error: Connection reset by peer]
jalsdflkadfadsf has quit [Ping timeout: 240 seconds]
cone-034 has joined #ffmpeg-devel
<cone-034>
ffmpeg Michael Niedermayer release/2.8:a17acf84d86a: avcodec/hevcdec: Check ref frame
<cone-034>
ffmpeg Michael Niedermayer release/2.8:cb1d4c907296: avcodec/lpc: copy levenson coeffs only when they have been computed
<cone-034>
ffmpeg Michael Niedermayer release/2.8:c13f25a0de89: libavutil/base64: Try not to write over the array end
<cone-034>
ffmpeg Michael Niedermayer release/2.8:561821b3b871: avcodec/mpeg4videodec: assert impossible wrap points
<cone-034>
ffmpeg Michael Niedermayer release/2.8:b788b7319ebd: avcodec/vble: Check av_image_get_buffer_size() for failure
<cone-034>
ffmpeg Michael Niedermayer release/2.8:79fc6b58f02f: avcodec/jpeg2000dec: remove ST=3 case
<cone-034>
ffmpeg Michael Niedermayer release/2.8:c4998eaaf492: avcodec/mpegvideo_enc: Fix 1 line and one column images
<cone-034>
ffmpeg Michael Niedermayer release/2.8:8c3bfd48e650: ffmpeg_filter: Factor get_compliance_unofficial_pix_fmts() out
<cone-034>
ffmpeg Michael Niedermayer release/2.8:ec2d476bb04b: swscale/yuv2rgb: Use 64bit for brightness computation
<cone-034>
ffmpeg Michael Niedermayer release/2.8:52d6370f84da: avformat/ape: Use 64bit for final frame size
<cone-034>
ffmpeg Michael Niedermayer release/2.8:f77bf5035892: avcodec/wavpackenc: Use unsigned for potential 31bit shift
<cone-034>
ffmpeg Michael Niedermayer release/2.8:2fef501f476f: avcodec/vp8: Check mutex init
<cone-034>
ffmpeg Michael Niedermayer release/2.8:f1ebfc94c7af: avcodec/vp8: Check cond init
<cone-034>
ffmpeg Michael Niedermayer release/2.8:303fea7956db: avformat/sdp: Check before appending ","
<cone-034>
ffmpeg Michael Niedermayer release/2.8:8da2dc2c830f: avfilter/vf_rotate: Check ff_draw_init2() return value
<cone-034>
ffmpeg Lynne release/2.8:6836dc4cbe0e: configure: update copyright year
<cone-034>
ffmpeg Michael Niedermayer release/2.8:9132cfb64ab5: avcodec/snowenc: MV limits due to mv_penalty table size
<cone-034>
ffmpeg Michael Niedermayer release/2.8:0bc33e429d0d: avcodec/targaenc: Allocate space for the palette
<cone-034>
ffmpeg Michael Niedermayer release/2.8:4f59700877e7: swscale/output: alpha can become negative after scaling, use multiply
<cone-034>
ffmpeg Michael Niedermayer release/2.8:d968f84435eb: swscale/output: Avoid undefined overflow in yuv2rgb_write_full()
<cone-034>
ffmpeg Michael Niedermayer release/2.8:5c91dbc76cd3: avformat/img2dec: assert no pipe on ts_from_file
<cone-034>
ffmpeg Michael Niedermayer release/2.8:f396fcf8bccb: avdevice/dshow: Check ICaptureGraphBuilder2_SetFiltergraph() for failure
<cone-034>
ffmpeg Michael Niedermayer release/2.8:3452b66e0914: avformat/mpeg: Check len in mpegps_probe()
<cone-034>
ffmpeg Michael Niedermayer release/2.8:3fc695526afd: avformat/rdt: Check pkt_len
<cone-034>
ffmpeg Michael Niedermayer release/2.8:511aa1819848: avfilter/af_pan: check nb_output_channels before use
<cone-034>
ffmpeg Michael Niedermayer release/2.8:d578636445f8: avformat/rtsp: use < 0 for error check
<cone-034>
ffmpeg Michael Niedermayer release/2.8:c98549ff4ba8: avformat/rtsp: initialize reply1
<cone-034>
ffmpeg Michael Niedermayer release/2.8:c7688a21a484: avformat/rtsp: Check that lower transport is handled in one of the if()
<cone-034>
ffmpeg Michael Niedermayer release/2.8:ea0504bf81c9: avformat/subfile: Assert that whence is a known case
<cone-034>
ffmpeg Michael Niedermayer release/2.8:bcef03443aa3: avformat/rmdec: use 64bit for audio_framesize checks
<cone-034>
ffmpeg Michael Niedermayer release/2.8:02d98cd55a08: avformat/rtmppkt: Simplify and deobfuscate amf_tag_skip() slightly
<cone-034>
ffmpeg Michael Niedermayer release/2.8:4c1908393bf2: avutil/imgutils: av_image_check_size2() ensure width and height fit in 32bit
<cone-034>
ffmpeg Michael Niedermayer release/2.8:12c1072179bc: avcodec/golomb: Document return for get_ur_golomb_jpegls() and get_sr_golomb_flac()
<cone-034>
ffmpeg Michael Niedermayer release/2.8:416d92d900e4: avcodec/golomb: Assert that k is in the supported range for get_ur/sr_golomb()
<cone-034>
ffmpeg Michael Niedermayer release/2.8:d3cda0b199da: avcodec/loco: check get_ur_golomb_jpegls() for failure
<cone-034>
ffmpeg Michael Niedermayer release/2.8:88e11f921f8b: avcodec/loco: Check loco_get_rice() for failure
<cone-034>
ffmpeg Michael Niedermayer release/2.8:58acc6bda494: avcodec/motion_est: Fix score squaring overflow
<cone-034>
ffmpeg Michael Niedermayer release/2.8:216142169d2c: avcodec/flac_parser: Assert that we do not overrun the link_penalty array
<cone-034>
ffmpeg Michael Niedermayer release/2.8:b60707011eb2: avdevice/dshow_filter: Use wcscpy_s()
<cone-034>
ffmpeg Michael Niedermayer release/2.8:d91f7ce227f1: avcodec/utvideoenc: Use unsigned shift to build flags
<cone-034>
ffmpeg Michael Niedermayer release/2.8:d8d3395c17f4: avformat/asfdec_o: Check size of index object
<cone-034>
ffmpeg Michael Niedermayer release/2.8:836e1d870651: avformat/hnm: Check *chunk_size
<cone-034>
ffmpeg Michael Niedermayer release/2.8:fca1b73d2a1d: avformat/mm: Check length
<cone-034>
ffmpeg Michael Niedermayer release/2.8:962bf1c1711c: avformat/mov: Use 64bit for str_size
<cone-034>
ffmpeg Michael Niedermayer release/2.8:99b01e80b4e5: avformat/mp3dec; Check for avio_size() failure
<cone-034>
ffmpeg Michael Niedermayer release/2.8:358be1d9cb50: avformat/sapdec: Check ffurl_get_file_handle() for error
<cone-034>
ffmpeg Michael Niedermayer release/2.8:477d964e3235: avformat/sauce: Check avio_size() for failure
<cone-034>
ffmpeg Michael Niedermayer release/2.8:2975e218a0b4: avformat/siff: Basic pkt_size check
<cone-034>
ffmpeg Michael Niedermayer release/2.8:7d89f3c14fb4: avformat/xmv: Check this_packet_size
<cone-034>
ffmpeg Michael Niedermayer release/2.8:8839014ace11: avcodec/hevc/hevcdec: Do not allow slices to depend on failed slices
<cone-034>
ffmpeg Michael Niedermayer release/2.8:a9db4fc7e11d: avcodec/proresdec: Consider negative bits left
<cone-034>
ffmpeg Michael Niedermayer release/2.8:0e48345f8511: avcodec/utils: apply the same alignment to YUV410 as we do to YUV420 for snow
<cone-034>
ffmpeg Michael Niedermayer release/2.8:272fd292cfa5: avcodec/snow: Fix off by 1 error in run_buffer
<cone-034>
ffmpeg Michael Niedermayer release/2.8:818e10d0ce0c: avformat/wavdec: Check if there are 16 bytes before testing them
<cone-034>
ffmpeg Michael Niedermayer release/2.8:3a1810f1c19f: avformat/img2dec: Clear padding data after EOF