michaelni changed the topic of #ffmpeg-devel to: Welcome to the FFmpeg development channel | Questions about using FFmpeg or developing with libav* libs should be asked in #ffmpeg | This channel is publicly logged | FFmpeg 7.1 has been released! | Please read ffmpeg.org/developer.html#Code-of-conduct
^Neo has joined #ffmpeg-devel
^Neo has quit [Changing host]
^Neo has joined #ffmpeg-devel
thilo has quit [Ping timeout: 248 seconds]
thilo has joined #ffmpeg-devel
cone-348 has joined #ffmpeg-devel
<cone-348>
ffmpeg Lynne master:851a84650ef6: hwcontext_vulkan: check if semaphores are exportable before enabling exporting
System_Error has quit [Remote host closed the connection]
<DodoGTA>
How long does it take to get a simple patch into FFmpeg? I submitted a one-liner fix for tracker music and it's still collecting dust 4 days later
Kei_N_ has quit [Read error: Connection reset by peer]
<GuruLeader>
its probably recorder with spatial 360deg video?
<Marth64>
yeah I have a "Spatial" section in the camera for 360deg video (I don't have the VR headset)
<Marth64>
however didn't get any APAC out of it, just AAC. I also don't have the iPhone 16 series
<GuruLeader>
yea, you will need iphone >=16
<Marth64>
got it
<fflogger>
[editedticket] jamrial: Ticket #11407 ([undetermined] heap-buffer-overflow vulnerability find in in function mov_read_trun at /ffmpeg/libavformat/mov.c:5944) updated https://trac.ffmpeg.org/ticket/11407#comment:1
ccawley2011 has quit [Ping timeout: 276 seconds]
<abdu>
hello everyone, I was wondering why some filters doesn't have the macro NULL_IF_CONFIG_SMALL wrapped around their description while other have ?
abdu has quit [Quit: Client closed]
abdu has joined #ffmpeg-devel
GuruLeader has quit [Quit: Client closed]
<beastd>
abdu: How many did you find? Would expect it to just have been forgotten?
<abdu>
a lot, I know it's there for some reason but don't know why
<jamrial>
that wrapper is used to ensure CONFIG_SMALL builds don't include long strings, like long names for modules
<cone-699>
ffmpeg Nuo Mi master:8eb1d76e146a: lavc/vvc/refs: export keyframe and picture type in output frames
<beastd>
can you name a filter where it is fogotten?
<abdu>
Is there some threshold to decide if a string is long or it's left to the person who wrote the filter to decide ?
<abdu>
signalstats
<beastd>
yeah. i found that one too. and it's the only one that is missing NULL_IF_CONFIG_SMALL
<beastd>
or did you find more?
abdu16 has joined #ffmpeg-devel
abdu has quit [Ping timeout: 240 seconds]
abdu72 has joined #ffmpeg-devel
<beastd>
not sure if you saw it, i said: yeah. i found that one too. and it's the only one that is missing NULL_IF_CONFIG_SMALL or did you find more?
<beastd>
the rule is to just always use NULL_IF_CONFIG_SMALL for optional long descriptions/long_name/etc. it will not help a lot in all cases but it probably will always save some bytes. and if you --enable-small it might well be that you are under a very constraint environment where the sum of all the small savings matter.
abdu16 has quit [Ping timeout: 240 seconds]
Teukka has quit [Read error: Connection reset by peer]
abdu72 has quit [Quit: Client closed]
HarshK23 has quit [Quit: Connection closed for inactivity]
<mkver>
According to "git grep -L NULL_IF_CONFIG_SMALL $(git grep -lw FFFilter)" it is only signalstats that is lacking it.
Teukka has joined #ffmpeg-devel
Teukka has quit [Changing host]
Teukka has joined #ffmpeg-devel
ccawley2011 has joined #ffmpeg-devel
abdu72 has joined #ffmpeg-devel
<mkver>
jamrial: You should probably also use an unsigned i then.
<jamrial>
yes, i was looking into that
<jamrial>
stts and ctts arrays are allocated with different constrains
<jamrial>
stts will not have a count > INT_MAX, but ctts will
<jamrial>
might, rather
<abdu72>
I want really to contribute in the project, If I submitted a patch adding this macro will it be accepted ?
<jamrial>
if it's good, sure
ccawley2011 has quit [Read error: Connection reset by peer]
HarshK23 has joined #ffmpeg-devel
<abdu72>
I sent a patch in the mailing list, this is my first patch so I don't know if I did it right or not.
<BtbN>
the patch looks like it got mangled by newlines
<BtbN>
make sure to use git send-email, don't paste it into gmail or something
<jamrial>
or attach the patch generated by git format-patch
<abdu72>
jamrial in gmail ?
<jamrial>
yes
<abdu72>
I tried to send it as an attachment to myself, the email body was blank and the .eml file appeared as an attachment, not like the mails in the mailing list
<abdu72>
or maybe this happened because .eml was generated to ffmpeg-devel ? I don't know
<jamrial>
i mean attaching the .patch file the git format-patch generates
<kierank>
attaching as a file is the only non-complicated way to do it in gmail