michaelni changed the topic of #ffmpeg-devel to: Welcome to the FFmpeg development channel | Questions about using FFmpeg or developing with libav* libs should be asked in #ffmpeg | This channel is publicly logged | FFmpeg 6.1 has been released! | Please read ffmpeg.org/developer.html#Code-of-conduct
feiw1 has quit [Ping timeout: 252 seconds]
feiw1 has joined #ffmpeg-devel
qeed has quit [Ping timeout: 260 seconds]
qeed has joined #ffmpeg-devel
cone-882 has joined #ffmpeg-devel
<cone-882>
ffmpeg Marth64 master:d06518e448c5: doc/ffmpeg: AV_FMT_DISCONT typo should be AVFMT_TS_DISCONT
<cone-882>
ffmpeg Marth64 master:715e5e3e238d: doc/bitstream_filters: add setts example
iive has quit [Quit: They came for me...]
hbbs has quit [Quit: bye]
hbbs has joined #ffmpeg-devel
hbbs has joined #ffmpeg-devel
hbbs has quit [Changing host]
thilo has quit [Ping timeout: 276 seconds]
thilo has joined #ffmpeg-devel
thilo has quit [Changing host]
thilo has joined #ffmpeg-devel
<Marth64>
jamrial_: apologies, I think I sent an updated patch incorrectly with git. It is here http://ffmpeg.org/pipermail/ffmpeg-devel/2023-December/318073.html . I can resend with a sign-off if required (will not miss that next time). Thank you for catching the mistake
<Marth64>
fate tests pass and no damage of removing -ab this time ...
mkver has joined #ffmpeg-devel
lemourin has quit [Read error: Connection reset by peer]
lemourin has joined #ffmpeg-devel
jamrial_ has quit []
navi has quit [Quit: WeeChat 4.0.4]
cone-882 has quit [Quit: transmission timeout]
cone-090 has joined #ffmpeg-devel
<cone-090>
ffmpeg Gyan Doshi master:b9fd3e7a88b3: avfilter/select: initialize prev_selected_n to NAN
<Marth64>
Traneptora: re- > my biggest question is why this is not a protocol that produces an mpeg-ps stream.
<Marth64>
Are you referring to opening a protocol handler instead of a MPEG-PS demuxer context ("subdemux"), within the overall DVD demuxer? If so I hadn't thought about that and it makes a lot of sense. Just wanted to ask if there's an example already there. My reference for this was mostly dashdec/hls
<Traneptora>
well, consider that the bluray protocol doesn't attempt to demux the underlying stream
<Traneptora>
just as an example
<Traneptora>
you could repurpose your dvdnav-based demuxer as a protocol, that just produces data
<Traneptora>
rather than call avformat to then demux that data, let avformat handle that itself
<Marth64>
The issue I had when I went down the route of writing the entire thing as a protocol was with inability to provide metadata, and also handling of subtitle streams that show mid-playback.
<Traneptora>
what kind of metadata
<Marth64>
Language of individual streams, chapters. and stream IDs for the forced subtitles
<Traneptora>
I see, so protocols can't expose those kinds of things, it has to be a demuxer. hm.
<Marth64>
Yep
<Traneptora>
but why doesn't seeking work? mpeg-ps is (somewhat) seekable
<Marth64>
and so I followed what dashdec and HLS did, and that's how I came to initialize a sub-demuxer
<Marth64>
Re, seeking: I simply did not implement it. but it's not the MPEG-PS I'd be seeking, it's the playback of the DVD VM state managed by libdvdnav. which is critical because many discs have seamless branching that only libdvdnav can handle
<Traneptora>
right but you mentioned that you set the avformat to GENPTS
<Traneptora>
the sub-demuxer
<Traneptora>
that sounds incorrect
<Marth64>
Yes, which was a big mistake, and I'm now realizing the connection after reading your discussion thoughts
<Marth64>
because it's trying to seek ahead when calculating PTS it wants future frames
<Traneptora>
if you need a sub-demuxer, you should take the AVPacket it produces and set the pts to what it should be
<Traneptora>
rather than generating possibly-not-garbage pts
<Marth64>
Yeah. I'll study tonight to see if I can get it authoritatively from the disc itself. Maybe from the NAV packets
<Traneptora>
I'm assuming libdvdnav has a way of producing that PTS information
<Traneptora>
since if it's not in the MPEG-PS stream it has to be somewhere
<Marth64>
Hilarious. I must have looked at this header many times and I can't believe I missed it. It does. I am pumped to try it.. thank you for provoking this thought
<Marth64>
dvdnav_get_current_time()
<Marth64>
As for the YUV/RGB, I'm realizing the conceptual flaw there. It shouldn't be in the demuxer you are right. But I would argue to make it functional for users, then it should be in the MKV muxer just as is done with MOV/MP4. Since the convention in MKV is to have it RGB
<Marth64>
The subtitles have palettes, they should be usable
marcj has quit [Read error: Connection reset by peer]
marcj has joined #ffmpeg-devel
qeed has quit [Quit: Leaving]
\\Mr_C\\ has joined #ffmpeg-devel
<Traneptora>
yea, I don't see why the demuxer has to convert the palette to RGB
<Traneptora>
just because some muxers can't use YUV palettes
<Traneptora>
provided it can tag the palette with the correct colorspace it should just do that
<Marth64>
yes I will find a better way once I fix timestamps. I have done some of the other cleanup you requested
AbleBacon has quit [Read error: Connection reset by peer]
<mkver>
BtbN: Seems like Coverity needs a kick again.
dellas has joined #ffmpeg-devel
kepstin has quit [Remote host closed the connection]
kepstin has joined #ffmpeg-devel
haihao has quit [Ping timeout: 252 seconds]
haihao has joined #ffmpeg-devel
feiw1 has quit [Ping timeout: 252 seconds]
feiw1 has joined #ffmpeg-devel
b50d has joined #ffmpeg-devel
cone-077 has quit [Quit: transmission timeout]
b50d has quit [Remote host closed the connection]
b50d has joined #ffmpeg-devel
zsoltiv has joined #ffmpeg-devel
MikhailAMD has quit [Read error: Connection reset by peer]
MikhailAMD has joined #ffmpeg-devel
jamrial has joined #ffmpeg-devel
b50d has quit [Remote host closed the connection]
Krowl has joined #ffmpeg-devel
qeed has joined #ffmpeg-devel
navi has joined #ffmpeg-devel
ccawley2011 has joined #ffmpeg-devel
Krowl has quit [Read error: Connection reset by peer]
kurosu has joined #ffmpeg-devel
Kei_N has quit [Ping timeout: 256 seconds]
Kei_N has joined #ffmpeg-devel
deus0ww has quit [Ping timeout: 264 seconds]
deus0ww has joined #ffmpeg-devel
b50d has joined #ffmpeg-devel
dellas has quit [Remote host closed the connection]
dellas has joined #ffmpeg-devel
b50d has quit [Remote host closed the connection]
dellas has quit [Remote host closed the connection]
beastd has joined #ffmpeg-devel
mkver has quit [Ping timeout: 276 seconds]
Krowl has joined #ffmpeg-devel
Workl has joined #ffmpeg-devel
Krowl has quit [Ping timeout: 276 seconds]
dellas has joined #ffmpeg-devel
psykose has joined #ffmpeg-devel
dellas has quit [Remote host closed the connection]
microchip_ has quit [Quit: There is no spoon!]
microchip_ has joined #ffmpeg-devel
dellas has joined #ffmpeg-devel
Workl has quit [Read error: Connection reset by peer]
haihao has quit [Ping timeout: 268 seconds]
haihao has joined #ffmpeg-devel
kurosu has quit [Quit: Connection closed for inactivity]
kurosu has joined #ffmpeg-devel
clarkh has quit [Read error: Connection reset by peer]
<zsoltiv>
how should i make it so users won't have to pass `-f rawvideo` when encoding animated JPEG XLs? should i make up a new AV_CODEC_ID or make its id AV_CODEC_ID_RAWVIDEO?
<sfan5>
shouldn't there be a muxer to accompany it in that case?
derpydoo has joined #ffmpeg-devel
<Lynne>
effort spent on supporting anything except intra-only jxl should be better spend inventing a time machine to avoid them
Krowl has joined #ffmpeg-devel
<zsoltiv>
sfan5: i don't see any code for muxing jxl in libavformat, aside from image2. and i was unable to find the spec for storing jpeg xl in a file (that didn't cost money)
<zsoltiv>
Lynne: what does 'intra-only jxl' mean?
<Lynne>
just a stream of independent jxl frames, without inter-frame painting
<zsoltiv>
Lynne: i'm not sure if my implementation does that, it's all just libjxl glue code. will submit it to the ML once i figure out the muxing part
j45 has quit [Ping timeout: 260 seconds]
j45 has joined #ffmpeg-devel
j45 has quit [Changing host]
j45 has joined #ffmpeg-devel
<Lynne>
I was just talking in general about the format, not the patch
<Lynne>
...we should've implemented alpha-channel video for av1, and someone from google was going to, but we ran out of time
Krowl has quit [Read error: Connection reset by peer]
Krowl has joined #ffmpeg-devel
Krowl has quit [Read error: Connection reset by peer]
Krowl has joined #ffmpeg-devel
Krowl has quit [Read error: Connection reset by peer]
Krowl has joined #ffmpeg-devel
kalev has quit [Remote host closed the connection]
derpydoo has quit [Ping timeout: 245 seconds]
Krowl has quit [Read error: Connection reset by peer]
tufei__ has joined #ffmpeg-devel
tufei_ has quit [Remote host closed the connection]
ccawley2011 has quit [Read error: Connection reset by peer]
kurosu has quit [Quit: Connection closed for inactivity]
Evgeniy has joined #ffmpeg-devel
Evgeniy has quit []
Sk0tik has joined #ffmpeg-devel
zsoltiv has quit [Remote host closed the connection]
tufei_ has joined #ffmpeg-devel
tufei__ has quit [Ping timeout: 240 seconds]
witherScript has joined #ffmpeg-devel
witherScript has quit [Client Quit]
witherScript has joined #ffmpeg-devel
witherScript has quit [Remote host closed the connection]
witherScript has joined #ffmpeg-devel
psykose has quit [Ping timeout: 276 seconds]
witherScript has quit [Remote host closed the connection]
psykose has joined #ffmpeg-devel
catfella__ has joined #ffmpeg-devel
catfella_ has quit [Ping timeout: 246 seconds]
witherScript has joined #ffmpeg-devel
witherScript has quit [Ping timeout: 246 seconds]
mkver has joined #ffmpeg-devel
dellas has quit [Remote host closed the connection]