saschagrunert has quit [Remote host closed the connection]
bgilbert has joined #fedora-coreos
jpn has quit [Ping timeout: 264 seconds]
jpn has joined #fedora-coreos
marmijo has quit [Quit: Client closed]
bytehackr has quit [Ping timeout: 250 seconds]
marmijo has joined #fedora-coreos
<bgilbert>
dustymabe: I just accidentally landed https://github.com/coreos/fedora-coreos-config/pull/1970 because the pr-merge check isn't set as required (for _any_ branch) in f-c-c branch protection. do you know of any reason for that configuration, or should I set it as required?
<dustymabe>
i'm not sure - you're saying it landed because you approved it and set it to automerge and it went through before CI passed?
<dustymabe>
I think I may have messed this up recently when trying to change things so that people can't force push to the repo and create new branches by accident (i.e. when they meant to push to their fork)
<dustymabe>
bgilbert: I'm guessing the right knob to set is "Require status checks to pass before merging"?
<bgilbert>
yes, and then adding the status check to the list
<bgilbert>
I can handle, I just wasn't sure why it wasn't there
<bgilbert>
I thought I was setting it to automerge, but actually I was just merging it because there were no remaining constraints
<dustymabe>
+1 - it's my fault. I inadverdently removed the branch protection and then tried to set it back up but didn't click everything I needed to
<dustymabe>
that was last week ^^
<bgilbert>
+1, I've fixed the config
<bgilbert>
FWIW you can change the branch name pattern without deleting and recreating the rule
<dustymabe>
đź‘Ť
jpn has quit [Ping timeout: 265 seconds]
<bgilbert>
dustymabe: are we still planning to do a next release next week along with the others?
<dustymabe>
bgilbert: I think
c4rt0 has joined #fedora-coreos
<bgilbert>
+1
<dustymabe>
keeping it in cadence with the others until final freeze
c4rt0 has quit [Remote host closed the connection]
<dustymabe>
at which point we go to every week for `next`
<dustymabe>
this one is a one-off for beta
c4rt0_ has quit [Quit: Leaving]
mnguyen has joined #fedora-coreos
mnguyen_ has quit [Ping timeout: 265 seconds]
<bgilbert>
+1
<bgilbert>
dustymabe: we'll be switching testing to F37 while the serial console changes are still baking in next. what's the best way to make sure we don't inadvertently promote the console changes early?
<dustymabe>
bgilbert: i think it mostly depends on how it's implemented - do you have a link handy to the f-c-c PR with the enablement bits in it?
<bgilbert>
but we'll be doing the next -> testing promotion exactly once, so I was wondering if a process fix made more sense than a code fix
<dustymabe>
bgilbert: i.e. rather than fixing "promote config" to ignore it?
<bgilbert>
yeah
<dustymabe>
yeah I mean I'll try to remember :) I don't know exactly where we'd put a process fix for it right now (i.e. the streams issue for that particular build won't be opened for a while now)
fifofonix has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<bgilbert>
okay, maybe what I'll do is land the kola test in all streams and hardcode which streams are expected to have the new behavior
<dustymabe>
+1
<dustymabe>
yeah - honestly the kola test in that PR was going to get deleted anyway by config-bot IIUC (i.e. testing-devel is the source of truth for most files unless excepted in config bot)
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 268 seconds]
fifofonix has joined #fedora-coreos
<dustymabe>
bgilbert: got a sec to discuss something?
<dustymabe>
I have to go do kid time, will catch you later
<bgilbert>
dustymabe: yeah, I just realized that today. the kola test was added to the PR later
nalind has quit [Quit: bye]
mheon has quit [Ping timeout: 250 seconds]
fifofonix has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]