<spresti[m]>
dustymabe: Just saw this pr request, was wondering if it needed my stamp or not? https://github.com/openshift/os/pull/949 its been sitting for 6 days.
<dustymabe>
I think maybe bgilbert made the automation that auto bumps it
<dustymabe>
but yeah, I think if it passes tests we could/should merge it
<dustymabe>
cc jlebon
<spresti[m]>
Thank you
nalind has joined #fedora-coreos
mnguyen_ has quit [Ping timeout: 252 seconds]
mnguyen has quit [Ping timeout: 252 seconds]
<jlebon>
yup, the bot just creates it whenever there's new commits in f-c-c since the last bump
mnguyen has joined #fedora-coreos
mnguyen_ has joined #fedora-coreos
<jlebon>
so it doesn't have to be merged right away. just whenever it gets long enough or there's things in there we want in openshift/os
<dustymabe>
ahh I see
<dustymabe>
so we should probably only merge if if there are things that are important for RHCOS in the list
<spresti[m]>
well whoops
<jlebon>
meh, it's fine really :) it'll make the next bump easier to parse through
<spresti[m]>
So should we even approve it? and how would we know what we want in the os or not? presumably any improvements are wanted, what makes it worth it?
<spresti[m]>
Its been approved but not merged for clarification
mheon has quit [Remote host closed the connection]
mheon has joined #fedora-coreos
paragan has quit [Ping timeout: 248 seconds]
Betal has joined #fedora-coreos
mnguyen has quit [Ping timeout: 256 seconds]
mnguyen_ has quit [Ping timeout: 268 seconds]
mnguyen has joined #fedora-coreos
mnguyen_ has joined #fedora-coreos
aleek has quit [Ping timeout: 256 seconds]
aleek has joined #fedora-coreos
aleek has quit [Ping timeout: 248 seconds]
aleek has joined #fedora-coreos
<spresti[m]>
Wanted to ask, when we have an issue that covers two distinct issues, how do we split?
<spresti[m]>
Do we create the two separate issues independent of the first issue, then link them both in the first issue, and then once the independent issues are completed that then closes the parent?
<bgilbert>
spresti[m]: it's a judgment call. if the issue was originally filed about A and then B came up, B should be forked off
<bgilbert>
spresti[m]: if A decomposes into B and C, we might close A in favor of B and C