16:53 <groovy2shoes> farkuhar, is there some reason that pkgmeek wants to run pkgadd with su?

16:55 <farkuhar> groovy2shoes, are you building as a normal user, or as root? it should have a test for $UID=0 and run pkgadd without su in that case.

16:56 <groovy2shoes> i'm running as root. looks like it wants to use sudo for non-root, and `su -c` for root. but then su complains when it mistakes pkgadd's options for its own

16:58 <farkuhar> my bad, I should have added one more test on line 195.

16:59 <groovy2shoes> a [ -z "$PKGMK_SU" ] in front?

16:59 <farkuhar> that's right. I think I accidentally deleted it at some point.

17:03 <groovy2shoes> ok. if it ever falls back on `su -c`, i think it'll still have this problem. i find su's option parsing surprising. seems like it wants the whole command to be quoted? i tried sticking a '--' after -c to convince it to stop parsing arguments, but that doesn't work, either.

17:04 <farkuhar> yeah, maybe it should just fail the operation if it can't find sudo or doas.

17:05 <farkuhar> thanks again for testing. i can't by myself spin up all the VMs or containers that would be needed to discover these edge cases; i only work with the two or three CRUX installations i have on hand.

17:08 <groovy2shoes> np. i've updated my sysup script to optionally use pkgmeek, but i wanted to try a couple by hand before kicking it off.

17:08 <SiFuh> alias su="su -c "

17:09 <SiFuh> Would this concept work? Creating a variable and sticking a whitespace after it?

17:10 <SiFuh> Or even using alias itself

17:11 <groovy2shoes> nah. su's option parsing expects -c to have exactly one argument; the problem is that it's getting `su -c pkgadd -u <file>`, at which point only 'pkgadd' is passed to -c and su tries to parse '-u' as another of its own options

17:12 <groovy2shoes> so i think it'd have to be `su -c "pkgadd -u <file>"`, but i don't know how sudo or doas would like getting all their args stuffed into one like that

17:13 <groovy2shoes> it'd probably need to be a function rather than an alias, something like: ghetto_sudo() { su -c "$*"; }

17:16 <SiFuh> Yeah, I see.

17:21 <farkuhar> fwiw, the work that inspired pkgmeek just takes it for granted that the user will have sudo installed, there's no test of its existence (because sudo is a core package and opendoas wasn't on the radar four years ago): https://gitlab.com/therealfun/oprt/-/tree/master/

17:25 <SiFuh> Remember that. Changed to opendoas because sudo and doas were full of security issues.

17:25 <cruxbot> [opt.git/3.6]: thunderbird-bin: updated to version 91.10.0

17:29 <farkuhar> i admire Fun's dedication to the principle "do one thing and do it well", but i think it can be taken to an extreme. The same pithy coding style can also achieve feature parity with legacy code like pkgmk, without needing to separate out the desired functions across multiple independent scripts.

17:44 <SiFuh> I am good at drinking beer, but I don't think I would like to that to be the only thing ;-)

17:45 <groovy2shoes> yeah, sometimes i'd like to drink whiskey ;)

17:46 <SiFuh> Haha

17:46 <SiFuh> Drinking homemade beer and Sake. Was going to run 60 litres of vodka mash today but it is still fermenting. Maybe Tuesday or Wednesday I will do that.