<azonenberg>
4.7K line diff and libscopehal now compiles
<azonenberg>
on to scopeprotocols
<azonenberg>
actually scopeexports first
<azonenberg>
but thats only a handful of files so it should be quick
GenTooMan has quit [Ping timeout: 255 seconds]
GenTooMan has joined #scopehal
<azonenberg>
And scopeexports now compiles
<azonenberg>
we're now 31% of the way through the build and on to scopeprotocols
<azonenberg>
aand first refactored filter built
<azonenberg>
yay, that wasnt too bad
<azonenberg>
aaand first filter ported over too
<azonenberg>
diff is now 5172 lines. Hopefully i can bang out most if not all of the filter refactoring tomorrow then do glscopeclient itself friday
<azonenberg>
then push
<azonenberg>
this of course assumes once i have the whole project compiling it actually *runs*
<azonenberg>
but we'll find out i guess
<azonenberg>
louis: what do you think of making GetText() and GetColor() const methods? I want to, in general, do a better job of declaring things const when they dont change things
<azonenberg>
is there any conceivable reason either one of them would need to modify the waveform?
<azonenberg>
(please do not actually make the change until I finish this refactoring as the two would likely be difficult to merge - wait until i've pushed this)
<d1b2>
<louis> I can't think of a reason off the top of my head... The only hiccup I can think of is their needing to read FilterParameter values but I think I made the ->GetXXX() methods const a while ago in a different refactor
GenTooMan has quit [Ping timeout: 244 seconds]
GenTooMan has joined #scopehal
<azonenberg>
yeah. anyway, not a high priority but in general i think we should const-ify everything we can
<azonenberg>
and i stumbled across this whiel reviewing other stuff
tiltmesenpai[m] has quit [Quit: You have been kicked for being idle]