15:24 <tiosgz> is there a reason for Root.outputs to have the Output as value, not reference?

15:25 <tiosgz> seems like not even Root.all_outputs should behave like that, but there *Output is used

15:25 <tiosgz> so ig the inexplicable behaviour might come from this

15:28 <tiosgz> what surprises me it's from 2020 or earlier and still alive

15:29 <tiosgz> ah nope it can't be before 2020

16:21 <tiosgz> hmm, taking that back, as the Node is allocated with the Output embedded in it

16:22 <tiosgz> my question remains though

16:56 <prma> Hey all. I have been using river for more than a year at this point. And recently I have been learning zig. I would like to eventually start contributing to river. However I lack technical knowledge about how wayland works or how river works under the covers. Are there any starting points that you could point me towards to help me get on board?

17:24 <ifreund> tiosgz: there's no strong reason, the memory is pinned and has to live somewhere so might as well save an allocation and toss it together with the list node.

17:26 <ifreund> our problems here might stem from the fact that we only have a single outputs list but should in fact have Root.pending.outputs, Root.current.outputs and whatnot

17:27 <tiosgz> would it be better to swap types of Root.outputs and Root.all_outputs as a start? i don't think it would fix anything, but it's less confusing at least

17:29 <ifreund> prma: there's some good general wayland information here: https://wayland.freedesktop.org/ and here: https://wayland-book.com/

17:29 <tiosgz> i'll keep that {pending,current}.outputs in mind while debugging, anyway. didn't think of it before

17:31 <ifreund> tiosgz: I think the most clear solution would be make Root.output and Root.all_output both intrusive lists (using wl.list)

17:31 <ifreund> which would also require only a single allocation per Output to add in to the necessary lists instead of two

17:32 <tiosgz> erm, sorry, what's intrusive?

17:32 <ifreund> tiosgz: the linked list points are part of the Output struct

17:32 <ifreund> see e.g. View.pending_focus_stack_link

17:32 <ifreund> s/points/pointers/

17:33 <tiosgz> ah thanks. dictionary didn't help haha

17:33 <ifreund> no problem!

17:34 <tiosgz> i'll see where i get

17:34 <ifreund> good luck!

17:35 <tiosgz> thanks!

18:43 <prma> ifreund: thank you very much for the suggestions and your great work.

19:25 <ifreund> no problem! feel free to ask questions here if you get stuck :)