19:51 <PaulFertser> borneoa___: 8189 doesn't have any comments. Guess you meant some other change, can you please tell the number for me to check? Commentlink regexps were not changed and are enabled. \\s([0-9a-f]{12}\\b) is for the short hash.

20:02 <PaulFertser> This https://review.openocd.org/c/openocd/+/8198 has a short hash linked automatically in commit message.

20:03 <PaulFertser> It just doesn't work properly :)

20:06 <PaulFertser> OK, let me see how to properly use that matched hash, somehow it just finds it in the commit message itself and that's the problem.

20:13 <PaulFertser> It's odd https://review.openocd.org/q/commit:16b4b8cf5453 returns empty

20:16 <PaulFertser> borneoa___: I know why, it was comitted before Gerrit and didn't had Change-Id, so Gerrit can't show the change page for it.

20:16 <PaulFertser> And I think it's more useful to have a change page linked to rather than gitweb page if we have to choose?

20:31 <borneoa___> PaulFertser: yes, the first short hash points to a pre-git commit, so probably without change-id Gerrit fails to follow it. But below, after the change-id there is another short hash that is more recent and Gerrit fails to follow it too

20:33 <borneoa___> PaulFertser: the short has is preferred when you work locally as gitk is able to follow it locally. Having a url to a web page forces gitk to open a browser...

20:35 <PaulFertser> borneoa___: yes indeed. I was just thinking about what URL to use to be able to show pre-Gerrit commits but I think that's not worth it.

20:35 <PaulFertser> borneoa___: I'll fix the link soon, I see the problem now, thank you.

21:15 <PaulFertser> borneoa___: I fixed it to work how it was before. However I noticed that for that fixes hash it finds both old and new commit and shows a list to choose from. If I add "commit:" to the query string it'll show the list even if there's just a single change and will never proceed directly to the change anyway it seems.

21:19 <borneoa___> PaulFertser: yes, looks different than it was before, but I think it's good enough. Thanks