rcurtin_irc changed the topic of #mlpack to: mlpack: a scalable machine learning library (https://www.mlpack.org/) -- channel logs: https://libera.irclog.whitequark.org/mlpack -- NOTE: messages sent here might not be seen by bridged users on matrix, gitter, or slack
<rcurtin[m]> coatless: awesome! that URL would be correct for the actual release, where it would generate a link to the 4.0.0 documentation. it's a bit late here, but I'll review tomorrow 👍️
<coatless[m]> No worries. You might get some e-mails from the Win builder @ CRAN.
<coatless[m]> Let me know if there are any issues with the package.
<coatless[m]> I also placed the new R package on the mac builder as well: https://mac.r-project.org/macbuilder/results/1666753311-6c654913df24176c/
birm[m] has joined #mlpack
<rcurtin[m]> coatless: yep, and the emails even seemed happy :) but it looks like it is for the current master branch (4.0.1) not the release (4.0.0). I was thinking, one way we can get an R package for the 4.0.0 release is just to create a branch off the 4.0.0 tag, and then change like a single word or space in the documentation or something, and then when that branch is pushed, we'll get an R package (the branch can then be deleted). What do you think?
<EshaanAgarwal[m]> jonpsy: zoq: I have pushed some more commits and fixed couple of things. But unfortunately test isn't converging ! Can it be an issue with the parameters that we have set ? Like reward threshold etc ?
<EshaanAgarwal[m]> Pls can you take a look at the PR whenever you're free ?
<EshaanAgarwal[m]> One of the major things that I fixed was that I forgot to compute new reward when I stored HER Transitions.
<EshaanAgarwal[m]> Since for these transitions we have a new goal so we calculate reward separately and again.
<EshaanAgarwal[m]> Other thing I fixed was that I made sure that environment didn't had same initialstate and goal.
<ryan[m]123> another test message from slack
<rcurtin[m]> I submitted an email report to matrix.org about the Slack bridging issues, so hopefully there will be some progress there
<rcurtin[m]> if things go well I might see if I can get some help with the IRC bridge too 😃
<jonpsy[m]> > <@eshaanagarwal:matrix.org> Pls can you take a look at the PR whenever you're free ?... (full message at <https://libera.ems.host/_matrix/media/v3/download/libera.chat/bcacbcafe99aaff71b090e97c1968ac41b771e8c>)
<EshaanAgarwal[m]> jonpsy[m]: It isn't ! Hence I said that maybe we are wrong with our rewards thresholds or other parameters.
<jonpsy[m]> Sucks, I'll have a look saturday
<rcurtin[m]> coatless: here's a rebuilt tarball for 4.0.0 using the changes in your PR: https://github.com/mlpack/mlpack/actions/runs/3330319567#artifacts
<coatless[m]> rcurtin: still getting a tarball with 4.0.1
<coatless[m]> On expansion goes to be: mlpack_4.0.1.tar.gz
<rcurtin[m]> yeah, you're right ... I wonder what I did wrong? hang on...
<zoq[m]> <jonpsy[m]> "Sucks, I'll have a look saturday" <- Taking a look at it right now.
_slack_mlpack_10 has joined #mlpack
<rcurtin[m]> coatless: this one seems to have built properly: https://github.com/mlpack/mlpack/actions/runs/3331302683#artifacts
<coatless[m]> rcurtin: thanks! I'm going to submit an update via CRAN's form. Could you click the submit link that is sent to your e-mail?
<rcurtin[m]> absolutely, will do so once I see it :)
<rcurtin[m]> let me know once you have that tarball, because I'd like to delete the branch (it's not necessary for anything other than getting that tarball)
<coatless[m]> rcurtin: Should be golden now :)
<rcurtin[m]> sweet, extraneous branches removed
<rcurtin[m]> and CRAN submission confirmation done
<coatless[m]> Excellent. Should be live by the end of the day. That'll kick start more conda packaging updates.
<rcurtin[m]> yeah, I am already debugging the regular mlpack conda package, so probably some similar changes will need to be made for the R mlpack package
<rcurtin[m]> I forgot just how much work propagating a release to all the distribution channels is 😃
<coatless[m]> I'll have cycles to help on Friday if you don't solve it by then :)
<coatless[m]> Yeah, and it is only going to get worse... c.f. XKCD standards https://xkcd.com/927/
<rcurtin[m]> yeah, I don't think that you are wrong... sigh
<birm[m]> What help might you need? I'm procrastinating an especially boring task today
<rcurtin[m]> I actually have almost every build working successfully, but I am just waiting on the build results to finish. The only package that I am not currently touching is Debian, and I can't, because I'm not a Debian maintainer. But I did send an email to Barak Pearlmutter, who is the Debian maintainer :)