ChanServ changed the topic of #mlpack to: "mlpack: a fast, flexible machine learning library :: We don't always respond instantly, but we will respond; please be patient :: Logs at http://www.mlpack.org/irc/
UmarJ has quit [Ping timeout: 240 seconds]
UmarJ has joined #mlpack
UmarJ has quit [Ping timeout: 272 seconds]
< kartikdutt18Gitt>
Hi @birm, Yes currently there 2 similar PR open and since one of them was about a year old with no recent commits, I sent another PR as I think I made more headway.
< kartikdutt18Gitt>
*thought
ayush29 has quit [Quit: Connection closed for inactivity]
ImQ009 has joined #mlpack
LakshyaOjhaGitte has joined #mlpack
< LakshyaOjhaGitte>
Hi Everyone , I am Lakshya Ojha and I am currently a 3rd Year undergrad student at Delhi Technological University. I have been going through the code base for the couple of weeks and I would love to contribute to this organization.
< Param-29Gitter[m>
Hello , I have made some changes in the codebase and i want to validate it before opening a PR. how do I do that..?
< HimanshuPathakGi>
First you should try to build your changes
< Param-29Gitter[m>
using make and make install?
< HimanshuPathakGi>
locally
< HimanshuPathakGi>
yse
< HimanshuPathakGi>
*yes
< Param-29Gitter[m>
and is there a way to make a single file?
< HimanshuPathakGi>
You can skip building tests and cli and binding etc
< HimanshuPathakGi>
But building single file is not possible
< Nakul[m]>
> and is there a way to make a single file?
< Nakul[m]>
you can do something like ```make your target```
< HimanshuPathakGi>
(edited) But building single file is not possible => You can skip building tests and cli and python binding etc
< Param-29Gitter[m>
@matrixbot so will make filename.hpp work?
< Nakul[m]>
no in cmake you set your target and only that target you can make .
< Nakul[m]>
can you tell where you made changes
< Param-29Gitter[m>
in gini_gain.hpp
< Nakul[m]>
i can't find target for this.ther is target for decision tree but not for this zoq i think for new cmake we should also consider to add target for all of the missing files
< Param-29Gitter[m>
I ran make and sudo make install command to re-install mlpack. also what does bin/mlpack_test does? @matrixbot
< Nakul[m]>
It builds all the tests file
< Nakul[m]>
It will run all tests I will suggest you to run only those test that you have changed
< Param-29Gitter[m>
So how should i check if the changes i made to the code actually work fine?
< Nakul[m]>
Something like ```bin/mlpack_test -t your test suits```
< Param-29Gitter[m>
so for gini-gain (bin/mlpack_test -t mlpack_decision_tree) ?
< Nakul[m]>
the name of test suits you can find in test files
< Param-29Gitter[m>
i didnt understand. where will i find name of test suits?
< Nakul[m]>
you can see decision_tree_test.cpp where you file find ```BOOST_AUTO_TEST_SUITE`` by running this you will run all the test. if you want just some cases to run you can mention by like ```bin/mlpack_test -t DecisionTreeTest/GiniGainPerfectTest```
< Nakul[m]>
i would suggest to spend some time with boost documentation if you have more doubts : )
< Param-29Gitter[m>
Yes.. thanks :)
wiking has joined #mlpack
kyrre has joined #mlpack
kyrre has quit []
kyrre has joined #mlpack
UmarJ has joined #mlpack
wiking has quit [Quit: Leaving...]
kyrre has quit [Quit: Connection closed for inactivity]
< Nakul[m]>
Hey @rcurtin:matrix.org @zoq can we define some set of standard for cmake style I think we are missing that.or can you recommend some best style that we should follow?
< Nakul[m]>
I think following such kind of coding style is highly scalable.i mean define everything in its meta file keep different stuff in different files.