< Anand>
I will let you know if that doesn't solve the problem
< marcus_zoq>
Thanks!
< naywhayare>
Anand: sounds like a good plan
< Anand>
yep! :)
< naywhayare>
by the way, you could probably submit that makefile fix to Marcus as a pull request if you weren't already planning to
< naywhayare>
marcus_zoq: in case Anand didn't already mention it to you, the Makefile appears to look for python 3.2 but python 3.3 is required for subprocess's TimeoutExpired exception type (or at least it seems that way to me)
< Anand>
he said 3.2 is not the problem
< naywhayare>
no? then I am wrong I suppose :)
< Anand>
yes, seems like that!
< marcus_zoq>
Okay, thats weird, I thought I use python3.2 to test the benchmarks
< naywhayare>
python3.3 is what's on shoeshine, but I thought I remembered using python3.2 also, so I got confused
< Anand>
if shoeshine has 3.3, where could you have used 3.2?
< naywhayare>
I think I was using 3.2 on my desktop system; I didn't always test on shoeshine
< marcus_zoq>
right
< Anand>
ok
< Anand>
so the current Makefile checks for >=3.2 ??
< marcus_zoq>
Ah, I found a machine with python3.2, its a rpi but lets check
< marcus_zoq>
yeah, the current Makefile checks for python >= 3.2
< naywhayare>
line 12
< naywhayare>
(and lines 126 through 130)
< Anand>
right!
< marcus_zoq>
Okay, the timeout function was added in version 3.3. My fault, sorry for the confusion.
< Anand>
alright!
< Anand>
so we will make it >=3.3 in the makefile then
< naywhayare>
yeah, but don't forget to update the error message in lines 126-130 and also the opening stanza of the makefile that tries to set PYTHON_BIN to python3.2
< Anand>
yeah!
< Anand>
I will push the change
< marcus_zoq>
It's line 171 and 2 in the current version.
< naywhayare>
oops, sorry
< naywhayare>
oh! I see. I have my own branched version of the benchmarks code, and I haven't kept it up to date
< naywhayare>
I am still learning git :)
< Anand>
:P
< Anand>
I have made the changes!
< Anand>
Ok. I will rebuild mlpack and tell you. i will go for now! Thanks a lot! Bye! :)