<freemangordon>
dsc_: while on it, please, please, for the life of the kittens, do not use 'auto' unless strictly necessary
<freemangordon>
also, instead of using isNull() on shared pointers, there should be operator bool, i.e. if (!shared_pre.isNull()) {} can be done as if (shared_ptr) {}
<freemangordon>
umm, sorry for the typo, I meant "if (!shared_ptr.isNull()) {} can be done as if (shared_ptr) {}"
<freemangordon>
why ConfigState() class, instead of just using QSettings? with QSettings you can store QVariant, and you can put there whatever structure you may need
<freemangordon>
never use raw pointers as keys or whatever
<freemangordon>
make that list map
<freemangordon>
or use local_id or remote_id something when iterating
System_Error has quit [Ping timeout: 260 seconds]
uvos has joined #maemo-leste
System_Error has joined #maemo-leste
uvos__ has joined #maemo-leste
ceene has joined #maemo-leste
akossh has joined #maemo-leste
Livio has joined #maemo-leste
uvos__ has quit [Ping timeout: 264 seconds]
amunizp has joined #maemo-leste
Livio has quit [Ping timeout: 255 seconds]
uvos__ has joined #maemo-leste
fab_ has joined #maemo-leste
System_Error has quit [Remote host closed the connection]
System_Error has joined #maemo-leste
pere has quit [Ping timeout: 255 seconds]
<Wizzup>
freemangordon: what is wrong with 'auto' ?
<freemangordon>
code becomes unreadable
<freemangordon>
so, unless it is lamda, auto *must* not be used in my book
<freemangordon>
maybe there is one more legitimate use case, but I can't remember
<freemangordon>
if we are to use auto, why not just switch to js and call it a day?
<Wizzup>
I mean fair enough I guess
<freemangordon>
umm, can't parse :)
<uvos__>
sometimes deeply nested templateing can make it really undesirable to list the type more than once
<uvos__>
but ofc your working a larger problem with auto there
<freemangordon>
right, that was the other use case
<uvos__>
*working around
<freemangordon>
:nod:
<freemangordon>
you'd better have typedef-ed that
<freemangordon>
but yeah, if it is very long type, auto is fine I guess
<uvos__>
but yeah i dont like "auto item = getItem(local_uid, remote_id);" either
<uvos__>
since now i have to go figure out what getItem returns
<freemangordon>
exactly
<uvos__>
feals like python xD
<uvos__>
who-knows-what-this-is
<freemangordon>
== "unreadable code"
pere has joined #maemo-leste
Gary_812 has joined #maemo-leste
Gary812 has quit [Ping timeout: 264 seconds]
<Wizzup>
our user guide, shall we host it on maedevu.maemo.org or somewhere else
* unic0rn
lurks out, shivers, hides back and hugs his tcl/tk
<Wizzup>
leste.maemo.org is an option but it's a wiki too
<Wizzup>
freemangordon: so for debugging audio issues with sofiasip I guess we have: voicecall-manager, telepathy-rakia, various gst dependencies/components, pulseaudio, and the different sip settings?
amunizp has quit [Ping timeout: 272 seconds]
<Wizzup>
and I guess farstream is in voicecall-manager
<freemangordon>
Wizzup: I have absolutely NFC how all this is supposed to work
<Wizzup>
freemangordon: ok, so we're in the same boat then
Wikiwide has quit [Ping timeout: 255 seconds]
nela has quit [Quit: bye]
nela has joined #maemo-leste
<dsc_>
freemangordon> umm, sorry for the typo, I meant "if (!shared_ptr.isNull()) {} can be done as if (shared_ptr) {}"
<dsc_>
^-- I did that but didnt work hence I used isNull()
<dsc_>
freemangordon> why ConfigState() class, instead of just using QSettings?
<dsc_>
^-- because I want to write state.json which is a file that can be hand-edited, based on an earlier request by Wizzup
<dsc_>
< freemangordon> ugh, no, this is a recipe for disaster
<dsc_>
^-- your link is broken, I dont know what you a referring to
<dsc_>
your reaction makes it seem like this code is terrible, which it is not. I will refrain from posting WIPs to you.
<dsc_>
i shared it to share the general architecture
<dsc_>
and ill use `auto` whenever I want ;)
<dsc_>
< freemangordon> there is QStandardPaths::ConfigLocation and QStandardPaths::GenericConfigLocation
<dsc_>
why even mention this, this code is about Tp, I am well aware aboug XDG paths, you want me to fix everything in one commit? :P
Wikiwide has quit [Remote host closed the connection]
Wikiwide has joined #maemo-leste
<dsc_>
we've had this forever, and yes its bad, ill do something about it
OGary has joined #maemo-leste
Gary_812 has quit [Ping timeout: 268 seconds]
<inky>
if today anyone would like to help me to install maemo on mz617, i think i can concentrate on it in nearest hours.
leste has joined #maemo-leste
<Wizzup>
there's no documentation yet, so don't brick it
<Wizzup>
like I said, I am working on it, I likely won't be able to help if you brick it by doing it before we have documentation
<Wizzup>
also you need the -experimental kernel for it to boot and the current images do not have this
<freemangordon>
dsc_: sorry, got a call
<freemangordon>
yes, this one QList<TelepathyAccount*> accounts;
stlucas__ has joined #maemo-leste
<freemangordon>
dsc_: again re auto - ofc I cannot tell you how to code, but, most-probably at some point I'll change all autos to proper types
ceene has quit [Ping timeout: 252 seconds]
<freemangordon>
using auto for bool ...
pere has quit [Ping timeout: 255 seconds]
<freemangordon>
a side note - I was thinking you have been long enough in BG so there is no need for me to be politically correct. Obliviously that's not the case, so I'll watch my tone more strictly for the future.
<dsc_>
hehe
<freemangordon>
no, really, I was kind of surprised by your reaction, however, I'll watch my comments
<dsc_>
> The main purpose of Requests_Satisfied is matching up channels you're being asked to handle with either requests you started (if you create/ensure channels), or channels whose channel request you were previously asked to approve (if you're an Observer or Approver)
<dsc_>
> If you're doing either of those, you have a TpChannelRequest already, it's probably already prepared too, and all you need to do is match it by object path or by object identity, for instance looking it up in a hash table { channel request => chat window }.
<dsc_>
sounds like `Requests_Satisfied` is a way to make sure handleChannels is only handling the channels it previously requested (in the case there are multiple observers)
uvos__ has quit [Ping timeout: 272 seconds]
uvos__ has joined #maemo-leste
<Wizzup>
dsc_: what about ensuring that a channel doesn't already exist
Gary_812 has joined #maemo-leste
OGary has quit [Ping timeout: 268 seconds]
Madda has quit [Ping timeout: 256 seconds]
OGary has joined #maemo-leste
<dsc_>
Wizzup: channels are unique on TargetID (remote_uid in practice)
<dsc_>
and we're only handling TextChannels at this point
Gary_812 has quit [Ping timeout: 268 seconds]
Madda has joined #maemo-leste
leste has joined #maemo-leste
System_Error has quit [Remote host closed the connection]
System_Error has joined #maemo-leste
mdz has quit [Ping timeout: 264 seconds]
System_Error has quit [Remote host closed the connection]
<Wizzup>
freemangordon: just for the record the repo I made on github might not be 'official' one atm so I am not sure if the guy will see it but I will let him know
<Wizzup>
brtw
<Wizzup>
btw
<Wizzup>
apt install maemo-user-guide
<freemangordon>
ok
<freemangordon>
I just closed the issue anyways
<Wizzup>
I will update hildon-desktop's user-guide.desktop now