11:14 <acathla> I have a new Lattice ice40up5k evn board and LiteX hangs during boot. I tried different CPU/git versions. With tag 2022.12, il boots, and hangs after "Initializing N25Q032A SPI Flash @0x00400000... Enabling Quad mode..."

11:16 <acathla> It's a new flash MX25L3233F that is not yet available. And it's not wired to be available in 4x. I tried a different flash MX25L3235D, but it does the same. I'm not even sure the problem is with the flash...

11:16 <tnt> Well is you soc configured to not use it in quad mode ?

12:18 <acathla> tnt, the platform does not include "spiflash4x" so I guessed it could not switch to 4x automatically

12:36 <zyp> acathla, the check only checks if the module itself has a quad read command

12:36 <zyp> https://github.com/enjoy-digital/litex/blob/master/litex/soc/software/liblitespi/spiflash.c#L115

12:37 <zyp> the define comes from here: https://github.com/enjoy-digital/litex/blob/master/litex/soc/integration/soc.py#L1776

12:37 <acathla> ah, there is a #define SPIFLASH_MODULE_QUAD_CAPABLE but it's defined by the flash module, not the platform :(

12:38 <zyp> easiest way to disable it without patching litex is probably to provide a flash module description without the READ_1_1_4 command

12:38 <acathla> I just found that. Is there a del_constant?

12:39 <zyp> you could probably do something like «del soc.constants['SPIFLASH_MODULE_QUAD_CAPABLE']»

13:14 <acathla> zyp, fake flash module works fine, thanks for the idea. del soc.constants does not work, or I put it at the wrong place.

13:16 <acathla> if SpiNorFlashOpCodes.READ_1_1_4 in module.supported_opcodes and mode == "4x":

13:17 <acathla> that fix in https://github.com/enjoy-digital/litex/blob/master/litex/soc/integration/soc.py#L1776 seems to work

13:40 <zyp> I'm also not entirely sure the quad enable bit is in the same place in every flash module, I suspect that code might actually only work for some particular modules