<diederik>
In f.e. rk3568_vop2_setup_layer_mixer I see references to rk3588 fields which I find odd. If a function is to be used by non-rk356x SoCs, then I would expect a more generic name (like vop2)
<diederik>
There are more such instances, but seeing rk3568 fields in functions with rk3588 in its function name or vice versa is confusing (there are no comments which make it clear this is intended and not a typo)
<diederik>
But I don't actually/really understand the code and it may be crystal clear to people who do.
<diederik>
Is it worth raising that issue or would I be wasting everyones time with that?
tlwoerner has quit [Quit: Leaving]
tlwoerner has joined #linux-rockchip
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
crabbedhaloablut has quit []
<diederik>
nvm; PEBKAC :)
alpernebbi has quit [Ping timeout: 265 seconds]
vagrantc has joined #linux-rockchip
alpernebbi has joined #linux-rockchip
UndrWater has quit [Quit: ZNC 1.8.2+deb2ubuntu0.1 - https://znc.in]
UndrWater has joined #linux-rockchip
System_Error has quit [Remote host closed the connection]
System_Error has joined #linux-rockchip
stikonas has joined #linux-rockchip
naoki has joined #linux-rockchip
raster has quit [Quit: Gettin' stinky!]
psydroid has quit [Read error: Connection reset by peer]
psydroid has joined #linux-rockchip
franoosh has quit [Remote host closed the connection]
ldevulder has quit [Quit: Leaving]
System_Error has quit [Remote host closed the connection]
System_Error has joined #linux-rockchip
<mmind00>
diederik: I assume with PEBKAC you mean you sorted your thoughts from above to see that all is well?