jacobk has joined #linux-amlogic
Danct12 has joined #linux-amlogic
Daanct12 has joined #linux-amlogic
Daaanct12 has quit [Ping timeout: 256 seconds]
Daanct12 has quit [Remote host closed the connection]
Daanct12 has joined #linux-amlogic
hexdump0815 has quit [Ping timeout: 268 seconds]
hexdump0815 has joined #linux-amlogic
buzzmarshall has quit [Quit: Konversation terminated!]
jacobk has quit [Ping timeout: 250 seconds]
jacobk has joined #linux-amlogic
jacobk has quit [Ping timeout: 240 seconds]
paddymahoney has quit [Remote host closed the connection]
f_ has joined #linux-amlogic
f_ has quit [Client Quit]
f_ has joined #linux-amlogic
hexdump0815 has quit [Quit: WeeChat 1.9.1]
<
f_>
Preparing to send a patch to U-Boot!
<
f_>
Soon mainline U-Boot will have support for the KII Pro! \o/
<
exkcmoeAdmin[m]>
:)
<
f_>
I'll just let anyone here review what I have done before I send the patch.
<
f_>
chewitt (logs...), narmstrong ↑ have I done it right?
<
f_>
Will disconnect now.
f_ has quit [Ping timeout: 240 seconds]
elastic_dog has quit [Ping timeout: 250 seconds]
elastic_1 has joined #linux-amlogic
elastic_1 is now known as elastic_dog
camus has quit [Quit: camus]
camus has joined #linux-amlogic
Danct12 has quit [Quit: WeeChat 3.8]
camus has quit [Quit: camus]
Daaanct12 has joined #linux-amlogic
elastic_1 has joined #linux-amlogic
elastic_dog is now known as Guest9837
elastic_1 is now known as elastic_dog
Daanct12 has quit [Read error: Connection reset by peer]
chewitt has joined #linux-amlogic
<
chewitt>
@f_ I'd flag a couple of minor things before u-boot submission
<
chewitt>
in the dts commit message reference the linux version you've imported the dts from, e.g. LInux 6.3 or Linux 6.4-rc1
<
chewitt>
in the defconfig description, just state the config is cloned from WP2
f_ has joined #linux-amlogic
<
f_>
chewitt: Sure.
<
chewitt>
I would change CONFIG_IDENT_STRING to be "kii-pro" else you occupy half the width of a low-res tty console with branding
<
chewitt>
otherwise I assume you did just c/p the WP2 config to start from?
<
chewitt>
(and didn't change anything in the dts)
<
f_>
chewitt: Eh..The DTS is only on linux master it seems.
<
chewitt>
you should only be copying from linux/master .. or perhaps the linux-amlogic tree if there are any changes queued for v.next
<
chewitt>
in documentation I notice a lack of spaces after the code blocks, e.g. comparing to
<
f_>
chewitt: But I'm copying from linux/master..
<
chewitt>
that's fine .. but linux/master is associated with a release or pending release
* f_
checks Makefile
<
f_>
chewitt: Are there other changes you want me to make??
<
chewitt>
nothing that I can notice ..
<
f_>
Thanks for the tip about BL2 BTW. Seems like Amlogic's BL2 is indeed based on TF-A.
<
chewitt>
it is, but I would expect it to have been modified due to deliberate obfuscation since that commit
<
chewitt>
and based on the rest of the BSP, also due to 'coding style'
<
chewitt>
aka, when there's no peer oversight on your code all your hacks look brilliant
<
f_>
Yeah. There also seems to be a licensing issue.
<
chewitt>
pick your battles
<
f_>
First, I think it won't be possible at all to port all their changes, because they licensed all files added under the GPLv3!
<
f_>
And second, due to their changes being licensed under the GPLv3, I suspect they violated the license by making it all proprietary.
<
chewitt>
something genuinely useful would be retro-fitting gxbb signing support to gxlimg
<
f_>
No idea how that could be helpful. amlbootsig already works nicely.
<
chewitt>
as much as at-f support would be great, I suspect there's too much missing to ever make it reliable
<
f_>
I use TF-A's BL31 and it works very well.
<
chewitt>
because as a distro maintainer I would like to do signing with ONE tool not two .. it makes buildsystems easier
<
chewitt>
if you only care about one board, anything that works is great
<
f_>
Maybe also because meson-tools is unmaintained now, right?
<
chewitt>
if you care about 45+ boards, the challenge is different
<
chewitt>
the original author might dispute unmaintained, but regardless 'a' tool would be desirable
<
f_>
I could add (very) basic support and then handle anything board-specific somewhere else.
<
f_>
chewitt: Understandable.
<
chewitt>
same for the aml_cksum binary.. if that can be absorbed into the same process, would be nice
<
f_>
Even though I like the approach of having one tool do one thing well.
<
f_>
Maybe we could separate gxlimg into multiple utilities and then have an option to combine them all into one?
<
chewitt>
unless you fancy being stonewalled by Amlogic lawyers I'd focus on writing replacement code not disputing what they did wrong c.2011
<
chewitt>
rightly or wrongly it'll be more productive :)
<
f_>
Me too. Their code sucks anyway.
<
f_>
I do know for sure we'd need to handle anything timing-related elsewhere, too.
<
chewitt>
other SoCs seem to handle ram-timing in code, but not Amlogic
<
chewitt>
e.g. Allwinner
<
chewitt>
(see 'crust' codebase)
<
chewitt>
I suspect the ram timing challenge is solvable, but that still requires someone to write the solving code
<
chewitt>
all volunteers, one pace forwards!
* chewitt
steps backwards
<
chewitt>
anyway.. I'm off to a coronation BBQ in the 'pissing with rain' English weather
<
chewitt>
au revoir for now..
chewitt has quit [Quit: Zzz..]
naoki has joined #linux-amlogic
naoki has quit [Client Quit]
jacobk has joined #linux-amlogic
<
f_>
Will send those patches now.
jacobk has quit [Ping timeout: 276 seconds]
<
f_>
So.....should I send my patch directly to the U-Boot mailing list, or do I need to Cc some other people?
<
exkcmoeAdmin[m]>
yes
<
f_>
git send-email --from=... --to=u-boot@lists.denx.de *.patch ??
<
exkcmoeAdmin[m]>
yes
<
f_>
>Is being held until the list moderator can review it for approval.
<
exkcmoeAdmin[m]>
yes wait for it
JerryXiao has quit [Ping timeout: 240 seconds]
JerryXiao has joined #linux-amlogic
f_ has quit [Quit: Lost terminal]
buzzmarshall has joined #linux-amlogic
mdrjr has joined #linux-amlogic
vagrantc has joined #linux-amlogic
orkid has quit [Ping timeout: 265 seconds]
jacobk has joined #linux-amlogic
orkid has joined #linux-amlogic
jacobk has quit [*.net *.split]
mdrjr has quit [*.net *.split]
anessen97 has quit [*.net *.split]
wens has quit [*.net *.split]
dlan has quit [*.net *.split]
wens has joined #linux-amlogic
dlan has joined #linux-amlogic
anessen97 has joined #linux-amlogic
dlan has joined #linux-amlogic
dlan has quit [Changing host]
jacobk has joined #linux-amlogic
mdrjr has joined #linux-amlogic