06:59
drbobbeaty has quit [Remote host closed the connection]
07:00
drbobbeaty has joined #jruby
08:49
drbobbeaty_ has joined #jruby
08:53
drbobbeaty has quit [Ping timeout: 256 seconds]
09:18
PavanNambi[m] has quit [Remote host closed the connection]
10:01
skumarg[m] has quit [Remote host closed the connection]
14:57
AlenSebastian[m] has joined #jruby
17:19
<
headius >
enebo: let me know when joni release is out and I can update the PR I made for it
17:20
<
headius >
I'm fixing dependency thing on jnr branch and then I'll merge it and fix the irb test thing
17:30
<
headius >
PRs are down, I just noticed it myself because jnr update PR did not see my push
17:37
<
headius >
yeesh, lots of stuff breaking on GH now
17:40
<
enebo[m] >
my git-commit doing release:prepare is failing
17:41
<
enebo[m] >
It could be pushing but I half feel this is unrelated
17:41
<
enebo[m] >
[ERROR] /bin/sh: _module_raw: line 1: syntax error: unexpected end of file
17:45
<
enebo[m] >
headius: can you release joni from head right now?
17:45
<
enebo[m] >
I think something with bash + FC is messing up the scripting
17:45
<
enebo[m] >
I am only using this laptop another week or so and don't want to deal with this
17:46
<
headius >
enebo: sure
17:46
<
enebo[m] >
I merged so it should be good to go
17:46
<
headius >
not sure what to do about these PRs lagging right now
17:47
<
enebo[m] >
you mean actions?
17:47
<
headius >
enebo: 92d391e5625bf2b113f150a26b322b438234b2b9?
17:48
<
headius >
according to the status, PRs are slow, webhooks are slow, actions are slow
17:48
<
headius >
so it's not even running my PR to update irb tests and did not see my force push to jnr
17:48
<
enebo[m] >
ok. yeah that one
17:48
<
enebo[m] >
if you diff you will see Java 8 and the backoff fix to not use fast //i search
17:49
<
enebo[m] >
I think lopex has realized that the logic in the method is wrong and picking fast in cases it shouldn't
17:49
<
enebo[m] >
but it is something which will get figured out later
17:49
<
headius >
yeah funny that IOOBE did not have a numeric constructor
17:49
<
enebo[m] >
no doubt message on 8 will just be "1" :)
17:50
<
enebo[m] >
newer API probably builds a nicer string but it is pretty obvious what 1 means with IIOBE
17:51
<
headius >
just pushed the release button on sonatype
17:52
<
enebo[m] >
I was like ok not much output it must be fixed
17:53
<
enebo[m] >
looks like rake just exited?
17:54
<
enebo[m] >
/home/runner/work/jruby/jruby/lib/ruby/stdlib/irb/workspace.rb:93: warning: previous definition of exit was here
17:54
<
enebo[m] >
maybe tests are causing rake to exit
17:55
<
enebo[m] >
you may want to use runner locally just to rule out GHA being responsible
17:55
<
headius >
yeah that's odd
17:55
<
headius >
I will check on linux machine
17:59
<
headius >
ugh something in the tests does terminate the run
18:00
<
enebo[m] >
that warning could be a clue
18:00
<
enebo[m] >
since it is about exit
18:00
<
headius >
heh ya thing
18:00
<
headius >
yeah probably related
18:00
<
enebo[m] >
ya thing
18:00
<
headius >
make your bets on whether it's refinement related
18:14
<
headius >
there's a lot of failures in the new tests looking for specifically CRuby's load path layout
18:17
<
enebo[m] >
just assuming index of X for test or something more behavioral?
18:20
<
headius >
literally trying to match how CRuby does stdlib path
18:20
<
headius >
[ 21/231] TestIRB::LocaleTestCase#test_find = 0.02 s
18:20
<
headius >
TestIRB::LocaleTestCase#test_find [/home/headius/work/jruby/test/mri/irb/test_locale.rb:111]:
18:20
<
headius >
7) Failure:
18:20
<
headius >
Expected "/home/headius/work/jruby/lib/ruby/stdlib/irb/lc/ja/error.rb" to include "/lib/irb/lc/ja/error.rb".
18:20
<
headius >
there's several of these
18:20
<
enebo[m] >
stdlib has an rbconfig value or no?
18:27
<
headius >
I don't think so
18:27
<
headius >
it could capture the path of irb.rb at load though and use that to infer other paths
18:27
<
headius >
the tests need to be fixed though
18:28
<
headius >
I pushed updated excludes for the 15 "new" failures (some were renamed or respelled) but there's still some seeds that lead to early exit
18:28
<
enebo[m] >
I was poking but I see nothing
18:28
<
headius >
going to try to catch that
18:29
<
enebo[m] >
feels like an oversight but ultimately the test should test if that is anywhere in loadpath
18:34
<
headius >
narrowed down to test_ruby_lex that seems to be terminating early
18:43
<
headius >
ok I haven't narrowed anything down
18:43
<
headius >
something this is setting up early in testing is terminating things later
18:50
<
headius >
ok I have a lead
18:50
<
headius >
I think something in did_you_mean is triggering and causing a stack overflow
18:50
<
headius >
like a method is missing and then DYM tries to do its thing but the method is missing so it raises again
18:50
<
headius >
that eventually bubbles out and the stack overflow is swallowed and it exits
18:51
<
enebo[m] >
I saw the respond_to_missing? missing from BasicObject...that was in earlier run before it exited
19:02
<
headius >
enebo: I know we are under a time crunch here so I propose two options
19:02
<
headius >
I can roll back IRB and try to get a version that does not have tests that terminate our run, or not update it at all and hope it works with newer reline
19:02
<
headius >
I can also just remove irb tests from stdlib testing and we fix this after release
19:03
<
headius >
it seems to be just a test thing
19:03
<
enebo[m] >
I think we could try this combo of irb+reline informally and see if they work on linux and windows
19:03
<
headius >
it was failing but not terminating with old tests so I am assuming something in new tests is hitting a bad spot for us
19:03
<
enebo[m] >
I do always try and start it using cmoplete on windows too
19:04
<
enebo[m] >
as it stands windows gets that TSPC signal crap which was fixed
19:04
<
headius >
it looks fine to me on Linux
19:04
<
headius >
yeah and that was in reline yes?
19:04
<
enebo[m] >
I think so
19:05
<
headius >
I have had runs of IRB tests complete too so it's something with particular sequence of tests that causes it to bail all the way out
19:05
<
headius >
I see it execute the last "exit" in runner.rb so it bubbles out weirdly
19:05
<
headius >
silently terminates the test run
19:06
<
enebo[m] >
so we could try and roll with irb + reline or just update reline and leave irb for next point
19:06
<
headius >
that's about the size of it
19:06
<
enebo[m] >
reline update is likely safer since it is just a few point releases and we are using first in a major
19:06
<
headius >
FWIW this is way ahead of 3.1's default IRB but we were already ahead
19:06
<
enebo[m] >
yeah let's just reline and I will make sure I can run it
19:07
<
enebo[m] >
we know M1 is not working
19:07
<
headius >
I can roll back to CRuby 3.1.4 version of IRB or whatever we had before, whichever is newer
19:07
<
headius >
I will ditch this IRB test PR for now then and make one to roll back IRB
19:35
<
headius >
ok pushing PR in a moment
19:37
<
headius >
actually nevermind... I'll just do 1.4.2 rather than try to wrestle with any test changes from 1.4.3
19:37
<
enebo[m] >
A lot of changes
19:37
<
headius >
we'll do a proper update after release
19:37
<
headius >
3.1.4 is still on 1.4.1 so we're already ahead on that one
19:40
<
headius >
JNR PR was down to just IRB failures so I merged it
19:41
<
enebo[m] >
likely we use 1.7 for next release and not 1.4.3. but I guess it depends on time spent to correct tests
19:41
<
headius >
are you pushing joni update or shall I?
19:41
<
enebo[m] >
I get that weird error
19:41
<
headius >
I mean updating JRuby... the release is out and should be propagated now
19:42
<
enebo[m] >
oh I see. you have a PR already for that right?
19:42
<
enebo[m] >
you just need to update that?
19:42
<
headius >
yeah I can do that
19:42
<
headius >
I'll update so it reflects 2.2.1
19:42
<
enebo[m] >
yeah that is fixed by this joni release
19:42
<
enebo[m] >
I marked it 9.4.3.0 earlier
19:43
<
enebo[m] >
That issue was the final nail for needing something changed since it was 2 more people
19:44
<
headius >
yeah good to get it in this release
19:44
<
enebo[m] >
this should not affect log4j since that was no //i
19:44
<
enebo[m] >
and //i being slow again is ok since it was slow for more than a year except for last point release
20:01
<
enebo[m] >
I think there may be other errors from updating but none look important
20:01
<
headius >
there are
20:01
<
headius >
I'm looking into updating those tests, probably tests added for fixes in these minor releases
20:02
<
headius >
some of these may have cve updates so I'd like to keep them
20:02
<
enebo[m] >
ENVIRONMENT_VARIABLE_IS_MULTIUSER_SAFE this is the only one I wonder about
20:03
<
enebo[m] >
that test open BADF has been happening for a while
20:03
<
headius >
I'm on it.. there's only a few
20:03
<
headius >
silly me thinking I could update these without tests
20:07
<
headius >
updating tests is looking pretty clean
20:13
<
headius >
oops pushed test updates and excludes to master
20:14
<
headius >
I will merge irb thing because that is no longer failing tests
20:19
<
headius >
that's the job to watch.. joni merged, updated tests and excludes, and irb downgrade all on master now
20:20
<
enebo[m] >
once merged I will spin and start testing
20:52
<
headius >
enebo: that build was completely green
20:53
<
enebo[m] >
yeah I am spinning now
20:53
<
enebo[m] >
perhaps write some release notes optimistically :)
20:58
<
headius >
I'll get on that
21:06
<
headius >
enebo: you have that issue list for me
21:07
<
enebo[m] >
oh I can make it but I think I need to re-review whether all things were marked
21:26
<
enebo[m] >
headius: looks good
21:26
<
enebo[m] >
windows irb is "weird" but it is just tab completion of tokens is displaying oddly
21:26
<
headius >
notes coming along
21:26
<
headius >
lots of small fixes
21:26
<
enebo[m] >
I think the workaround on that is to disable completion or use swing irb
21:27
<
enebo[m] >
but perhaps newer irb will fix that
21:27
<
enebo[m] >
in any case it is better than what is was
21:27
<
enebo[m] >
I am going to finalize maven and push gem now
21:40
<
headius >
I did not see a lot of other multi-issue/multi-PR major items
21:40
<
enebo[m] >
yeah I think a lot of small fixes for things like ripper crashing irb
21:41
<
enebo[m] >
the regexp fix (or unfix for //i)
21:41
<
enebo[m] >
doesn't matter too much
21:42
<
enebo[m] >
ok looks like it is up on maven
21:48
<
enebo[m] >
headius: going to push site. Can you do the tweet/toot/social + image thingies you have been doing
21:48
<
enebo[m] >
I will do GH release and update GH
21:54
<
enebo[m] >
yikes web site is taking a while
21:56
<
enebo[m] >
ok website is propd
21:57
enebo has joined #jruby
22:00
enebo has left #jruby [#jruby]
22:04
<
headius >
I'll start doing my wrap up checklist
22:20
<
enebo[m] >
headius: I believe I am done with the items I typically do
22:20
<
enebo[m] >
message me on telegram if you need me
22:20
<
headius >
enebo: no problem
22:20
<
headius >
installers are updated, socials are posted, just doing docker now
22:21
<
enebo[m] >
cool cool