subbu has joined #jruby
subbu has quit [Quit: Leaving]
<edipofederle[m]> Morning all,
<edipofederle[m]> enebo: when you have some time, could you please take a look at this one: ? thanks!
<enebo[m]> edipo.federle: It defintiely is making an ArithmediSequence now but have you checked to see if it is still iterating properly?
<enebo[m]> I need to get some more CI jobs hooked up since travis dropped our OSS accuont
<edipofederle[m]> enebo[m]: Actually no, Do you think we need add some test/spec for it ? could you please guide-me here?
<enebo[m]> Possibly. If there are no tests for it
<enebo[m]> I can see test:mri does look for ArithmeticSequence as a type but let me see if there are any tests beyond that for beginless
<edipofederle[m]> right,
<enebo[m]> assert_kind_of(Enumerator::ArithmeticSequence, (..10).step(2))
<enebo[m]> I don't see any tests on this sequence working in MRI test suite
<enebo[m]> I am not sure I see any beginless range specs
<enebo[m]> well not in step_spec.rb at least
<enebo[m]> edipo.federle: for the sake of landing this we are already broken on having the right type so I will land your PR but if you could look at adding specs for how to use this it would be helpful for not only us but the other Ruby impls
<edipofederle[m]> sure, I am looking into it on ruby/spec
<enebo[m]> cool. I merged
<enebo[m]> I will see what changes in test_range.rb on MRI. 2F should go away just on the type check
<enebo[m]> I did not see any actual iteration but perhaps I missed something
<edipofederle[m]> I actually started already with: but not sure yet, I will continue there
<enebo[m]> yeah great
<enebo[m]> I am wondering how people use beginless with step
<enebo[m]> I would not think there is much to be done other than downto
<edipofederle[m]> true
<enebo[m]> which is not step :)
<edipofederle[m]> true story. well, thanks for now so.
<enebo[m]> HAH. Thanks for the PR too :)
nirvdrum has joined #jruby
nirvdrum[m] has joined #jruby
<nirvdrum[m]> lopex: I was playing around with optimizing compilation around encodings some more. I'm sure you've evaluated this, but it might be worth trying to find another way to set an encoding as being dummy. Since that happens after the encoding is created, both the `isDummy` and `isAsciiCompatible` fields can't be final. Dummy encodings are virtually unused in Ruby, so it's a bit annoying we have to take a performance hit to support them.
<nirvdrum[m]> I'm finally giving this Matrix thing a shot. I'm hoping it'll be easier to keep track of stuff while at RubyConf.
nirvdrum has quit [Ping timeout: 260 seconds]
richbridger has joined #jruby