<dnkl>
ahesford: I found a bug introduced with your resize-by-cells commit (git bisected)
<dnkl>
at work I have two monitors
<dnkl>
one with a scaling factor of 2, one with a scaling factor of 1
<dnkl>
if I start foot on the monitor with scale 2, all is good
<dnkl>
but when starting it on the other monitor, the window is incorrectly scaled to 2x
<dnkl>
this happens regardless of whether resize-by-cells is enabled or disabled
<dnkl>
it also corrects itself just by moving focus to another window
<dnkl>
alright, figured it out. The call to render_resize() from update_term_for_output_change() use the wrong scaling factor. I'll push a patch later today
<ahesford>
thanks for digging into that
NickH has quit [Ping timeout: 260 seconds]
<ahesford>
the dpi-aware changes to support resizing by cells gave me a hard time, and it made me really wish that we could just *ask* for the display scale instead of waiting for a scale event to arrive
<dnkl>
that, and having to support three variants of scaling events is difficult...
<dnkl>
hopefully we can get rid of legacy scaling in a not too far future
NickH has joined #foot
lbia has quit [Ping timeout: 260 seconds]
sentriz has quit [Ping timeout: 272 seconds]
sentriz has joined #foot
lbia has joined #foot
lbia1 has joined #foot
lbia has quit [Ping timeout: 264 seconds]
lbia1 has quit [Max SendQ exceeded]
lbia has joined #foot
lbia has quit [Max SendQ exceeded]
lbia has joined #foot
lbia has quit [Max SendQ exceeded]
lbia has joined #foot
lbia has quit [Ping timeout: 272 seconds]
lbia has joined #foot
lbia has quit [Ping timeout: 272 seconds]
lbia has joined #foot
uncomfy has joined #foot
uncomfy has quit [Remote host closed the connection]
uncomfy has joined #foot
uncomfy has quit [Remote host closed the connection]
lbia has quit [Ping timeout: 252 seconds]
lbia has joined #foot
uncomfy has joined #foot
uncomfy has quit [Remote host closed the connection]
uncomfy has joined #foot
uncomfy has quit [Remote host closed the connection]
uncomfy has joined #foot
uncomfy has quit [Remote host closed the connection]
uncomfy has joined #foot
uncomfy has quit [Remote host closed the connection]
lbia has quit [Ping timeout: 256 seconds]
lbia has joined #foot
uncomfy has joined #foot
uncomfy has quit [Remote host closed the connection]
uncomfy has joined #foot
uncomfy has quit [Remote host closed the connection]
lbia has quit [Ping timeout: 264 seconds]
uncomfy has joined #foot
uncomfy has quit [Remote host closed the connection]
lbia has joined #foot
lbia has quit [Ping timeout: 246 seconds]
narodnik has quit [Quit: WeeChat 4.2.1]
lbia has joined #foot
alexherbo2 has joined #foot
alexherbo2 has quit [Remote host closed the connection]
_whitelogger has joined #foot
sentriz has quit [Ping timeout: 272 seconds]
sentriz has joined #foot
sentriz has quit [Read error: Connection reset by peer]
<jpp>
Will the fix be in the next debian 12 bookworm updates?
<dnkl>
jpp: the regression was introduced on master just days ago; no release has had that bug
<jpp>
Ok, thanks.
cbb has joined #foot
<ahesford>
nice find
<ahesford>
that was a classic Chesterton's fence example
<ahesford>
I missed that term->scale was changed before render_resize and thought logical_{width,height} was unnecessary
<ahesford>
surprised the compiler isn't yelling about uint8_t -> enum resize_options though
<ahesford>
RESIZE_KEEP_GRID | RESIZE_FORCE isn't a valid enum
<ahesford>
hrm, I'm not sure how that patch actually changes behavior
<ahesford>
when RESIZE_KEEP_GRID is set, logical_width and logical_height should be ignored
<ahesford>
the only place RESIZE_KEEP_GRID isn't set is in xdg_surface_configure, which happens for me with labwc at least once during a display/scale change
<dnkl>
ahesford: it isn't ignored for non-floating windows
<dnkl>
with that said, I never tested floating windows
<ahesford>
oh, heh
<ahesford>
I almost never test on non-floating windows
<dnkl>
I'll try floating tomorrow
<ahesford>
seems to work fine with floating windows here, and the behavior shouldn't have changed anyway
sevz has quit [Quit: WeeChat 4.2.1]
sevz has joined #foot
alexherbo2 has quit [Remote host closed the connection]
alexherbo2 has joined #foot
<tommybomb>
dnkl: thank you
narodnik has joined #foot
lbia has quit [Ping timeout: 252 seconds]
lbia has joined #foot
alexherbo2 has quit [Remote host closed the connection]
alexherbo2 has joined #foot
alexherbo2 has quit [Remote host closed the connection]
alexherbo2 has joined #foot
cbb has quit [Quit: WeeChat 4.2.1]
sentriz has quit [Read error: Connection reset by peer]