dnkl changed the topic of #foot to: Foot - fast, lightweight and minimalistic Wayland terminal emulator || 1.12.1 || https://codeberg.org/dnkl/foot || channel logs: https://libera.irclog.whitequark.org/foot
c7s has joined #foot
cbb has joined #foot
cbb has quit [Ping timeout: 240 seconds]
cbb has joined #foot
<c7s> does `BUG in enter(): assertion failed: 'seat->kbd_focus != NULL'` look like a compositor bug? or, in general, what things should I look into as far as reproducing this, since I've got no idea what I was doing when this happened
emersion has quit [Remote host closed the connection]
emersion has joined #foot
<dnkl> c7s: really depends... may be either a compositor bug, or a bug in foot. Once you've figured out *why* seat->kbd_focus is NULL when you hit that assertion, it'll be easier to say whose fault it is
<dnkl> (kbd_focus is the terminal instance that currently has the seat's keyboard focus. NULL means no terminal window is focused by that seat)
<Arnavion> The enter() in ime.c ? If so the trigger might involve toggling / using your IME
<dnkl> if that's the one, I think I've seen it as well. think I even asked about it in #wayland (can ime enter() fire before a keyboard enter event), but never got a reply
<dnkl> might be possible to rewrite the ime logic to not depend on kbd_focus, and instead use an IME specific terminal instance pointer
<c7s> it's the ime.c one, yeah
<c7s> I forgot I actually had an ime running since I've still not figured out how to configure it, but it is there
<Arnavion> So if you can get a reliable repro, then running foot with WAYLAND_DEBUG=1 will let you capture the wayland traffic and confirm if it's what dnkl said
<c7s> yeah, not really much more to say until I can reproduce it
<c7s> thanks
<Arnavion> Which compositor and IME, BTW?
<c7s> sway and fcitx6
<c7s> 5*
<Arnavion> That does work fine for me, except that the preedit window doesn't show, which is a known thing
<Arnavion> Err, not the preedit window, the suggestions window
<dnkl> it (the assertion) doesn't trigger everytime
<dnkl> (which kind of suggests it's not intentional, on the compositor side)
rcf has quit [Quit: WeeChat 3.4.1]
<dnkl> Arnavion, c7s: so, the documentation does say the IME enter event follows the keyboard focus. That suggests we're seeing a compositor bug
<dnkl> however, it also says "when the seat has the keyboard capability..."
<dnkl> in other words, it's possible to recursive IME events on seats without the keyboard capability
<dnkl> in which case kbd_focus will always be NULL
<dnkl> I'm going to rewrite the logic to track IME focus independently. that should also workaround The compositor bug
<dnkl> s/recursive/receive
ptrc has quit [Remote host closed the connection]
ptrc has joined #foot
<c7s> so, it was probably NULL because of a compositor bug, but it turns out that's allowed anyway?
<dnkl> c7s: correct, that's how I interpret the documentation
<c7s> dnkl: ok, cool, thanks
rcf has joined #foot
rcf has quit [Client Quit]
rcf has joined #foot
rcf has quit [Client Quit]
rcf1 has joined #foot
rcf1 is now known as rcf
pranjhol has joined #foot
rapha has joined #foot
<rapha> hi all
<rapha> dnkl: if you say "zero" that doesn't sound like you'd be opposed to it, but like an underlying library is preventing it?
<dnkl> rapha: no, it's not because of a dependency (or lack of it), but just that it adds too much complexity
<rapha> dnkl: would it not be possible to branch off `if line.match /\p{Arabic}/` and then handle that line in a file called "rtl.ext", thereby keeping the rest of the code entirely unaffected?
<dnkl> no, there's *much* more to it than that
<rapha> there's things outside of the unit of a "line" affected by it?
<dnkl> more like, there's no line to begin with. it's not how terminals work
<rapha> oh
<rapha> do you think in pixels then?
<dnkl> no, but there's more to rtl in terminals than just reversing text on a line basis.
<dnkl> point is, it's not going to happen in foot
cbb has quit [Ping timeout: 240 seconds]
cbb has joined #foot
pranjhol has quit [Quit: Client closed]
<dnkl> c7s: Arnavion: if you're bored... feel free to give the IME PR a spin: https://codeberg.org/dnkl/foot/pulls/1087
rcf has quit [Ping timeout: 246 seconds]
<c7s> dnkl: thanks, I'll give it a go
rcf has joined #foot
cbb has quit [Quit: WeeChat 3.5]
<dnkl> thanks! I tested it on sway, with anthywl. But I don't use IME on a daily basis, so may have missed something
rcf has quit [Ping timeout: 255 seconds]
rcf has joined #foot
rcf has quit [Ping timeout: 246 seconds]
rcf has joined #foot
rcf has quit [Client Quit]
rcf has joined #foot
an3223 has quit [Remote host closed the connection]
an3223 has joined #foot
<Arnavion> dnkl: Still works fine for me on top of 1.12.1, so no regressions
Hummer12007_ has joined #foot
yyp_ has joined #foot
psnszsn_ has joined #foot
novakane_ has joined #foot
dekedro_ has joined #foot
dnkl_ has joined #foot
coder_kalyan_ has joined #foot
freed00m_ has joined #foot
ddevault_ has joined #foot
akspecs_ has joined #foot
lh_ has joined #foot
dooba_ has joined #foot
mendelmaleh_ has joined #foot
mattikus_ has joined #foot
angry_vincent has joined #foot
bisco_ has joined #foot
lh has quit [Ping timeout: 250 seconds]
mendelmaleh has quit [Ping timeout: 250 seconds]
ddevault has quit [Ping timeout: 250 seconds]
Hummer12007 has quit [Ping timeout: 250 seconds]
ecs has quit [Ping timeout: 250 seconds]
mattikus has quit [Ping timeout: 250 seconds]
yyp has quit [Ping timeout: 250 seconds]
novakane has quit [Ping timeout: 250 seconds]
psnszsn has quit [Ping timeout: 250 seconds]
angry_vi1cent has quit [Ping timeout: 250 seconds]
dnkl has quit [Ping timeout: 250 seconds]
dooba has quit [Ping timeout: 250 seconds]
dekedro has quit [Ping timeout: 250 seconds]
freed00m has quit [Ping timeout: 250 seconds]
coder_kalyan has quit [Ping timeout: 250 seconds]
akspecs has quit [Ping timeout: 250 seconds]
birger has quit [Ping timeout: 250 seconds]
mendelmaleh_ is now known as mendelmaleh
lh_ is now known as lh
ddevault_ is now known as ddevault
Hummer12007_ is now known as Hummer12007
akspecs_ is now known as akspecs
yyp_ is now known as yyp
dooba_ is now known as dooba
psnszsn_ is now known as psnszsn
novakane_ is now known as novakane
freed00m_ is now known as freed00m
dekedro_ is now known as dekedro
dnkl_ is now known as dnkl
coder_kalyan_ is now known as coder_kalyan
mattikus_ is now known as mattikus
ecs has joined #foot