michaelni changed the topic of #ffmpeg-devel to: Welcome to the FFmpeg development channel | Questions about using FFmpeg or developing with libav* libs should be asked in #ffmpeg | This channel is publicly logged | FFmpeg 7.0 has been released! | Please read ffmpeg.org/developer.html#Code-of-conduct
iive has quit [Quit: They came for me...]
lexano has quit [Ping timeout: 272 seconds]
<cone-122> ffmpeg Lynne master:db09f1a5d811: vulkan_av1: add workaround for NVIDIA drivers tested on broken CTS
<Lynne> jkqxz: do you agree we should backport this to 7.0?
thilo has quit [Ping timeout: 255 seconds]
thilo has joined #ffmpeg-devel
thilo has joined #ffmpeg-devel
thilo has quit [Changing host]
rvalue has quit [Read error: Connection reset by peer]
rvalue has joined #ffmpeg-devel
qeed has joined #ffmpeg-devel
lemourin has quit [Quit: The Lounge - https://thelounge.chat]
lemourin has joined #ffmpeg-devel
arch1t3cht3 has joined #ffmpeg-devel
arch1t3cht has quit [Ping timeout: 252 seconds]
arch1t3cht3 is now known as arch1t3cht
<cone-122> ffmpeg LuMingYin master:5e380bcdb13d: avfilter/af_channelsplit: fix memory leak
<andrewrk> it looks like av_probe_input_buffer2 makes no attempt to free `buf` when an error occurs
<andrewrk> "Free the supplied IO context and everything associated with it." that's not what it does. it only frees the supplied IO context and everything associated with it leaks
<jamrial> andrewrk: ffio_rewind_with_probe_data() frees it or takes ownership of it
<andrewrk> ffmpeg's API has extra logic to help with memory management but it actually makes memory management more complicated and gets in the way
<andrewrk> the same actor should be the one to allocate and free a resource. it makes everything simpler
<andrewrk> and the thing where the deallocation functions set the pointer to null violates non-null type safety
jamrial has quit []
Sean_McG has joined #ffmpeg-devel
* Sean_McG peeks in
Martchus_ has joined #ffmpeg-devel
Martchus has quit [Ping timeout: 260 seconds]
darkapex has quit [Ping timeout: 272 seconds]
darkapex has joined #ffmpeg-devel
Wenbin_Chen__ has joined #ffmpeg-devel
Wenbin_Chen_ has quit [Ping timeout: 256 seconds]
nitroxis has quit []
georgereynolds8 has joined #ffmpeg-devel
nitroxis has joined #ffmpeg-devel
Traneptora has joined #ffmpeg-devel
nitroxis has quit []
nitroxis has joined #ffmpeg-devel
cone-122 has quit [Quit: transmission timeout]
Wenbin_Chen_ has joined #ffmpeg-devel
Wenbin_Chen__ has quit [Read error: Connection reset by peer]
beastd has quit [Ping timeout: 260 seconds]
kurosu has joined #ffmpeg-devel
Wenbin_Chen__ has joined #ffmpeg-devel
Wenbin_Chen_ has quit [Ping timeout: 256 seconds]
beastd has joined #ffmpeg-devel
feiwan1 has quit [Remote host closed the connection]
Wenbin_Chen_ has joined #ffmpeg-devel
Wenbin_Chen__ has quit [Remote host closed the connection]
compnn has joined #ffmpeg-devel
compn has quit [Ping timeout: 272 seconds]
rvalue- has joined #ffmpeg-devel
rvalue has quit [Ping timeout: 260 seconds]
rvalue- is now known as rvalue
Krowl has joined #ffmpeg-devel
Krowl has quit [Client Quit]
Krowl has joined #ffmpeg-devel
<JEEB> huh, I have a H.264 stream which with frame threading gets FF_DECODE_ERROR_DECODE_SLICES applied
<JEEB> (with frame threads)
<JEEB> seems like the ERContext has something set when the logic gets to libavcodec/h264_slice.c::decode_slice
<JEEB> threads:v 1 doesn't make it happen, but threads:v 2 already do
<JEEB> will poke a bit more at it and then make a sample
<Sebastinas> I don't do anything that is older than oldstable
<JEEB> lol, helgrind results
cone-829 has joined #ffmpeg-devel
<cone-829> ffmpeg Michael Niedermayer release/5.1:c8bd7f92098c: Update for 5.1.5
Krowl has quit [Read error: Connection reset by peer]
Wenbin_Chen__ has joined #ffmpeg-devel
Wenbin_Chen_ has quit [Read error: Connection reset by peer]
ccawley2011 has joined #ffmpeg-devel
Krowl has joined #ffmpeg-devel
odrling has quit [Remote host closed the connection]
odrling has joined #ffmpeg-devel
Wenbin_Chen_ has joined #ffmpeg-devel
Wenbin_Chen__ has quit [Remote host closed the connection]
<JEEB> ok, so the flags are set even with threads 1, but it doesn't end up in the logic that sets > sl->er->error_occurred = 1;
<JEEB> right, active_thread_type 0 happens with threads 1
<JEEB> > ER stuff happened: start_i: 4080, prev_status: 112
<JEEB> ok, so 112 is the value that gets ignored
<JEEB> interesting, added a log line right into `if (prev_status != (ER_MV_END | ER_DC_END | ER_AC_END))` and that doesn't get hit
<JEEB> so `er->error_occurred = 1;` occurs somewhere else
<JEEB> so, `./ffmpeg -v verbose -threads:v 1 -i "https://megumin.fushizen.eu/samples/2024-04-15-framethread_causes_er_errors.264" -map 0:v -f null pipe:` -> this only gives out a "corrupt decoded frame" message at the end when the bitstream suddenly ends
<JEEB> if you bump the threads to 2, you get more of them
<JEEB> can anyone else repro this? :D
<JEEB> (the file is 5MiB or so)
razor_ has joined #ffmpeg-devel
tufei_ has quit [Remote host closed the connection]
Wenbin_Chen_ has quit [Read error: Connection reset by peer]
Wenbin_Chen_ has joined #ffmpeg-devel
tufei_ has joined #ffmpeg-devel
Wenbin_Chen__ has joined #ffmpeg-devel
Wenbin_Chen_ has quit [Remote host closed the connection]
HarshK23 has joined #ffmpeg-devel
<JEEB> the actual decoded data seems to be the same by switching the output to framehash
mkver has joined #ffmpeg-devel
<JEEB> switching to slice threading changes the hash of the last frame (which makes sense since the packet suddenly ends)
<JEEB> but otherwise matches
<JEEB> might make a ticket for this later
<another|> people confusing ffmpeg-devel with -user and hijacking other threads. greeeeat
tufei_ has quit [Remote host closed the connection]
tufei_ has joined #ffmpeg-devel
Krowl has quit [Read error: Connection reset by peer]
SystemError has quit [Ping timeout: 260 seconds]
<Daemon404> normal
cone-829 has quit [Quit: transmission timeout]
lexano has joined #ffmpeg-devel
Wenbin_Chen_ has joined #ffmpeg-devel
Wenbin_Chen__ has quit [Remote host closed the connection]
<BtbN> michaelni: I think you misread old-stable vs. old-old-stable in that mail?
tufei__ has joined #ffmpeg-devel
tufei_ has quit [Ping timeout: 260 seconds]
MrZeus has joined #ffmpeg-devel
<Sean_McG> bleh, must be a Monday
jamrial has joined #ffmpeg-devel
MrZeus has quit [Ping timeout: 272 seconds]
rossy has quit [Remote host closed the connection]
rossy has joined #ffmpeg-devel
System_Error has joined #ffmpeg-devel
Krowl has joined #ffmpeg-devel
<thardin> is there no way to convert text subtitles to bitmaps if the subs are a stream?
<thardin> vf_subtitles wants a file
<JEEB> yea because subtitles are still in AVSubtitle, and not AVFrames. libavfilter is only AVFrames. in theory if you extended ffmpeg cli's sub2video to text->image as well as image->image it'd be possible.
Wenbin_Chen__ has joined #ffmpeg-devel
Wenbin_Chen_ has quit [Read error: Connection reset by peer]
<thardin> what does sub2video *do*? convert bitmap subs to video?
<thardin> seems so
ramiro has quit [Ping timeout: 255 seconds]
Krowl has quit [Read error: Connection reset by peer]
<JEEB> thardin: currently yea
<JEEB> it overlays the bitmap subpictures onto a video resolution AVFrame. in theory if you'd extend that it'd be possible to get subtitle overlays with the current AVSubtitle setup
<jamrial> do we have an existing case of a struct with an AVClass that has a child_next callback() that returns an entry in an array of structs (all with the same avclass)?
<jamrial> how would av_opt_set with search_children work in that case? an option name would match the very first entry in said array of structs
<thardin> JEEB: that's not what I want though. I want to be able to convert text subs to bitmap subs
<thardin> for example srt to dvbsub
<BtbN> Don't think that's possible as of now
ramiro has joined #ffmpeg-devel
Wenbin_Chen__ has quit [Read error: Connection reset by peer]
Wenbin_Chen_ has joined #ffmpeg-devel
<JEEB> thardin: yea then you'd have to be able to convert AVSubtitle to AVSubtitle
<JEEB> you just mentioned vf_subtitle :P
cone-062 has joined #ffmpeg-devel
<cone-062> ffmpeg Frank Plowman master:993c231de0b1: lavc/vvc: Increase size of ctb_size_y
<thardin> yeah I had kind of assumed vf_subtitles does that but alas
blb has quit [Ping timeout: 272 seconds]
<thardin> however! I think some of it can maybe be reused
blb has joined #ffmpeg-devel
Krowl has joined #ffmpeg-devel
<thardin> this also seems to be a recurring thing users as for
<thardin> ask
rvalue has quit [Read error: Connection reset by peer]
rvalue has joined #ffmpeg-devel
Wenbin_Chen__ has joined #ffmpeg-devel
Wenbin_Chen_ has quit [Read error: Connection reset by peer]
System_Error has quit [Remote host closed the connection]
System_Error has joined #ffmpeg-devel
Arsen has quit [Quit: Quit.]
Krowl has quit [Read error: Connection reset by peer]
_av500_ has joined #ffmpeg-devel
_av500_ is now known as av500
BBB has quit [Ping timeout: 256 seconds]
Krowl has joined #ffmpeg-devel
Arsen has joined #ffmpeg-devel
BBB has joined #ffmpeg-devel
Arsen has quit [Quit: Quit.]
Arsen has joined #ffmpeg-devel
beastd has quit [Ping timeout: 246 seconds]
beastd has joined #ffmpeg-devel
Livio has joined #ffmpeg-devel
Livio has quit [Ping timeout: 255 seconds]
Wenbin_Chen_ has joined #ffmpeg-devel
cone-062 has quit [Quit: transmission timeout]
Wenbin_Chen__ has quit [Ping timeout: 256 seconds]
Krowl has quit [Read error: Connection reset by peer]
<Daemon404> aligned struct init / tables are super annoying
cone-439 has joined #ffmpeg-devel
<cone-439> ffmpeg Stefano Sabatini master:b2bc4ac69e5a: doc/utils/eval: review and extend, clarify ld/st index meaning
<cone-439> ffmpeg Stefano Sabatini master:8ceb37d5ad73: doc/utils/eval: clarify meaning of random* seed value
<cone-439> ffmpeg Antoine SOULIER master:257bc2a82ab6: avformat/lc3: add file format for LC3/LC3plus transport
<beastd> Daemon404: If I understood your complaint correctly I would agree and say that I have basically given up on those personally... Is there any particular instance you are looking at?
rvalue has quit [Read error: Connection reset by peer]
<BtbN> Apparently an ARM Devkit is Hazmat, and DHL refuses to ship it
<BtbN> I'm very confused. It doesn't even have a battery or anything.
<Daemon404> beastd, adding to any list ;)
rvalue has joined #ffmpeg-devel
Livio has joined #ffmpeg-devel
<Sean_McG> BtbN: the hell?!
<BtbN> My only guess is on the tiny BIOS battery or something
Livio has quit [Ping timeout: 255 seconds]
<jamrial> BtbN: how would they ship standard motherboards then?
<BtbN> Yeah, that's what I'm confused about
<jamrial> i'm sure people buy those online and dhl ships such packages
<BtbN> It's about Air-Freight
<BtbN> They don't want it on their plane
<BtbN> I can understand that for big fat LiIon batteries
<BtbN> but a bios cell?
<jamrial> so if you buy a notebook from amazon, they will not ship it overseas?
Wenbin_Chen__ has joined #ffmpeg-devel
<wbs> they probably ship such things by plane as well, but I guess there's some special deal with the handling company, and for regular people they just refuse
Wenbin_Chen_ has quit [Ping timeout: 246 seconds]
<jkqxz> Lithium metal batteries are generally considered worse than lithium ion ones. A blanket ban on them without special handling is not surprising, even if it seems stupid for a single tiny one.
ccawley2011_ has joined #ffmpeg-devel
System_Error has quit [Remote host closed the connection]
ccawley2011 has quit [Ping timeout: 260 seconds]
System_Error has joined #ffmpeg-devel
System_Error has quit [Read error: Connection reset by peer]
<Lynne> jkqxz: ping, do you think the fix for av1 should be backported to release/7.0?
<BtbN> Apparently FexEx will ship it. Via boat.
<BtbN> And for a hefty surcharge
System_Error has joined #ffmpeg-devel
Livio has joined #ffmpeg-devel
System_Error has quit [Remote host closed the connection]
System_Error has joined #ffmpeg-devel
<beastd> BtbN: Slower and more expensive? :( Where it is shipped from?
<BtbN> The US, to Europe
<sdc> are you near the red sea? shipping were up for awhile
<sdc> not sure if they still are
<jkqxz> Lynne: I guess? Probably not many users for that combination (very new drivers and vulkan but ffmpeg release branch), but seems reasonable to fix it anyway.
<BtbN> I don't know where the package is in the US. I just bought it on eBay
<jamrial> if it's the bios cell, just have it shipped without it
<BtbN> I'm not going to have a random warehouse service tinker around on the device
<BtbN> It's no longer in the hands of the seller, but at some intermediary shipment consolidator
<jamrial> ah, nevermind then
<jamrial> i assumed it was in the hands of the seller still
<BtbN> If I had realized it'd cause this, I'd have just told the seller to please remove the battery. Not sure if you even can? It's rather small, and might be soldered.
<wbs> I doubt they know/care about a bios battery anyway, I presume they've just classed it as a laptop or similar
<BtbN> Well, they somehow knew, and refused to ship it
<BtbN> I labeled it as "Windows ARM Dev Kit"
<wbs> maybe "desktop computer (no battery)" would have worked better, who knows (and that's not easy to know beforehand)
<BtbN> Yeah, if I had known this in advance, I'd have taken steps
<BtbN> Now it's going on an expensive boat ride
<BtbN> Not sure why "Stuff's on fire" is so much better on a boat than on a plane though
Livio has quit [Ping timeout: 268 seconds]
<jkqxz> Plenty of water available?
<BtbN> Yeah, but you'd flood a whole lot of stuff in the process
Wenbin_Chen_ has joined #ffmpeg-devel
Wenbin_Chen__ has quit [Remote host closed the connection]
iive has joined #ffmpeg-devel
cone-439 has quit [Quit: transmission timeout]
Livio has joined #ffmpeg-devel
razor_ has quit [Ping timeout: 240 seconds]
Livio has quit [Ping timeout: 260 seconds]
System_Error has quit [Remote host closed the connection]
System_Error has joined #ffmpeg-devel
paulk has joined #ffmpeg-devel
paulk has joined #ffmpeg-devel
paulk has quit [Changing host]
Krowl has joined #ffmpeg-devel
Warcop has joined #ffmpeg-devel
AbleBacon has joined #ffmpeg-devel
Wenbin_Chen__ has joined #ffmpeg-devel
Wenbin_Chen_ has quit [Read error: Connection reset by peer]
Krowl has quit [Read error: Connection reset by peer]
BBB has quit [Ping timeout: 260 seconds]
BBB has joined #ffmpeg-devel
<ramiro> jdek: wbs: I'm trying to add fdct to checkasm. I have never written anything for checkasm, so I am not quite sure what to do here. I don't mean to check if results are identical between ref and new (since the implementations are not bitexact), but I do want to check that the dc value doesn't overflow. So something like call_new(block); if (dc overflows) fail();, but I haven't seen any other test that
<ramiro> does something similar though. Do you have any suggestions on how I could proceed? (or even if checkasm is indeed the write tool for this)
<wbs> ramiro: (just going to bed), checkasm is indeed a good place for a test like this. we have some existing helpers for fuzzy float comparison with a given tolerance, and for the overflows check - just define what overflow means in this case and add a helper function (either in the same file or in checkasm.c)
tufei__ has quit [Remote host closed the connection]
tufei__ has joined #ffmpeg-devel
CATS has quit [Ping timeout: 260 seconds]
beastd has quit [Ping timeout: 240 seconds]
beastd has joined #ffmpeg-devel
qeed has quit [Quit: qeed]
CATS has joined #ffmpeg-devel
beastd has quit [Ping timeout: 272 seconds]
beastd has joined #ffmpeg-devel
mkver has quit [Ping timeout: 256 seconds]
System_Error has quit [Remote host closed the connection]
System_Error has joined #ffmpeg-devel
ccawley2011_ has quit [Read error: Connection reset by peer]
kurosu has quit [Quit: Connection closed for inactivity]
mark4o has joined #ffmpeg-devel
markh has quit [Ping timeout: 255 seconds]
mark4o is now known as markh