dustymabe changed the topic of #fedora-coreos to: Fedora CoreOS :: Find out more at https://getfedora.org/coreos/ :: Logs at https://libera.irclog.whitequark.org/fedora-coreos
plarsen has quit [Remote host closed the connection]
bgilbert has joined #fedora-coreos
jlebon has quit [Quit: leaving]
Betal has quit [Quit: WeeChat 3.7]
paragan has joined #fedora-coreos
bytehackr has joined #fedora-coreos
gursewak has joined #fedora-coreos
gursewak has quit [Ping timeout: 252 seconds]
azukku has joined #fedora-coreos
mosen has quit [Quit: Textual IRC Client: www.textualapp.com]
cyberpear has quit [Ping timeout: 260 seconds]
cyberpear has joined #fedora-coreos
stranger0815 has joined #fedora-coreos
jcajka has joined #fedora-coreos
saschagrunert has joined #fedora-coreos
c4rt0 has joined #fedora-coreos
saschagrunert has quit [Remote host closed the connection]
saschagrunert has joined #fedora-coreos
gursewak has joined #fedora-coreos
mgrundmann has quit [Ping timeout: 260 seconds]
mgrundmann has joined #fedora-coreos
travisghansen has quit [Quit: The Lounge - https://thelounge.github.io]
travisghansen has joined #fedora-coreos
travisghansen has quit [Quit: The Lounge - https://thelounge.github.io]
travisghansen has joined #fedora-coreos
gursewak has quit [Ping timeout: 264 seconds]
mnguyen has joined #fedora-coreos
saschagrunert has quit [Remote host closed the connection]
crobinso has joined #fedora-coreos
mgrundmann has quit [Ping timeout: 252 seconds]
mgrundmann has joined #fedora-coreos
gursewak has joined #fedora-coreos
jlebon has joined #fedora-coreos
mgrundmann has quit [Ping timeout: 268 seconds]
mheon has joined #fedora-coreos
gursewak has quit [Ping timeout: 268 seconds]
mgrundmann has joined #fedora-coreos
nalind has joined #fedora-coreos
plarsen has joined #fedora-coreos
jcajka has quit [Quit: Leaving]
arnulfo_7 has quit [Read error: Connection reset by peer]
<dustymabe> \o
gursewak has joined #fedora-coreos
<jlebon> o/
jcajka has joined #fedora-coreos
vgoyal has joined #fedora-coreos
gursewak has quit [Ping timeout: 252 seconds]
frigo has joined #fedora-coreos
azukku has quit [Quit: Leaving.]
azukku has joined #fedora-coreos
azukku has quit [Client Quit]
jcajka has quit [Quit: Leaving]
frigo has quit [Quit: Client closed]
stranger0815 has quit [Quit: Client closed]
mgrundmann has quit [Remote host closed the connection]
bytehackr has quit [Quit: Leaving]
paragan has quit [Quit: Leaving]
Betal has joined #fedora-coreos
agners has quit [Quit: WeeChat 3.6]
<dustymabe> jlebon: took me longer than I thought it would to rebase that PR
<dustymabe> that Ids -> ids change made every later commit have a conflict :)
hotbox has quit [Ping timeout: 268 seconds]
<jlebon> ouch, yeah i can imagine :)
<dustymabe> I think we have two open questions left
nalind has quit [Quit: bye]
<dustymabe> if the changes look good I'll try to fire up and test them in staging
hotbox has joined #fedora-coreos
plarsen has quit [Quit: NullPointerException!]
<jlebon> replied there. i think there's just one main comment we should address
<dustymabe> ok I think I handled everything!
<dustymabe> now the big question.. do we merge today or wait til monday - if we wait til monday we'll probably wait til tuesday to let the triple release filter through
<dustymabe> but... this update actually has a fix needed for the cloud tests
<dustymabe> which are failing right now because of the reprovision step
<dustymabe> followup to that PR is this one: https://github.com/coreos/fedora-coreos-pipeline/pull/693
vgoyal has quit [Quit: Leaving]
c4rt0 has quit [Remote host closed the connection]
<jlebon> dustymabe: i'd prefer we wait, but leave it up to you. is there a tactical fix we could do for next week for the reprovisioning test?
<jlebon> i guess we can merge my PR I had closed, and then in your draft PR you revert it
<dustymabe> ehh - I think we can just merge it Monday morning and deal with the fallout before we start the triple release
<jlebon> how much testing did you do in staging?
mheon has quit [Ping timeout: 264 seconds]
<dustymabe> that PR won't fix the issue with the cloud tests
<dustymabe> most of them don't pass `extraArgs`
<jlebon> right indeed
<dustymabe> jlebon: :) - last night I ran bump-lockfile and a single build and build-arch job
<dustymabe> now that the PR is approved I'm running them again
<jlebon> a temporary fix would just be to revert in a branch and point jenkins at it in the shared lib configuration
<dustymabe> so I'm thinking if all goes well I can merge it and the pipeline PR and handle fixups ad-hoc over the weekend or monday morning
<dustymabe> one thing I don't really have much of is testing the coreos-ci-lib changes with an upstream repo
<jlebon> the cloud ones should be safe since they were already using the lib helper
<jlebon> should be safer*
<dustymabe> works with the pipeline
<dustymabe> which lib helper?
<jlebon> fcosKola()
<jlebon> so if you tested build, buid-arch and bump-lockfile and those look good, i think we're ok
<jlebon> because those are the ones with the higher churn
<dustymabe> ok, like I said, I'm running the tests again now
<dustymabe> so there might be a fixup to those PRs that flows in
<dustymabe> but if the tests pass maybe we're good
<jlebon> yup, reviewing
<dustymabe> I have to run - catch you in the other messaging platform if anything comes up later
<dustymabe> thanks for the work today jlebon
<jlebon> ttyl!
hotbox has quit [Ping timeout: 264 seconds]
crobinso has quit [Remote host closed the connection]