dustymabe changed the topic of #fedora-coreos to: Fedora CoreOS :: Find out more at https://getfedora.org/coreos/ :: Logs at https://libera.irclog.whitequark.org/fedora-coreos
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 246 seconds]
bgrech has joined #fedora-coreos
bgrech2 has joined #fedora-coreos
bgrech2 has quit [Client Quit]
bgrech has quit [Client Quit]
plarsen has quit [Remote host closed the connection]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 252 seconds]
paragan has joined #fedora-coreos
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 248 seconds]
bytehackr has joined #fedora-coreos
jpn has joined #fedora-coreos
flokli has quit [Quit: WeeChat 3.7.1]
flokli has joined #fedora-coreos
Arkanterian has joined #fedora-coreos
jpn has quit [Ping timeout: 248 seconds]
jcajka has joined #fedora-coreos
bagasse_ has quit [Quit: Leaving]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 252 seconds]
travisghansen has quit [Quit: The Lounge - https://thelounge.github.io]
travisghansen has joined #fedora-coreos
jpn has joined #fedora-coreos
Arkanterian has quit [Quit: Client closed]
jpn has quit [Ping timeout: 246 seconds]
fifofonix has joined #fedora-coreos
jpn has joined #fedora-coreos
travisghansen has quit [Quit: The Lounge - https://thelounge.github.io]
travisghansen has joined #fedora-coreos
nagarap has joined #fedora-coreos
paragan has quit [Ping timeout: 246 seconds]
crobinso has joined #fedora-coreos
fifofonix has quit [Quit: Textual IRC Client: www.textualapp.com]
jpn has quit [Quit: Lost terminal]
fifofonix has joined #fedora-coreos
travisghansen2 has joined #fedora-coreos
travisghansen has quit [Read error: Connection reset by peer]
travisghansen2 is now known as travisghansen
vgoyal has joined #fedora-coreos
nagarap has quit [Ping timeout: 252 seconds]
jpn has joined #fedora-coreos
jpn has quit [Quit: Lost terminal]
nagarap has joined #fedora-coreos
poppajarv has joined #fedora-coreos
jlebon has joined #fedora-coreos
plarsen has joined #fedora-coreos
mheon has joined #fedora-coreos
<dustymabe> anyone mind a review on https://github.com/coreos/fedora-coreos-config/pull/2041 ?
travisghansen4 has joined #fedora-coreos
nalind has joined #fedora-coreos
travisghansen has quit [Read error: Connection reset by peer]
travisghansen4 is now known as travisghansen
<jlebon> :lgtm:
arnulfo_07 has quit [Quit: Leaving]
<dustymabe> :ty:
ravanelli has joined #fedora-coreos
rsalveti has quit [Quit: Connection closed for inactivity]
fifofonix has quit [Quit: Textual IRC Client: www.textualapp.com]
nagarap has quit [Ping timeout: 252 seconds]
gursewak has joined #fedora-coreos
jpn has joined #fedora-coreos
fifofonix has joined #fedora-coreos
nagarap has joined #fedora-coreos
fifofonix has quit [Quit: Textual IRC Client: www.textualapp.com]
jpn has quit [Ping timeout: 252 seconds]
jlebon has quit [Ping timeout: 252 seconds]
jlebon has joined #fedora-coreos
travisghansen1 has joined #fedora-coreos
travisghansen has quit [Read error: Connection reset by peer]
travisghansen1 is now known as travisghansen
zodbot has quit [Quit: nirik]
zodbot has joined #fedora-coreos
shlTlord has joined #fedora-coreos
jcajka has quit [Quit: Leaving]
gursewak has quit [Remote host closed the connection]
nagarap has quit [Quit: Leaving]
gursewak has joined #fedora-coreos
rsalveti has joined #fedora-coreos
<dustymabe> jlebon: are you good with deleting the quay.io/coreos-assembler/fcos repo now?
<jlebon> dustymabe: yeah, was looking at that. it clearly says it'll be removed, so yeah SGTM
<jlebon> though technically we're still in october :)
<dustymabe> ha - OK - i'll do it tomorrow :)
<jlebon> :) +1
<dustymabe> jlebon: got a second to chat about https://github.com/coreos/fedora-coreos-pipeline/pull/724 ?
<jlebon> dustymabe: sure thing
<dustymabe> here work? or video?
<jlebon> cool with whichever
<dustymabe> ok so for 4.11 and older - before the release job gets run - what will be in the meta.json ?
<dustymabe> images.ostree AND images.legacy-oscontainer ?
<jlebon> correct
<dustymabe> ok I think the code doesn't handle this then.. won't we always drop into the `Cannot push both oscontainer and legacy_oscontainer` error?
<jlebon> i think we need to rework the registry_repos in config.yaml
<dustymabe> why don't we just say: IF legacy_osctontainer artifact was built THEN assume we're pushing that
<jlebon> i think this code was assuming that we'd move the registry_repos bit for the legacy_oscontainer to the 4.11 and older per-stream config
<dustymabe> because we're not building it for 4.12+ ?
<dustymabe> yeah.. that starts to get more complicated, though :(
<jlebon> but yeah, that's not enough even for 4.12 if we want to keep with the "default config = 4.12 config" semantic
<jlebon> let me rework this
<dustymabe> WDYT of the IF/THEN suggestion above?
<jlebon> i think that makes sense, yeah. let me type it out and see what comes out
<dustymabe> +1
<dustymabe> also.. does the fact that we'll have both images.ostree AND images.legacy-oscontainer - does that constitute a change in those streams? i.e. images.ostree points at something that's a different format now?
<jlebon> images.ostree wasn't the legacy format before. it was still the ociarchive/tarball. the new thing is images.legacy-oscontainer, but i don't think anything will care that it showed up since tooling mostly cares about where it was pushed (top-level `oscontainer`)
<dustymabe> that's odd to me - oh oh - I see. the machine-os-content was kind of bolted on before?
<jlebon> yeah, the cosa code would build and push in one shot and then inject it in `oscontainer`
<dustymabe> i.e. never stored as a images. artifact before and the only trace it existed was the top level registry info in the meta.json
<jlebon> right, because nothing needed it as an ociarchive before our pipeline with the split build/release
<dustymabe> ok cool - I think the IF/THEN should suffice then
<dustymabe> jlebon: in your patch you might be able to do something like this too: https://paste.centos.org/view/08960e6e
<jlebon> right, good call
<dustymabe> jlebon: actually this is probably a more appropriate comment: https://paste.centos.org/view/8f0be9c4
<jlebon> yeah, was thinking something more along those lines :)
bgilbert has joined #fedora-coreos
* jlebon goes for food
zodbot has quit [Remote host closed the connection]
fifofonix has joined #fedora-coreos
bytehackr has quit [Ping timeout: 255 seconds]
travisghansen6 has joined #fedora-coreos
travisghansen has quit [Read error: Connection reset by peer]
travisghansen6 is now known as travisghansen
jpn has joined #fedora-coreos
gursewak has quit [Quit: Leaving]
zodbot has joined #fedora-coreos
jpn has quit [Ping timeout: 255 seconds]
fifofonix has quit [Ping timeout: 252 seconds]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 246 seconds]
gursewak has joined #fedora-coreos
jpn has joined #fedora-coreos
bgilbert has quit [Read error: Connection reset by peer]
bgilbert_ has joined #fedora-coreos
bgilbert_ is now known as bgilbert
<dustymabe> jlebon: should we override the failing test in https://github.com/coreos/coreos-assembler/pull/3151 ?
fifofonix has joined #fedora-coreos
travisghansen1 has joined #fedora-coreos
travisghansen has quit [Read error: Connection reset by peer]
travisghansen1 is now known as travisghansen
jpn has quit [Ping timeout: 252 seconds]
<jlebon> dustymabe: :checkyes:
ravanelli has quit [Remote host closed the connection]
ravanelli has joined #fedora-coreos
ravanelli has quit [Ping timeout: 276 seconds]
jpn has joined #fedora-coreos
gursewak has quit [Ping timeout: 246 seconds]
jpn has quit [Ping timeout: 248 seconds]
nalind has quit [Quit: bye for now]
<dustymabe> jlebon: i'm wondering if you can bring some clarity here on how we should be approaching this: https://github.com/coreos/coreos-assembler/pull/3152
ravanelli has joined #fedora-coreos
gursewak has joined #fedora-coreos
ravanelli has quit [Ping timeout: 276 seconds]
Arkanterian has joined #fedora-coreos
samuelbernardo has joined #fedora-coreos
jpn has joined #fedora-coreos
Betal has joined #fedora-coreos
bgilbert_ has joined #fedora-coreos
bgilbert has quit [Ping timeout: 252 seconds]
Arkanterian has quit [Quit: Client closed]
jpn has quit [Ping timeout: 248 seconds]
ravanelli has joined #fedora-coreos
travisghansen2 has joined #fedora-coreos
travisghansen has quit [Ping timeout: 252 seconds]
travisghansen2 is now known as travisghansen
ravanelli has quit [Ping timeout: 246 seconds]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 252 seconds]
gursewak has quit [Ping timeout: 248 seconds]
jpn has joined #fedora-coreos
ravanelli has joined #fedora-coreos
ravanelli has quit [Ping timeout: 255 seconds]
mheon has quit [Ping timeout: 248 seconds]
jpn has quit [Ping timeout: 252 seconds]
crobinso has quit [Remote host closed the connection]
ravanelli has joined #fedora-coreos
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 246 seconds]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 252 seconds]
gursewak has joined #fedora-coreos
gursewak has quit [Remote host closed the connection]
gursewak has joined #fedora-coreos
gursewak has quit [Remote host closed the connection]
gursewak has joined #fedora-coreos
gursewak has quit [Ping timeout: 246 seconds]
jpn has joined #fedora-coreos