lanefu changed the topic of #armbian-rockchip to: Armbian - Linux for ARM development boards | Rockchip SoC | www.armbian.com | This channel is relayed to the equivalent Discord channel | this channel is logged
<DC-IRC>
[Discord] <lanefu> @zeeto9 yeah builder supports mbox format .patch files so you can do like `b4 am -o- "https://lore.kernel.org/all/xxxxx/" > patch/kernel/archive/rockchip-rk3588-6.10/xxx.patch`
DC-IRC has quit [Remote host closed the connection]
DC-IRC has joined #armbian-rockchip
<DC-IRC>
[Discord] <zeeto9> That’s great, I’m going to attempt this approach, verify, and attempt a build to find out what I might have missed or still needs changes.
<DC-IRC>
[Discord] <zeeto9> This is very helpful. Thank you
<DC-IRC>
[Discord] <zeeto9> sometimes its the little things: ✓ [PATCH v4 1/4] MAINTAINERS: Add entry for Synopsys DesignWare HDMI RX Driver
<DC-IRC>
[Discord] <zeeto9> + Reviewed-by: Christopher Obbard <chris.obbard@collabora.com> (✓ DKIM/collabora.com)
<DC-IRC>
[Discord] <zeeto9> ✓ [PATCH v4 3/4] arm64: dts: rockchip: Add device tree support for HDMI RX Controller
<DC-IRC>
[Discord] <zeeto9> ✓ [PATCH v4 4/4] media: platform: synopsys: Add support for hdmi input driver 😄
<DC-IRC>
[Discord] <zeeto9> i see patches all seem to have a number prefix of xxxx-, is there a numbering scheme to be used?
<DC-IRC>
[Discord] <zeeto9> locally I am going to use: 0029-RK3588-Add-hdmirx-Support-v4.patch, 0029 to come after the last add patch, v4 for the patch version. i think im following best practice (unsure on the starting number though). let me know thoughts if any.
<DC-IRC>
[Discord] <zeeto9> i expect failure on my first attempt. but i finally made it my first attempt.
<DC-IRC>
[Discord] <zeeto9> i expect failure on my first attempt. but i finally made it to my first attempt.
<DC-IRC>
[Discord] <zeeto9> alright, so a couple dtsi files are missing for the patch. Since I need to bring over two files, does this require another patch of my own for them to be added during the build, so that the patch I have for hdmi rx, will then be able to apply them?
<DC-IRC>
[Discord] <zeeto9> or....it might be because the patch is looking for: rk3588-base-pinctrl.dtsi, but currently there is a file named rk3588-pinctrl.dtsi
<DC-IRC>
[Discord] <zeeto9> same question on: /arm64/boot/dts/rockchip/rk3588-extra.dtsi
<DC-IRC>
[Discord] <zeeto9> and another question, should I be changing the armbian build somehow to use release of v6.10 instead of v6.10rc7? during the compile setup process, besides selecting edge, I dont see another place for it
<DC-IRC>
[Discord] <zeeto9> i mostly just KERNEL_MAJOR_MINOR="6.10", but nothing I see points it to 6.10rc7
<DC-IRC>
[Discord] <zeeto9> things I am going to attempt. moving position of patch to the end but increasing 4 digit prefix to 1099-. If that still runs into issues, I am going to modify my patch and change where it has the diff a, b areas, and modify b to point to the file that does exist and I think may be the correct place. ill see from here
<DC-IRC>
[Discord] <zeeto9> yea, it looks like i might need to bring patches from mainline 6.10 down to the armbian build and apply before then applying my hdmi rx patch. the file I have has a minimum a 100 less lines.
DC-IRC has quit [Remote host closed the connection]
DC-IRC has joined #armbian-rockchip
sfo has quit [Remote host closed the connection]
sfo has joined #armbian-rockchip
<DC-IRC>
[Discord] <beohoff3174> Just pull the main armbian repo. It was pushed yesterady at some point
<DC-IRC>
[Discord] <beohoff3174> number scheme is in the notes in`0000.patching_config.yaml` assuming that you are putting your patches in `patch/kernel/archive/rockchip-rk3588-6.10`
<DC-IRC>
[Discord] <beohoff3174> I think this is a bit more suggestive, but if you were planning on backporting the patch to 6.10, I'd recommend leaving the existing file structure. Just thinking out loud, but if you changed the file structure and then ran 6.10, something else that might depend on those files might break unexpectedly
<DC-IRC>
[Discord] <beohoff3174> Just pull the main armbian repo. It was pushed yesterady at some point to update to 6.10. I don't think you need to do anything else
<DC-IRC>
[Discord] <beohoff3174> number scheme is in the notes in`patch/kernel/archive/rockchip-rk3588-6.10/0000.patching_config.yaml` assuming that you are putting your patches in `patch/kernel/archive/rockchip-rk3588-6.10` Haven't looked, but I think it's like 01xx are gpu patches
<DC-IRC>
[Discord] <beohoff3174> I think this is a bit more suggestive, but if you were planning on backporting the patch to 6.10, I'd recommend leaving the existing file structure. Just thinking out loud, but if you changed the file structure and then ran 6.10, something else that might depend on those pre-changed file structure and then might break unexpectedly
<DC-IRC>
[Discord] <beohoff3174> I think this is a bit more suggestive, but if you were planning on backporting the patch to 6.10, I'd recommend leaving the existing file structure. Just thinking out loud, but if you changed the file structure and then ran 6.10, something else might depend on those pre-changed file structure, and therefore would break unexpectedly
<DC-IRC>
[Discord] <beohoff3174> I think this is a bit more suggestive, but if you were planning on backporting the patch to 6.10, I'd recommend leaving the existing file structure. Just thinking out loud, but if you changed the file structure and then ran 6.10, something else might depend on the pre-changed file structure, and therefore would break unexpectedly
<DC-IRC>
[Discord] <beohoff3174> Looks like the reason I haven't been getting anything in dmesg is because the dts needs to be modified.
<DC-IRC>
[Discord] <beohoff3174> The Radxa 5b has a pinctrl for hdmirx:
<DC-IRC>
[Discord] <zeeto9> Nice find, I was trying to look that up last night and was having trouble finding specifics
<DC-IRC>
[Discord] <beohoff3174> This morning I logged in and was, where the F is the dts source?
<DC-IRC>
[Discord] <beohoff3174> I'm only buying Radxa hardware from here on out. The difference in DTS in mainline of Radxa vs OrangePi is insane
<DC-IRC>
[Discord] <beohoff3174> This morning I logged in and was, where the F is the dts source?
<DC-IRC>
[Discord] <beohoff3174> I'm only buying Radxa hardware from here on out. The difference in the quality of the DTS in mainline of Radxa vs OrangePi is insane. Huge shoutout to the armbian folks for picking up the slack
<DC-IRC>
[Discord] <zeeto9> How are you handling the inconsistencies between files/naming? Like rk3588-base-pinctrl.dtsi or rk3588-extra.dtsi? When I look through collabora ld project, I see these are indeed additional files, and as an example, rk3588-base-pinctrl.dtsi is different than the also included rk3588-pinctrl.dtsi. https://gitlab.collabora.com/hardware-enablement/rockchip-3588/linux/-/tree/rk3588/ <clipped message>
<DC-IRC>
[Discord] <zeeto9> How are you handling the inconsistencies between files/naming? Like rk3588-base-pinctrl.dtsi or rk3588-extra.dtsi? When I look through collabora project, I see these are indeed additional files, and as an example, rk3588-base-pinctrl.dtsi is different than the also included rk3588-pinctrl.dtsi. https://gitlab.collabora.com/hardware-enablement/rockchip-3588/linux/-/tree/rk3588/arc <clipped message>
<DC-IRC>
[Discord] <zeeto9> this is where my knowledge of the dtsi is lacking. i am unsure if this is unique to collabora way of organizing projects, or if there truly should be two new dtsi files rk3588-extra.dtsi and rk3588-base-pinctrl.dtsi.
<DC-IRC>
[Discord] <zeeto9> I am thinking I made incorrect assumptions when I tried to reconcile the file names in the patch, removing "base" and "extra" from the names.
<DC-IRC>
[Discord] <zeeto9> which would explain the fuzzing on 2 of the patches
<DC-IRC>
[Discord] <beohoff3174> I modified rk3588.dtsi instead of whatever it got modified to:
<DC-IRC>
[Discord] <beohoff3174> there might be easier ways to do it, but I cloned the linux repo, checked out the 6.10 branch, made my changes in the file, then `git diff > mychangefile.txt`
<DC-IRC>
[Discord] <beohoff3174> I modified rk3588.dtsi instead of whatever it got modified to (rk3588-base.dtsi?):
<DC-IRC>
[Discord] <zeeto9> im going to go that approach as well.
<DC-IRC>
[Discord] <zeeto9> i should probably split my one big patch into 4 patches? Is that normal approach for patches with multi parts? It would make sense, since many different individuals could be working on various parts
<DC-IRC>
[Discord] <beohoff3174> I dropped the documentation patch, and then kept the dtsi changes in one patch and the changes to the snps code in another
<DC-IRC>
[Discord] <zeeto9> i have 1-4 applied, but not 0/4
Werner__ has joined #armbian-rockchip
Werner has quit [Ping timeout: 272 seconds]
<DC-IRC>
[Discord] <aaronngray> Has anyone been playing with the BananaPi-M7's at all. I am wondering if they are worth buying yet or wether to wait till they are stable ? :- https://wiki.banana-pi.org/Banana_Pi_BPI-M7
<DC-IRC>
[Discord] <amazingfate> BananaPi-M7 and armsom sige7 shares the same board and now armsom sige7 is supported by mainline 6.10.
<DC-IRC>
[Discord] <johnthecoolingfan> I've used Chinese Arduino nano with disabled cpu as a uart adapter for an rk3566 board, I can only receive data from it, not send, could I have messed something up in the chip itself?
<DC-IRC>
[Discord] <johnthecoolingfan> I've ordered a couple of proper uart adapters with good chips
<DC-IRC>
[Discord] <johnthecoolingfan> Trying to get btt pi 2 working but the kernel doesn't seem to work with Ethernet
<DC-IRC>
[Discord] <aaronngray> Thanks
<DC-IRC>
[Discord] <johnthecoolingfan> Trying to get btt pi 2 working but Ethernet doesn't work for some reason
<DC-IRC>
[Discord] <johnthecoolingfan> Trying to get btt pi 2 working but Ethernet doesn't work for some reason (even though I'm using the vendor's device tree)
<DC-IRC>
[Discord] <lanefu> @zeeto9 @beohoff3174 I'm having fun watching you all dig in. Keep up the awesome hacking 💪
<DC-IRC>
[Discord] <beohoff3174> just blindly bumping into walls here!
<DC-IRC>
[Discord] <zeeto9> the way I see it, this is the first time since getting into sbc's that I actually have a well defined and documented process. im happy to be in this process.
<DC-IRC>
[Discord] <zeeto9> all around though, this is the first i've been active in armbian and it has been excellent and beyond helpful the number of people chiming in with thoughts. This is definitely where I need to be, I just........needed to figure that out on my own first 😅
<DC-IRC>
[Discord] <zeeto9> dumb question: how do I specifically get tarvolds linux v6.10? I forked it in github but I see its v6.11rc, no tags or branches for any of them
<DC-IRC>
[Discord] <zeeto9> probably not github and straight from kernel.org?
<DC-IRC>
[Discord] <beohoff3174> I checked it out from github
<DC-IRC>
[Discord] <beohoff3174> they are in tags, not branches
<DC-IRC>
[Discord] <zeeto9> alright, ill clone diretly from and skip forking it. its not needed
<DC-IRC>
[Discord] <rpardini> Yeah sorry for the delay here. mbox should generally be supported. The pesky `From ` line might be trouble, though. It's best to use `b4` to slurp the patches from the list, as I've added explicit support for b4's `From ` format.
* DC-IRC
[Discord] <rpardini> realizes `b4` has already been mentioned down the convo thread
<DC-IRC>
[Discord] <rpardini> also, feels-like you guys really wanna be on `linux-next` 😉 we're pointing `MAJOR_MINOR==6.11` to `6.11-rc1`, which ofc isn't released yet.
<DC-IRC>
[Discord] <rpardini> but I envision some 3 lines of code that would bring linux-next as "6.11"
<DC-IRC>
[Discord] <zeeto9> @beohoff3174 after updating my repos and doing a fresh build, I noticed something look at the errors: It looks like shreeya's patch (3 of 4( have been added:
<DC-IRC>
[Discord] <zeeto9> @beohoff3174 after updating my repos and doing a fresh build, I noticed something while looking at the errors: It looks like shreeya's patch (3 of 4( have been added:
<DC-IRC>
[Discord] <beohoff3174> I would drop the MAINTAINERS and the yaml code personally
<DC-IRC>
[Discord] <beohoff3174> rk3588-extra.dtsi and rk3588-base-pinctrl.dtsi have different file names in 6.10
<DC-IRC>
[Discord] <beohoff3174> So you'll have to manually port those I think
<DC-IRC>
[Discord] <zeeto9> yea thats what I hit the wall last night. rk3588-base-pinctrl.dtsi and rk3588-extra.dtsi
<DC-IRC>
[Discord] <zeeto9> thats where my confusion was, is whether or not those were specific to collabora linux, or if it should also be that way in armbian for ours
<DC-IRC>
[Discord] <rpardini> repeat: you're taking recent mailiing list patches that are against some kind of `linux-next` -- while Armbian is at 6.10-final
<DC-IRC>
[Discord] <zeeto9> (just noticed it says v6.11 at very top) 😅
<DC-IRC>
[Discord] <zeeto9> alright, well I guess this is where a decision needs to be made. should I backport that to 6.10, or should I start pointing at armbian v6.11
<DC-IRC>
[Discord] <rpardini> `Merge branch 'v6.11-armsoc/dts64' into for-next` -- `for-next` being key there
<DC-IRC>
[Discord] <rpardini> 6.11 _does not exist yet_
<DC-IRC>
[Discord] <zeeto9> decision made 😄
<DC-IRC>
[Discord] <rpardini> if you backport to 6.10, and it _doesnt work_ -- you've proved nothing 😉 `linux-next` is the way to go there
<DC-IRC>
[Discord] <zeeto9> I have not back ported before, and im going to look into the process right now, but I figured id get this question out of the way: I am guessing I am backporting just the changes I need, does this still utilizing patching to accomplish this or instead should I manually be adding to v6.10 on my linux kernel and then doing git diff and apply that patch along with the others?
<DC-IRC>
[Discord] <beohoff3174> just the changes I need -> yes
<DC-IRC>
[Discord] <beohoff3174> with patching -> yes
<DC-IRC>
[Discord] <beohoff3174> I don't quite understand the rest of your question
<DC-IRC>
[Discord] <beohoff3174> but one way to do this would be to get a text editor out, checkout the linux kernel on v6.10 and make changes
<DC-IRC>
[Discord] <beohoff3174> once you are done, you can `git diff > some.file.txt `
<DC-IRC>
[Discord] <rpardini> I use the following criteria: if I need to diff or 3-way merge, I do it on a kernel repo. Once done I export patches (git format-patch) so I can PR them to Armbian.
Werner__ is now known as Werner
<DC-IRC>
[Discord] <zeeto9> I will go with this approach to keep consistency and modify my cloned v6.10 linux kernel with the new changes or additions. followed by git format-patch.
<DC-IRC>
[Discord] <zeeto9> Would I then update patch prefix to come before the patches that require it to test locally?
<DC-IRC>
[Discord] <rpardini> `git format-patch` can take the starting prefix as param...
<DC-IRC>
[Discord] <rpardini> - export the last 3 commits
<DC-IRC>
[Discord] <rpardini> - start numbering them from `5000-`
<DC-IRC>
[Discord] <rpardini> about the "logic" of the numbers, that varies per family, and decays over time 😉 for rk3588 I think it's @narga_64 's standard
<DC-IRC>
[Discord] <rpardini> I can just say the patches are _sorted_ based on their filenames, so higher numbers usually mean patch-later rather than sooner
<DC-IRC>
[Discord] <beohoff3174> I've hit some sort of stumbling block to getting this working. I modified the device tree to enable this specifically for orange pi 5 plus, but I'm still not seeing anything in v4l2-ctl.
<DC-IRC>
[Discord] <zeeto9> hopefully ill be up to where you are in a bit. Finishing up the file adds and see if it even builds.
<DC-IRC>
[Discord] <zeeto9> It’s building. I did see synopsis DesignWare related stuff in kernel config, but honestly no idea if it’s specific to this. I also did see an hdmirx option in the menu, but I might have missed it somewhere under drivers. If this build even boots fine, I’ll consider this a success.
<DC-IRC>
[Discord] <zeeto9> im flashing and the going to see what I got. I'd share the log of the build, but it cant be uploaded to armbian becaues its....too big. 🤷♂️
<DC-IRC>
[Discord] <zeeto9> also of note, PATCH v4 1/4 and 2/4 have been reviewed and 3/4 and 4/4 are still in the process
<DC-IRC>
[Discord] <zeeto9> + Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> (✓ DKIM/collabora.com)
<DC-IRC>
[Discord] <zeeto9> ✓ [PATCH v4 3/4] arm64: dts: rockchip: Add device tree support for HDMI RX Controller
<DC-IRC>
[Discord] <zeeto9> ✓ [PATCH v4 4/4] media: platform: synopsys: Add support for hdmi input driver
<DC-IRC>
[Discord] <beohoff3174> Looks like the error I'm getting while trying to load the module is `pinconfig core: failed to register map default (1): no configs given`
<DC-IRC>
[Discord] <zeeto9> Well this first build has the weird display issue I had before building edge. I was hoping with the updates to armbian this would be solved. Very curious as to why I am getting this but not others.
<DC-IRC>
[Discord] <zeeto9> Which is disappointing, because I now add my second patch for the full hdmirx patch (after only applying my add file patches). This time, going through config, it definitely has synopsys hdmirx available. Checked that, a bunch of other stuff seemed to have been added like I see the edid and cec stuff too. I’ll debug tty/uart on the next build if hdmi out is still weird.
<DC-IRC>
[Discord] <zeeto9> Which is disappointing, because I now add my second patch for the full hdmirx patch (after only applying my add file patches). This time, going through config, it definitely has synopsys hdmirx available. Checked that, a bunch of other stuff seemed to have been added like I see the edid and cec stuff too. I’ll debug tty/uart on the next build if hdmi out is still weird.
<DC-IRC>
[Discord] <zeeto9> but this hdmi out is really going to bother me since I seem to be the only one getting it when building edge (even when building with no modifications or additional patches included. just armbian as is....)
<DC-IRC>
[Discord] <zeeto9> ill try a different tv and/or different monitors too... just in case
<DC-IRC>
[Discord] <zeeto9> any chance you had this same option for your build? (the picture above)?
<DC-IRC>
[Discord] <beohoff3174> Yeah, I just set the config in the conf file:
<DC-IRC>
[Discord] <zeeto9> i think you mean "efficient"
<DC-IRC>
[Discord] <zeeto9> oh no....I think I am going to need to disamble my case and careful packaging of it to get to the dedicated uart debugger on the board. Unless, I can utilize the gpio uart as well to screen into my device. I have an esp32c6 connected outside via that and can use that if it works. i really dont want to open it
<DC-IRC>
[Discord] <beohoff3174> Oh snap, I got it to work
<DC-IRC>
[Discord] <zeeto9> what did you do?
<DC-IRC>
[Discord] <zeeto9> correct pins?
<DC-IRC>
[Discord] <beohoff3174> I think the orange pi 5 plus is missing a couple of options for `hdmi0`
<DC-IRC>
[Discord] <beohoff3174> `enable-gpios` and `cec-enable`
<DC-IRC>
[Discord] <beohoff3174> See below in the updated bsp repo
<DC-IRC>
[Discord] <beohoff3174> I added those options, plus a few more in `patch/kernel/archive/rockchip-rk3588-6.10/1021-arm64-dts-Add-missing-nodes-to-Orange-Pi-5-Plus.patch`
<DC-IRC>
[Discord] <zeeto9> Good find. 6.1 is definitely the place to find some of those missing options.
<DC-IRC>
[Discord] <beohoff3174> Changes were `hdmi_receiver` , `hdmi_receiver_cma` , the two changes to `hdmi0` and `hdmirx`
<DC-IRC>
[Discord] <beohoff3174> good riddance, that was like two days worth of work to figure out
<DC-IRC>
[Discord] <beohoff3174> Changes were `hdmi_receiver` , `hdmi_receiver_cma` , the two changes to `hdmi0`, and `hdmirx`
<DC-IRC>
[Discord] <zeeto9> What I have going I can’t really test. I’m logged in over usb tty, but I cant apt update, or —fix-missing or setup ssh, or install v4l
<DC-IRC>
[Discord] <zeeto9> Basically what I’ve concluded is, even if build armbian without any mods, edge branch itself doesn’t work for me. No hdmi out, unable to resolve ports.ubuntu. Not even sure what to do next since this isn’t even related to my patches
<DC-IRC>
[Discord] <zeeto9> I am such a moron. I need INTERNET to do these things…. 😂
<DC-IRC>
[Discord] <beohoff3174> can you build a server image instead of a desktop image?
<DC-IRC>
[Discord] <zeeto9> with iinternet.....plugged in, i was able to update and upgrade. ssh is now setup and I am remoting in. ill worry about hdmi tx another time since I dont care at the moment. as for server, while I rarely utilize a monitor or even sit at my sbc, I do bring up things over x11 forwarding, and when it comes to computer vision stuff, it can be a hassel to get server setup (i might be lazy too)
<DC-IRC>
[Discord] <spooky8086> Looks like Orange Pi is cooking up another RK3588 called the Orange Pi 5 Ultra
<DC-IRC>
[Discord] <zeeto9> i tried too look at their website. what a surprise, its down 🤦♂️
<DC-IRC>
[Discord] <spooky8086> They should do some limited edition boards that are orange lol
<DC-IRC>
[Discord] <runaway97> this is getting beyond ridiculous lol
<DC-IRC>
[Discord] <zeeto9> .....I wouldnt be opposed to the pcb boards being white and orange like the neo 😄
<DC-IRC>
[Discord] <zeeto9> probably be terrible to read the tiny print
<DC-IRC>
[Discord] <runaway97> or maybe black and orange
<DC-IRC>
[Discord] <zeeto9> alright, so here are my next steps going forward on hdmi rx. now that is building with my patches applying, im going to go through manually and check all the areas I am aware of to verify that hdmi rx is being added, that pins are resolved, and whatever else I find.
<DC-IRC>
[Discord] <zeeto9> if we do at some point get hdmi rx successfully working, i might even start looking at what else is missing for v6.10. being on mainline with full or mostly full support would be great