<jix>
cr1901: huh, it passed CI which AFAIK uses the normal Makefile logic to pull the abc version, so that should work, but let me double check....
<cr1901>
I build the FPGA tools once a week to "prime" sccache/make sure things still work. Not sure where rev 20f970f is so I can figure out whether I broke something on my end or not
<jix>
https://github.com/YosysHQ/abc/tree/read_cex_updates is the branch, and the makefile should be able to pull that, but I should have merged that into the YosysHQ/abc/yosys-experimental branch before merging the corresponding yosys PR
<cr1901>
does CI manually set ABC_REV?
<cr1901>
(or has extra logic to "look harder" for commits?)
<jix>
if I do a fresh clone of yosys and just run make it works fine here, do you have any idea what's different for your setup that might break this?
<cr1901>
jix: If you have that fresh clone still, can you run "git branch" inside the abc dir?
<jix>
that just outputs "* (HEAD detached at 20f970f5)" and "yosys-experimental" but the branch is read_cex_updates (of the yosys abc repo not upstream)
<jix>
let me point yosys-experimental at that commit (yosys-experimental is the branch that goes with yosys master, so I should have done that before already, I'm just not sure how not doing that could break things given that it uses the hash not the branch name)
<cr1901>
a clean build works for me as well, interestingly
<cr1901>
Ahhh git branch -r
<cr1901>
origin/read_cex_updates is not in my original yosys copy
<cr1901>
I guess I have to manually add remote branches
<cr1901>
when new ones appear*
<jix>
cr1901: can you try again with an existing clone?
<cr1901>
working fine now (well, it's still compiling ;)...)
<cr1901>
yea it worked fine
<jix>
I updated the yosys-experimental abc branch and that should fix existing clones (and is what I should have done before merging the PR)
<cr1901>
presumably CI succeeds because it's a fresh copy, and your version succeeds because abc already exists w/ the relevant branch/commit on your system
<cr1901>
ahhh well, that was easy enough
<cr1901>
thanks for the help
<jix>
I wonder if there's a good way to check for this during CI while still allowing different branches during development