<marex>
cambrian_invader: I vaguely recall dealing with this 8-byte alignment of fitImage with internal data on aarch64, but that should be fixed in newer u-boot/mkimage versions
mmu_man has joined #u-boot
mckoan|away has quit [Ping timeout: 260 seconds]
zibolo_ has quit [Ping timeout: 252 seconds]
zibolo has joined #u-boot
mckoan|away has joined #u-boot
naoki has joined #u-boot
macromorgan has quit [Quit: Leaving]
jclsn has quit [Ping timeout: 256 seconds]
jclsn has joined #u-boot
LeSpocky has quit [Ping timeout: 255 seconds]
LeSpocky has joined #u-boot
macromorgan has joined #u-boot
mmu_man has quit [Ping timeout: 252 seconds]
Clamor has joined #u-boot
persmule has joined #u-boot
rvalue has quit [Read error: Connection reset by peer]
rvalue has joined #u-boot
monstr has joined #u-boot
mripard has quit [Remote host closed the connection]
joeskb7 has quit [Ping timeout: 245 seconds]
wak has quit [Ping timeout: 256 seconds]
wak has joined #u-boot
stefanro has joined #u-boot
mripard has joined #u-boot
mripard has quit [Remote host closed the connection]
ikarso has joined #u-boot
joeskb7 has joined #u-boot
mckoan|away is now known as mckoan
goliath has joined #u-boot
macromorgan_ has joined #u-boot
macromorgan__ has joined #u-boot
macromorgan has quit [Ping timeout: 245 seconds]
macromorgan_ has quit [Ping timeout: 240 seconds]
macromorgan has joined #u-boot
mripard has joined #u-boot
macromorgan__ has quit [Ping timeout: 268 seconds]
derRichard has quit [Quit: leaving]
sszy has joined #u-boot
frieder has joined #u-boot
prabhakarlad has joined #u-boot
prabhakar has joined #u-boot
prabhakar has quit [Ping timeout: 246 seconds]
prabhakarlad has quit [Ping timeout: 250 seconds]
jmasson has joined #u-boot
prabhakarlad has joined #u-boot
frieder has quit [Ping timeout: 264 seconds]
frieder has joined #u-boot
prabhakarlad has quit [Ping timeout: 250 seconds]
frieder has quit [Ping timeout: 245 seconds]
frieder has joined #u-boot
prabhakar has joined #u-boot
prabhakarlad has joined #u-boot
ikarso has quit [Quit: Connection closed for inactivity]
jmasson has quit []
jmasson has joined #u-boot
prabhakar has quit [Ping timeout: 260 seconds]
prabhakarlad has quit [Ping timeout: 250 seconds]
ikarso has joined #u-boot
dsimic has quit [Ping timeout: 256 seconds]
dsimic has joined #u-boot
prabhakarlad has joined #u-boot
prabhakar has joined #u-boot
Clamor has quit [Ping timeout: 252 seconds]
Clamor has joined #u-boot
mmu_man has joined #u-boot
naoki has quit [Quit: naoki]
monstr has quit [Ping timeout: 252 seconds]
monstr has joined #u-boot
manchaw has quit [Quit: Connection closed for inactivity]
tlwoerner has quit [Ping timeout: 256 seconds]
tlwoerner has joined #u-boot
Stat_headcrabed has joined #u-boot
Stat_headcrabed has quit [Quit: Stat_headcrabed]
redbrain has quit [Read error: Connection reset by peer]
vfazio has quit [Read error: Connection reset by peer]
vfazio has joined #u-boot
Stat_headcrabed has quit [Quit: Stat_headcrabed]
frieder has quit [Remote host closed the connection]
<cambrian_invader>
macromorgan: devicetree?
<macromorgan>
I mean that's possible. I just figured a config option or a macro that can be overridden would be preferable.
slobodan has joined #u-boot
slobodan has quit [Client Quit]
<cambrian_invader>
maybe you could use the adc-keys
goliath has quit [Quit: SIGSEGV]
<cambrian_invader>
actually, I think the binding may already be in your devicetrees
<cambrian_invader>
e.g. arch/arm/dts/rk3308-evb.dts
davlefou has quit [Ping timeout: 256 seconds]
stefanro has quit [Quit: Leaving.]
<macromorgan>
what I'm hoping to do is basically just make the rockchip_dnl_key_pressed() function use a variable instead of a hard coded 1 for the ADC channel (in my board it's channel 0)
<macromorgan>
for the rk3568 series the EVB and all but 1 boards I've messed with so far use channel 1 for board identification and not as a function key
davlefou has joined #u-boot
<cambrian_invader>
right, so you already have all the info in the devicetree, and there is a driver to boot
<cambrian_invader>
do something like `button_get_by_label("function", &dev); button_get_state(dev)`
mmu_man has quit [Ping timeout: 246 seconds]
<macromorgan>
what if I just do #ifndef DNL_KEY_CHANNEL #define DNL_KEY_CHANNEL 1; replace the hard coded 1 with a DNL_KEY_CHANNEL, then define DNL_KEY_CHANNEL for my board as 0?
<cambrian_invader>
I can't say I would consider that a "good way"
<macromorgan>
trying to think of a generic way so I can use the existing code without breaking it for existing users
<macromorgan>
otherwise I can simply do what other boards are doing and replace that weak function with a proper one
<cambrian_invader>
just use the functions I suggested
<cambrian_invader>
this is a generic way which will work for existing code
<cambrian_invader>
as long as you make sure to add it to the devicetree of any devices which were missing
<macromorgan>
unfortunately the ADC channel I want is wired to a joystick not a button. I could rig something in the u-boot specific DTS though I guess.
<cambrian_invader>
well, you are just comparing it to a threshold, right?
<macromorgan>
correct, as long as it's below 30 (which if you cram the joystick all the way down should be true)
<cambrian_invader>
so it's an "adc button" for that purpose
<macromorgan>
okay, so I can redefine it in the U-Boot specific device tree
<cambrian_invader>
see e.g. Documentation/devicetree/bindings/input/adc-keys.yaml
<macromorgan>
correct, I have other devices where this is the case (but due to specific circumstances I thought it was prudent to write my own function for the board... in this case though I can use a generic one and wanted to take the time to improve it)
<macromorgan>
basically have a ton of devices that use channel 0 for a button, but on my current one I use channels 0-3 for a joystick
<macromorgan>
no ADC button, ADC 0-3 are wired to both joysticks
<cambrian_invader>
you could always have both the button and joystick binding
<cambrian_invader>
or use one of the other buttons as a gpio-key
<cambrian_invader>
unless you've already written your manual :P
<macromorgan>
I just got Linux to approve the device tree (I always get Linux approval first before I port U-Boot). Yes a GPIO key could also work, I might just do that.
mmu_man has joined #u-boot
jmasson has quit [Remote host closed the connection]
mckoan is now known as mckoan|away
sakman has quit [Remote host closed the connection]
cambrian_invader has quit [Ping timeout: 264 seconds]
cambrian_invader has joined #u-boot
vagrantc has joined #u-boot
Stalevar has quit [Ping timeout: 255 seconds]
Clamor has quit [Read error: Connection reset by peer]
Clamor has joined #u-boot
monstr has quit [Remote host closed the connection]
Leopold has quit [Remote host closed the connection]
Stalevar has joined #u-boot
Stalevar has quit [Ping timeout: 255 seconds]
Leopold has joined #u-boot
Stalevar has joined #u-boot
ldevulder has joined #u-boot
mmu_man has quit [Ping timeout: 256 seconds]
Clamor has quit [Ping timeout: 252 seconds]
Clamor has joined #u-boot
mmu_man has joined #u-boot
Clamor has quit [Read error: Connection reset by peer]
prabhakar has joined #u-boot
prabhakarlad has joined #u-boot
<macromorgan>
moot anyway it seems... it looks like I can't go back to dnl mode if A-TF has already loaded. I'll just reuse the same function from a different board.
ikarso has quit [Quit: Connection closed for inactivity]