azonenberg changed the topic of #scopehal to: libscopehal, libscopeprotocols, and glscopeclient development and testing | https://github.com/glscopeclient/scopehal-apps | Logs: https://libera.irclog.whitequark.org/scopehal
Degi_ has joined #scopehal
Degi has quit [Ping timeout: 248 seconds]
Degi_ is now known as Degi
<_whitenotifier-9> [scopehal] azonenberg pushed 1 commit to master [+0/-0/±3] https://github.com/glscopeclient/scopehal/compare/694728eeb1a0...f8b50f9c3530
<_whitenotifier-9> [scopehal] azonenberg f8b50f9 - Refactoring to make it easier to spawn file browsers for import filters
<_whitenotifier-9> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±4] https://github.com/glscopeclient/scopehal-apps/compare/8d36702d73bb...1cf64d0676d1
<_whitenotifier-9> [scopehal-apps] azonenberg 1cf64d0 - When creating an import filter, immediately open the file browser dialog. Would be kinda pointless to make an import filter otherwise so this saves a step.
bvernoux has joined #scopehal
Stephie- has quit [Quit: Fuck this shit, I'm out!]
Stephie has joined #scopehal
bvernoux has quit [Read error: Connection reset by peer]
balrog has quit [Quit: Bye]
balrog has joined #scopehal
<_whitenotifier-9> [scopehal] 602p opened pull request #759: R&S RTO6 - https://github.com/glscopeclient/scopehal/pull/759
<_whitenotifier-9> [scopehal] 602p edited pull request #759: R&S RTO6 - https://github.com/glscopeclient/scopehal/pull/759
<_whitenotifier-9> [scopehal] 602p edited pull request #759: R&S RTO6 - https://github.com/glscopeclient/scopehal/pull/759
<_whitenotifier-9> [scopehal] azonenberg closed pull request #759: R&S RTO6 - https://github.com/glscopeclient/scopehal/pull/759
<_whitenotifier-9> [scopehal] azonenberg pushed 3 commits to master [+4/-0/±6] https://github.com/glscopeclient/scopehal/compare/f8b50f9c3530...8565a96182fe
<_whitenotifier-9> [scopehal] 602p 28a2df0 - Pull in RTO6 code
<_whitenotifier-9> [scopehal] 602p 40890d6 - Update to new AFG channel scheme
<_whitenotifier-9> [scopehal] azonenberg 8565a96 - Merge pull request #759 from 602p/rto6-merge R&S RTO6
<azonenberg> @louis: we need to figure out a more proper error handling scheme for drivers etc
<azonenberg> i dont like the idea of LogFatal() as it will take down the entire app
<azonenberg> but continuing also isnt good
<_whitenotifier-9> [scopehal] 602p opened pull request #760: Fix memory leak when reallocating output buffer for autosized histogram - https://github.com/glscopeclient/scopehal/pull/760
<azonenberg> @louis are you sure about #760?
<azonenberg> SetData() should free the previous waveform if there is one
<azonenberg> this looks like it could cause a double free
<d1b2> <louis> Hm. Yeah looks like you're right. I retract that PR. I've been carrying that locally for quite some time lol
<_whitenotifier-9> [scopehal] 602p commented on pull request #760: Fix memory leak when reallocating output buffer for autosized histogram - https://github.com/glscopeclient/scopehal/pull/760#issuecomment-1480389556
<_whitenotifier-9> [scopehal] 602p closed pull request #760: Fix memory leak when reallocating output buffer for autosized histogram - https://github.com/glscopeclient/scopehal/pull/760
<d1b2> <louis> I'm also carrying a filter that just drops samples with duration under a configurable limit as a glitch removal filter. Is there something we already have I missed that does this, or should I PR that?
<d1b2> <louis> and yes: driver error handling: that would also be good for the case where scopes get their SCPI so locked up that manual intervention is required to reset it (but where it's not just borked)
<d1b2> <louis> oh i have a unrelated UX question, which is that I want the ability to load a session against a scope with a different serial / maybe even different model
<d1b2> <louis> i have that check just commented out -- how do we want to handle that more generally? flags for --ignore-serial-check and --ignore-model-check? in general I think the serial check probably shouldn't be needed
<d1b2> <louis> since even having the same serial dosen't guarantee that the saved configuration is still valid in the presence of expiring license options or whatever
<azonenberg> I dont think we have such a glitch removal
<azonenberg> and yeah, agreed. In general i want to have some kind of sanity checking
<azonenberg> so that, for example, we look at the current voltage on a power supply when loading a saved config
<azonenberg> and if the new voltage is significantly higher, it will ask you to confirm before pushing the change
<azonenberg> basically i want to make it so that loading the wrong scopesession won't blow out your DUT and a bunch of instrument channels
<azonenberg> and basically the purpose of the check was to assume that you are reconnecting to the literal same experimental setup you were on before
<azonenberg> i was even going to add checks for the same active probes on the same channels
<azonenberg> maybe make it something you can click through rather than instantly failing
<azonenberg> but it's the kind of thing that you want to be really sure about