<_whitenotifier-e>
[scopehal-sigrok-bridge] 602p ef25365 - Sketch of deadline-based flow control
Degi has joined #scopehal
<d1b2>
<louis> @azonenberg I'm hacking around on cleaning up the UI issue re: high granularity for trigger offset. Communicating the actual offset back to glscopeclient is easy enough, but the question is what to do with it. We can update the Oscilloscope's view of the trigger offset, but that's scope-wide state for what is actually capture-wide data, so the UI will display the wrong trigger offset if one selects historical waveforms.
<d1b2>
<louis> (This is an issue/bug that already occurs if you change the trigger position and then look back via the history window.)
<d1b2>
<louis> So it might make sense to refactor to fix that at the same time? Which would probably mean adding a trigger position field to WaveformBase or to SequenceSet (and making it no longer a type alias.)
<azonenberg>
Hmmm
<azonenberg>
Storing historical trigger position would be nice to have but we'd have to change a lot of stuff including but not limited to the file format
<azonenberg>
I'd suggest filing a ticket for it so we get to it later
<azonenberg>
but don't make it the highest priority