ifreund changed the topic of #river to: river - a dynamic tiling wayland compositor || https://github.com/riverwm/river || channel logs: https://libera.irclog.whitequark.org/river/
StopNGo has joined #river
waleee has quit [Ping timeout: 268 seconds]
snakedye has quit [Ping timeout: 252 seconds]
elshize has quit [Ping timeout: 268 seconds]
elshize has joined #river
StopNGo has quit [Ping timeout: 268 seconds]
snakedye has joined #river
eShaev9z_ has joined #river
eShaev9z has quit [Ping timeout: 268 seconds]
snakedye has quit [Ping timeout: 252 seconds]
elshize has quit [Ping timeout: 268 seconds]
elshize has joined #river
elshize has quit [Ping timeout: 252 seconds]
elshize has joined #river
kitty4 has quit [Ping timeout: 268 seconds]
<NickH> vertical24: I like that idea for stacktile.
elshize has quit [Ping timeout: 268 seconds]
<leon-p> yeah stacktile is in need of a redesign and I have a decently long list of features I'd like to support, but it might take me some time to get around to it
elshize has joined #river
<NickH> leon-p: I had a go at implementing it.
<leon-p> ah, neat!
<NickH> First time using sourcehut. Haven't yet worked out how to do merge/pull request or equivalent.
<NickH> Seems to be email based.
<leon-p> yup, just send a mail my way
<leon-p> probably useful: https://git-send-email.io/
<NickH> Just reading it now. Installing git-email...
<NickH> I *think* just sent it.
<leon-p> you did, arrived just fine!
<NickH> Nice.
<leon-p> Now the only nit-pick I have is that the feature should be optional, other than that this looks fine.
<NickH> Ok. I'll try to implement that.
<leon-p> it's fine if you don't, stacktile will be re-written in zig at some point, so I don't care much about quality and feature-set right now
<NickH> I'll try anyway. How about calling the option "limit-primary-count"?
<leon-p> sure, that's good
wrkzk has quit [Ping timeout: 268 seconds]
kitty4 has joined #river
<NickH> Ok.. done. Now the man page.
<novakane> ah stacktile in zig, nice :D
<leon-p> yeah, makes the things I have planned a bit nicer to implement
<NickH> hmm my changes have unintended consequences when main count is 0 and then "main-count -1" command is sent.
<NickH> Usng the MIN macro with a mix of uint32_t and int32_t and ternary operators... getting messy.
<leon-p> probably easier if you just use a helper variable and no ternaries
<NickH> Yeah, was trying to implement in as few lines of code as possible.
<leon-p> don't worry about LOC too much, cleaner code is more important than fewer lines
<NickH> Think I'll try with conditionals, make sure it works as intended, then think about how to make it cleaner.
kitty4 has quit [Ping timeout: 268 seconds]
<leon-p> when you're done, I'll tag 1.0.0 so that my rewrite can be 2.x
kitty4 has joined #river
<NickH> Looking at the code in the head of master I see https://0x0.st/o2VL.c
<NickH> This puzzles me becuase the uint32_t cast makes is look like it can't decrement the the primary_count. I guess it is doing something with the uint wrapping around?
talismanick has quit [Ping timeout: 244 seconds]
<leon-p> damn, that actually is a weird bit of code. It works, but it's not very obvious
<leon-p> feel free to improve the readability of that
<leon-p> btw, you may want to use the CLAMP macro
<leon-p> that should probably make the intent a bit clearer
<NickH> Yeah.
<NickH> So your current implementation will happliy wrap primary_count around at both the upper and lower limits of uint32_t?
<leon-p> tbh I can't really get in the headspace right no to understand what I committed about a year ago at 22:01 in the night, likely high on caffeine
<leon-p> but it does remind me that I really should lobby for 383 to make it into the next release
<leon-p> which I apparently created around the same time I wrote that code, neat
snakedye has joined #river
<NickH> Ok, think I understand what the existing code was doing. It didn't wrap at zero, it just kept primary_count equal to zero if there was an attempt to decrement it.
<NickH> I sqaushed my changes into a single commit. My testing indicates that it works correctly.
<NickH> It is quite readable (to me at least) and I think it conforms with the style you are using.
<NickH> I just sent it.
<leon-p> I'll have a look when I am back
kitty4 has quit [Ping timeout: 268 seconds]
kitty4 has joined #river
<NickH> Cheers
elshize has quit [Ping timeout: 252 seconds]
elshize has joined #river
snakedye has quit [Ping timeout: 255 seconds]
snakedye has joined #river
kitty4 has quit [Ping timeout: 264 seconds]
kitty4 has joined #river
mannerism has quit [Remote host closed the connection]
mannerism has joined #river
kitty4 has quit [Ping timeout: 268 seconds]
snakedye has quit [Ping timeout: 268 seconds]
snakedye has joined #river
_whitelogger has joined #river
fitrh has joined #river
snakedye has quit [Ping timeout: 268 seconds]
fitrh has quit [Quit: fitrh]
waleee has joined #river
snakedye has joined #river
wrkzk has joined #river
snakedye has quit [Ping timeout: 268 seconds]
snakedye has joined #river
snakedye has quit [Ping timeout: 268 seconds]
snakedye has joined #river
snakedye has quit [Remote host closed the connection]
snakedye has joined #river
me_ has joined #river
me_ is now known as Ordoviz
Ordoviz has quit [Quit: Ordoviz]
me_ has joined #river
me_ has quit [Remote host closed the connection]
talismanick has joined #river
Ordoviz has joined #river
Ordoviz has quit [Ping timeout: 252 seconds]
Ristovski has joined #river
talismanick has quit [Ping timeout: 244 seconds]
<Ristovski> river has no trouble starting under x11 when wlroots has the x11-backend enabled, however riverctl prints "error: ConnectFailed", any ideas? or is this simply not possible
<Ristovski> ah, it works when you set WAYLAND_DISPLAY
kitty4 has joined #river
snakedye has quit [Ping timeout: 252 seconds]