06:37 <novakane> ifreund: nice, I'll try to implements the new libwayland function in my clients to see how it goes

06:47 <novakane> never saw that there was an @errorName, that's better than having the enum name

08:53 <novakane> ifreund: one question, why do you use snake case function name in Lock.zig?

08:55 <ifreund> novakane: got spoiled working on tigerbeetle... I just prefer snake case. Got my fingers crossed that I can convince andrew to make that change to the official style guide

08:56 <novakane> ifreund: get you, I'll also prefer snake case, more readable, so I hope you can convince him to change it too :D

08:56 <ifreund> compare the readability of putAssumeCapacityNoClobber() and put_assume_capacity_no_clobber() at smaller font size or from farther away

08:57 <novakane> yeah I think that the only thing I really hate in the style guide :/

08:57 <ifreund> novakane: also @errorName(error.Foo) is just Foo

08:57 <ifreund> I just don't trust std.fmt and don't want it to print "error.Foo"

08:58 <novakane> that nice, I'll use it, not a fan of error.Foo in log message

09:01 <novakane> ifreund: and btw, I'm not usually a fan of c_int but I vote in favor of it in the display functions

09:48 <ifreund> another option there would be to make the functions return the errno enum from zig's std directly

09:49 <ifreund> I don't think I've ever seen any code actually use the "number of things processed" that libwayland returns on success

09:52 <novakane> yeah that would works too, would make code less verbose if errno is already in the bindings, I'd just like to have a switch instead of using try

09:53 <novakane> both are fine for me, both are better that what we currently have imo

10:53 <novakane> so looking at my code, I think I would chose to return the value of os.getErrno(), seems like the cleaner things todo

11:00 <ifreund> a Zig error set would be better really, but figuring out all possible errno values libwayland can return for a given function isn't really feasiable

11:01 <novakane> yeah that why the errno enum is probably the best choice imo

17:49 <pkap> ifreund: I'm quite happy with my PR for layout-pinned mappings now. There is however an open question I'm thinking about. Not sure if this is important to you (or others).

17:49 <pkap> It's a bit complicated so I tried to explain it in detail in this comment: https://github.com/riverwm/river/pull/577/files#diff-8281ee4cb120abe2f08f3b8f08b7a807874bc63fc7151348535ef405732d111eR366

17:49 <pkap> I'd appreciate your thoughs on this (Doesn't have to be now of course)

17:50 <pkap> And anybody else too, of course :)

18:01 <ifreund> pkap: cool, thanks for writing that up. Hopefully we can finally get that PR merged soon

18:02 <ifreund> I'm off to the bouldering gym now though, catch y'all later o7

18:05 <pkap> Have fun ifreund :)

18:43 <novakane> now that we have some keyboard expert someone gonna finish the IME PR instead of me :P

18:59 <pkap> novakane: I hope you don't mean me when you speak of expertise '=D

19:03 <novakane> pkap: not at all, I was thinking about pmkap on github... :P

19:09 <pkap> novakane: :D Is the IME thing implemented in sway or are you the first trying to do this?

19:14 <novakane> pkap: it is in sway, my PR is based a lot on sway implementation, just missing the keyboard grab part

19:28 <pkap> novakane: I see. What client do I need to test this?

19:45 <novakane> pkap: I used to test with https://github.com/tadeokondrak/anthywl and foot, just launching anthywl and in foot iirc writing `ta` would start it

19:49 <pkap> novakane: Thanks, I'll check it out!

19:53 <novakane> couldn't make it works with the current implementation of the keyboard in river, but then I was pretty lost in it xD

20:51 <tleydxdy[m]> does fcitx5 work with wayland?

20:52 <tleydxdy[m]> if so I can test too

22:01 <novakane> not sure if fctix5 implement the Wayland protocol, I know it works if you use it with GTK apps but not sure in something like foot

22:18 <NickH> I have fctix5 working in gtk apps but not in foot.

22:21 <tleydxdy[m]> I have it working on xwayland right now, I just make everything I need to type stuff in run under X :)