08:37 <yyp> What version of wlroots river currently requires?

08:45 <yyp> Nevermind, for some reason I thought it did require wlroots git master but it works with stable releases just fine

18:44 <novakane> why firefox popup works when I launch river in river though... weird

19:06 <leon-p> novakane: which popups do you mean? For me everything works fine in iceweasel. I think iceweasel is based on firefox-esr?

19:07 <novakane> like the one from the bitwarden extension

19:08 <Misthios> wasnt iceweasel killed in 2016?

19:08 <Misthios> so is it even wayland native

19:12 <leon-p> Misthios: you are thinking of the other ice one (icecat I think?) Iceweasel is the newer one. And yes, it is wayland native. I have river build without xwayland

19:12 <Misthios> wasnt iceweasel the debian "firefox" without branding

19:12 <Misthios> ?

19:13 <Misthios> and oh

19:13 <leon-p> more or less. It is the firefox fork that commonly comes with distributions that take FOSS a bit more seriously.

19:13 <leon-p> also all the DRM crap and pocket / share / whatever are ripped out

19:14 <Misthios> ah

19:28 <novakane> like the one from the bitwarden extension

19:28 <novakane> oh I didn't send the message smh

19:28 <novakane> oh yeah I did

19:28 <novakane> I'm tired

19:33 <novakane> anyway I think on firefox the subsurface aren't rendered if there is no damage on the parent surface

19:33 <novakane> Idon't know why though

19:37 <leon-p> maybe they forgot to commit the parent surface?

19:43 <novakane> well I don't see anything missing on what ifreund did, firefox probably makes something different, but I can't find what for now

19:44 <leon-p> anyway, I have been using river as my main desktop again since the damage tracking got implemented and it works really great. As far as I am concerned, the user-exposed functionality is pretty much where it should be, bar some multi-monitor stuff and a minimal amount of eye-candy.

19:44 <leon-p> novakane: do you have the same issue in sway?

19:48 <novakane> leon-p: nope, only on river since the damage tracking commit

19:48 <leon-p> very interesting.

19:49 <leon-p> I'll take a look at it, but I can't promise anything since I don't have the same issue

19:50 <novakane> like for exemple if I'm typing my password to unlock bitwarden the text is not displayed unless I move my mouse

19:51 <novakane> or if something is rendering in the tab behind

19:51 <inclement> I recently implemented damage tracking in another compositor - many times I thought it was working until it once again firefox's many subsurfaces revealed a mistake in my surface handling!

19:51 <inclement> In this case I wonder, is it possible river is failing to bind to events of subsurfaces that already exist when the xdg-popup (or maybe other things) is created? I'm not at all familiar with river or zig, but I don't see this in XdgPopup.zig

19:53 <leon-p> That is an interesting idea.

19:54 <leon-p> Although subsurfaces are handled elsewhere AFAIK

19:54 <leon-p> Subsurface.zig

19:55 <inclement> Well, again I don't know zig at all, but it looks like this handles manipulation of subsurfaces - in this case I'm suggesting it's never invoked for existing subsurfaces

19:56 <inclement> I had something similar at one point, the result was a lot like novakane describes, and I only ever saw firefox making use of subsurfaces this way

19:57 <leon-p> I think the best way to test that is to rig up a test client that creates surfaces and subsurfaces and afterwards assigns xdg toplevel/pop-up surface roles.

19:57 <leon-p> I am a bit distracted right now, but I'll put it on my list

20:00 <novakane> inclement: I think you're on something, I'll try to see if I can make it

20:01 <leon-p> novakane: if you want to write a test client, you can start with river-tag-indicator. It is pretty simple to convert that into a simple xdg shell window. It's what I did for my snake game as well :P

20:04 <novakane> I saw somethinng about synced/desynced surface, this afternoon and I though it was something about that

20:05 <novakane> leon-p: well maybe or maybe i'm just waiting for ifreund to read this :P

20:05 <leon-p> hehe :P

20:30 <novakane> inclement: so you're vivarium's developer?

20:31 <inclement> Yep

20:36 <novakane> indeed I see that damage tracking commits are really recent, you're right in it too

20:44 <inclement> Yeah, it was quite fiddly. I think river is in much better shape for it though, I didn't understand the surface tree structure well in advance but river looks to handle it all properly already