<zapb_>
It compiles on all systems but distcheck fails. If I run distcheck on my machine then it already fails with #include errors of other files
<borneoa___>
zapb_: in the makefile you need to add the new file .h in the list with all the other .h
<zapb_>
borneoa___, AH!
<zapb_>
Damn... :D
<zapb_>
Well, still fails for other files an my system. For example jtag/drivers/angie.c
<borneoa___>
zapb_: but what the reason for having that new .h? It is only referenced in the associated .c, so the content can be inlined inside the .c!
<zapb_>
borneoa___, it's used later for the flash loader
<borneoa___>
zapb_: I see one patch in Gerrit for Angie build, but no time to check it yet
<zapb_>
borneoa___, not happy with how flash drivers work at the moment but changing it needs lot of rework
<borneoa___>
zapb_: you mean there would be a following commit that uses it?
<zapb_>
borneoa___, I already have a patch for a flash loader that uses the #include file, but it needs more testing and I wanted to push a version without loader
<zapb_>
borneoa___, I think moving everything into the *.c file and then later back to *.h is waste of time
<borneoa___>
zapb_: ok!
<PaulFertser>
zapb_: that looks like some non-trivial driver covering the big set of devices, looks very nice! Was it really developed a year ago? You put Copyright (C) 2023 there.