12:09 <PaulFertser> borneoa_: I think I spotted an issue probably worth fixing before the release: "autoreconf -v -f" overwrites configure in jimtcl with autoconf, and so everything fails in a on odd way.

12:15 <PaulFertser> I can't see any sane workaround yet, other than running jimtcl configure manually, without AX_CONFIG_SUBDIR_OPTION

12:20 <PaulFertser> (the issue leads to ftbfs on OpenWrt)

12:32 <PaulFertser> autoreconf would ignore jimtcl if there wasn't configure.ac present.

12:40 <PaulFertser> borneoa_: I think jimtcl shouldn't be shipping configure.ac, and OpenOCD configure should be checking for jimtcl/configure rather than jimtcl/configure.ac , then it works.

12:57 <PaulFertser> Damn, wished I tried it two months earlier.

13:12 <PaulFertser> borneoa_: https://termbin.com/ynqx this makes it buildable on OpenWrt.

13:19 <borneoa_> PaulFertser: even with that patch to OpenOCD configure.ac, by running autoreconf -f -v we get jimtcd/configure overwritten

13:20 <PaulFertser> borneoa_: yes, autoreconf won't overwrite it only if jimtcl/configure.ac is removed beforehand.

13:23 <borneoa_> In git log of jimtcd, the dummy configure.ac was added otherwise automake complains. Let me check if it's true

13:23 <PaulFertser> I tried building without it, and nothing complained.

13:27 <borneoa_> Need both fix in OpenOCD configure.ac and jimtcd removal of configure.ac

13:28 <borneoa_> But if we remove it from OpenOCD script, we will get version with -dirty string in the build.

13:28 <PaulFertser> Yes, in my testing that's enough to make OpenWrt build it.

13:30 <PaulFertser> Not sure if this issue should be considered a release blocker. It's a problem in jimtcl essentially.

13:44 <borneoa_> Marc has sent a patch to make libjaylink by default not a submodule but to be installed as system library. Should we move to split from jimtcd as submodule too?

13:45 <PaulFertser> I kinda like that jimtcl /can/ be internal, as a submodule.

13:45 <borneoa_> Jimtcl has added configure.ac because required by OpenOCD. we can now remove it, but it will happen in next jimtcl release

13:48 <PaulFertser> It's not like we'd be in trouble by starting to check for jimtcl/configure instead of configure.ac now?

13:55 <borneoa_> Jimtcl has its own configure system that is not based on autoconf. It only has the file configure and no need for configure.ac, which was added with dummy content to work with our build system. Today checking jimtcl/configure works fine, but will fail if one day openocd moves to autoconf

13:55 <borneoa_> Sorry, will fail if jimtcl moves to autoconf

13:57 <PaulFertser> jimtcl won't move to autoconf I'm pretty sure

13:59 <borneoa_> Me too! That's the configure system made by Steve

14:00 <borneoa_> So we could make the change in openocd and propose dropping the dummy jimtcl/configure.ac by next release

14:01 <borneoa_> Still in meantime autoreconf -f -v will make mess. Would it be okay for openwrt?

14:04 <PaulFertser> For OpenWrt no problem, I'll just remove it prior to autoreconf.

14:04 <PaulFertser> https://termbin.com/ynqx

14:07 <borneoa_> Ok than. I have reviewed all the history of OpenOCD configure.ac, we always tested for jimtcl/configure.ac and this required the dummy file in 2011.

14:08 <borneoa_> Will you propose a patch?

14:12 <borneoa_> Also buildroot runs autoreconf and can have issues. So it would be good to have first the fix in OpenOCD, in 0.12.0, then the other fix in next release of jimtcl. We need this sequence of fixes

14:13 <PaulFertser> borneoa_: I agree. Can you send a patch yourself?

14:14 <PaulFertser> borneoa_: it's silly jimtcl agreed to include dummy file instead of telling us to fix OpenOCD :)

14:14 <borneoa_> No problem, I will send it soon.

14:15 <borneoa_> Agree, the fix should have been in OpenOCD back in 2011, not in jimtcl

14:27 <borneoa_> PaulFertser: where did you took the patch for openwrt? I would like to add a ref in OpenOCD patch

14:29 <PaulFertser> borneoa_: what I showed on termbin is what I figured out myself this morning

14:31 <borneoa_> PaulFertser: ok. There is no ticket or merge request so far?

14:31 <PaulFertser> borneoa_: nope, I planned sending a github pull request to openwrt packages feed after tagging but decided it's worth a try compiling before.

14:36 <borneoa_> Gerrit 7437

14:47 <PaulFertser> borneoa_: thank you! I guess I'll submit it in the evening and then will proceed with the tagging procedure.

14:48 <borneoa_> Ok. I'm preparing the patch for jimtcl. I will wait for the tag so I can referryit in the commit message

14:49 <borneoa_> s/referryit/reference it/

22:08 <karlp> what's -v -f do, I've always used autoreconf -i when I've needed this shit

22:08 <karlp> you know what, I don't wanmt to know, I've gotten away without knowing, let's keep it that way